chore: fixes for saved addresses tests #441
Conversation
Valentina1133
force-pushed
the
chore/fix_nightly_tests
branch
2 times, most recently
from
01cbf94 to
5a9380a
Compare
Valentina1133
requested review from
anastasiyaig,
borismelnik and
glitchminer
| with step('Fill in the form and preferred networks and add the address'): | ||
| add_saved_address_popup.add_saved_address(name, address) | ||
|
|
||
| with step('Verify recently added saved address is present in the list'): |
There was a problem hiding this comment.
the reason i was checking the toast message before checking the list is that toast message disappears quickly so perhaps it is better to check the toast first which appears right away when you click the Add button and then verify the list of addresses, wdyt @Valentina1133 ?
There was a problem hiding this comment.
I changed it on purpose, because after some changes in the app the toast message appears not so quickly and it’s better to check first that the address appeared. You can check it in nightly runs. Unfortunately we cannot add wait for for toast message , so this is the only option I found. If you have more ideas let me know I will try it
There was a problem hiding this comment.
sure, thats perfect then :)
gui/objects_map/wallet_names.py
Outdated
| savedAddressView_Delegate = {"container": mainWallet_Saved_Addreses_List, "objectName": RegularExpression("savedAddressView_Delegate*"), "type": "SavedAddressesDelegate", "visible": True} | ||
| send_StatusRoundButton = {"container": "", "type": "StatusRoundButton", "unnamed": 1, "visible": True} | ||
| savedAddressView_Delegate_menuButton = {"container": mainWindow_SavedAddressesView, "objectName": RegularExpression("savedAddressView_Delegate_menuButton*"), "type": "StatusRoundButton", "visible": True} | ||
| savedAddresses_area = {"container": mainWindow_SavedAddressesView, "type": "SavedAddresses", "unnamed": 1, "visible": True} |
There was a problem hiding this comment.
in case we can add an object name for that - i think we should go with it
There was a problem hiding this comment.
Added) Created PR - status-im/status-desktop#13216 and also changed in object map
Valentina1133
force-pushed
the
chore/fix_nightly_tests
branch
from
5a9380a to
673ce98
Compare
3 participants
CI run:
https://ci.status.im/job/status-desktop/job/e2e/job/manual/1267/
Allure report locally: