Skip to content
This repository was archived by the owner on Aug 13, 2024. It is now read-only.

Conversation

@Valentina1133
Copy link
Contributor

@Valentina1133 Valentina1133 commented Mar 12, 2024

  • Joined 2 tests together
  • Refactored it using multiple instances and checking state in community

CI run:
https://ci.status.im/job/status-desktop/job/e2e/job/manual/1636/

Screenshot 2024-03-12 at 12 07 46

@Valentina1133 Valentina1133 self-assigned this Mar 12, 2024
@anastasiyaig anastasiyaig force-pushed the chore/update_online_offline_test branch from ca2e1b2 to 08e279d Compare March 12, 2024 07:41
@allure.step('Verify member is online by index')
def member_is_online(self, index: int) -> str:
self._member_item.real_name['index'] = index
return self._user_badge_color.object.color.name == '#4ebc60'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it makes sense to keep color values somewhere in enum? i think we have one somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right! Fixed

@anastasiyaig anastasiyaig force-pushed the chore/update_online_offline_test branch from a7f6f95 to 46dab48 Compare March 13, 2024 08:31
@anastasiyaig anastasiyaig merged commit 47a4737 into master Mar 13, 2024
@anastasiyaig anastasiyaig deleted the chore/update_online_offline_test branch March 13, 2024 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] change tests for online/offline status to use multiple instances UI tests: Can see other members online in the community

2 participants