Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tentative] Implement topic advertisement in discovery v5 #182

Open
kdeme opened this issue Mar 4, 2020 · 4 comments
Open

[Tentative] Implement topic advertisement in discovery v5 #182

kdeme opened this issue Mar 4, 2020 · 4 comments
Labels

Comments

@kdeme
Copy link
Contributor

@kdeme kdeme commented Mar 4, 2020

As defined in specification here: https://github.com/ethereum/devp2p/blob/master/discv5/discv5-theory.md#topic-advertisement

Put tentative for now, due to possible changes of specification.

@kdeme kdeme added the discoveryv5 label Mar 4, 2020
@kdeme kdeme changed the title Implement topic advertisement in discovery v5 [Tentative] Implement topic advertisement in discovery v5 Mar 5, 2020
@decanus

This comment has been minimized.

Copy link
Member

@decanus decanus commented Mar 19, 2020

@kdeme I could start working on this in an experimental manner.

@kdeme

This comment has been minimized.

Copy link
Contributor Author

@kdeme kdeme commented Mar 19, 2020

@decanus Sure, I've just put this to tentative for now as I understood that the Topic advertisement as it is written now in the specification was probably going to get an overhaul because the topic radius estimation has issues.

@oskarth

This comment has been minimized.

Copy link
Member

@oskarth oskarth commented Mar 20, 2020

@kdeme do you have a link to the "topic radius estimation has issues" problem?

@decanus

This comment has been minimized.

Copy link
Member

@decanus decanus commented Mar 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.