You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently nodes are (re)validated by a periodic ping and removed from the routing table at first failure to reply.
This should be improved, e.g.:
No action should be taken on first failure. It should be marked stale after n (=5 ?) failures.
The replacement cache should be used: When a node goes stale, it should be replaced with a (non stale?) entry from the replacement cache, if there is one.
If there is no entry in the replacement cache, no immediate removal of the node should happen. Instead it should be removed when a new node for that bucket is added.
Considering that this replacement system (and kbucket ordering in general) is not really used currently (nodes only get added to it) and that there are no tests, it is possible that there are some hidden issues in the current code.
There also seems to be no current limitation on adding to the replacement cache.
Also the nodeToRevalidate should probably target least recently updated bucket.
The text was updated successfully, but these errors were encountered:
Currently nodes are (re)validated by a periodic ping and removed from the routing table at first failure to reply.
This should be improved, e.g.:
stale
after n (=5 ?) failures.Considering that this replacement system (and kbucket ordering in general) is not really used currently (nodes only get added to it) and that there are no tests, it is possible that there are some hidden issues in the current code.
There also seems to be no current limitation on adding to the replacement cache.
Also the
nodeToRevalidate
should probably target least recently updated bucket.The text was updated successfully, but these errors were encountered: