Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity compatibility #77

Merged
merged 3 commits into from Jul 4, 2019

Conversation

@kdeme
Copy link
Contributor

commented Jul 3, 2019

2 commits to be able to connect with a Parity client, 1 commit with some updated debug information.

Tested with Nimbus. Nimbus now connects to geth and parity nodes.

Specific code that in Parity that required these changes:

Based myself on this spec: https://github.com/ethereum/devp2p/blob/master/rlpx.md#framing & https://github.com/ethereum/devp2p/blob/master/rlpx.md#ping-0x02

kdeme added some commits Jul 3, 2019

@kdeme kdeme requested a review from zah Jul 3, 2019

@zah

zah approved these changes Jul 3, 2019

@kdeme kdeme merged commit 3d2436d into master Jul 4, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the parity-compatibility branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.