Fix compilation on devel #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Oct 24, 2022
arnetheduck
reviewed
Oct 24, 2022
arnetheduck
reviewed
Oct 24, 2022
stew/ranges/typedranges.nim
Outdated
| if not isLiteral(a): | ||
| shallowCopy(result.gcHold, a) | ||
| else: | ||
| result.gcHold = a |
There was a problem hiding this comment.
this defeats the purpose of the ranges entirely - I'd probably go for deprecating the whole library since there's some work on view types being done in the language, but @zah might have some plans?
There was a problem hiding this comment.
Can we merge this & move this into an issue? Or I can revert the changes to typedranges only fix results, but would be nice to be able to use results with devel
|
Disabled ranges with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests are not passing since shallow copies are not a thing in orc. Not sure how to go forward about this, could just disable the shallow tests in devel, but maybe users are relying on this functionality?