Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event subscriptions #2

Merged
merged 5 commits into from Jul 22, 2019

Conversation

@yglukhov
Copy link
Contributor

commented Jun 12, 2019

No description provided.

@yglukhov yglukhov force-pushed the subscriptions branch 16 times, most recently from 40b9e48 to 2cb32c8 Jun 17, 2019

@yglukhov yglukhov force-pushed the subscriptions branch from 2cb32c8 to e0d3680 Jun 19, 2019

@yglukhov yglukhov referenced this pull request Jul 18, 2019
@zah

zah approved these changes Jul 19, 2019

@@ -30,3 +23,90 @@ proc fromJson*(n: JsonNode, argName: string, result: var ref UInt256) =
new result
result[] = hexStr.parse(StUint[256], 16) # TODO: Handle errors

proc bytesFromJson(n: JsonNode, argName: string, result: var openarray[byte]) =

This comment has been minimized.

Copy link
@zah

zah Jul 19, 2019

Member

Was the json serialization code and the ethcalls singnatures file copied from nimbus (or the former nim-json-rpc repo)? I guess it makes sense to have it shared between the projects, because it describes the same RPC interface.

@zah zah merged commit cd3be5a into master Jul 22, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the subscriptions branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.