Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block 1.352.922 doesn't have a test case #363

Closed
jangko opened this issue Aug 6, 2019 · 1 comment
Closed

block 1.352.922 doesn't have a test case #363

jangko opened this issue Aug 6, 2019 · 1 comment

Comments

@jangko
Copy link
Contributor

jangko commented Aug 6, 2019

PR #357 doesn't include a test case. In the past, the problematic code already fixed numerous times. Probably because of premature optimization while the code was written first time.

Better to have a test case to prevent further regression. To generate a test case, a database contains information about the block should available. Then use persistBlockTestGen tool in folder tests/ to generate a json test case.
kdeme added a commit that referenced this issue Aug 14, 2019
@kdeme
Add PersistBlockTest for block 1352922, fixes #363
de924b3
kdeme added a commit that referenced this issue Aug 14, 2019
@kdeme
Add PersistBlockTest for block 1352922, fixes #363
b4b096e
jangko added a commit that referenced this issue Aug 15, 2019
@jangko
Merge pull request #375 from status-im/addBlockTest
fc6dcfc 
Add PersistBlockTest for block 1352922, fixes #363
@jangko
Copy link
Contributor Author

jangko commented Aug 15, 2019

fixed by #375, closing

@jangko jangko closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jangko