Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI - Wallet Stability] Create BridgeModal from SendModal as a new and isolated component #15216

Closed
Tracked by #15688 ...
noeliaSD opened this issue Jun 17, 2024 · 4 comments
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor wallet-team
Milestone

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024

Some pseudo-code:

StatusDialog {
    id: root

    property var selectedAccount
    property var selectedToken
    property var selectedAmount
    property var bestRoutes

    property models needed

    header: AccountSelector { ... }

    ColumnLayout {
        RowLayout {
            Bridge Text
            +
            Holdings selector
            +
            Max button component
        }
        StatusAmountInputPanel 1 (bridge) {}
        RouterPanel {}
    }

    footer: TransactionModalFooter { ... }
}

It should implement the new design flow defined in here (bridge will also follow it):

Screenshot 2024-06-17 at 16 44 06

Note: Bridge design reference

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Jul 1, 2024

@caybro please, sync with @micieslak and me before starting! There is a new design flow to have better consistency with the SendModal but probably the description is not updated!

New Figma

@anastasiyaig
Copy link
Contributor

lets also aim to avoid this confusion what is selected and what is not (current state on the video below)

Screen.Recording.2024-07-02.at.13.22.48.mov

@noeliaSD noeliaSD assigned noeliaSD and unassigned caybro Jul 8, 2024
@noeliaSD
Copy link
Contributor Author

Due to lack of capacity, we will keep the bridge inside send modal as per now and will do the separation during next milestone, since send modal will be in a better shape by then.

@alexjba
Copy link
Contributor

alexjba commented Aug 21, 2024

The SendModal/Bridge will go through a re-design

@alexjba alexjba closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor wallet-team
Projects
Status: Done
Development

No branches or pull requests

6 participants