Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CTRL+K (jump to) modal is case sensitive #8685

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

caybro
Copy link
Member

@caybro caybro commented Dec 7, 2022

make the ChannelPicker/StatusSearchListPopup search case insensitive

Fixes #8460

Affected areas

AppMain/StatusSearchListPopup

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

make the ChannelPicker/StatusSearchListPopup search case insensitive

Fixes #8460
@caybro caybro linked an issue Dec 7, 2022 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Dec 7, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a85a5ba #1 2022-12-07 15:24:06 ~6 min linux-cpp 📄log
✔️ a85a5ba #1 2022-12-07 15:24:28 ~6 min imports 📄log
✔️ a85a5ba #1 2022-12-07 15:27:57 ~10 min macos 🍎dmg
✔️ a85a5ba #1 2022-12-07 15:33:10 ~15 min linux 📦tgz
✔️ a85a5ba #1 2022-12-07 15:46:24 ~28 min linux-e2e 📄log
✔️ a85a5ba #1 2022-12-07 15:47:14 ~29 min windows 💿exe

Copy link
Member

@0x-r4bbit 0x-r4bbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@caybro caybro merged commit c32dfa4 into master Dec 7, 2022
@caybro caybro deleted the 8460-ctrl+k-jump-to-modal-is-case-senstive branch December 7, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL+K (jump to) modal is case senstive
4 participants