Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waku/0 service #1715

Merged
merged 7 commits into from Dec 20, 2019
Merged

Waku/0 service #1715

merged 7 commits into from Dec 20, 2019

Conversation

@adambabik
Copy link
Member

adambabik commented Dec 3, 2019

Waku/0 service implementing https://github.com/vacp2p/specs/blob/master/waku.md.

Todo

Proposed copyright

// Copyright 2019 The Waku Library Authors.
//
// The Waku library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The Waku library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty off
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the Waku library. If not, see <http://www.gnu.org/licenses/>.
//
// This software uses the go-ethereum library, which is licensed
// under the GNU Lesser General Public Library, version 3 or any later.

Closes #1700

adambabik added 4 commits Nov 26, 2019
@status-github-bot

This comment has been minimized.

Copy link

status-github-bot bot commented Dec 3, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
@status-im-auto

This comment has been minimized.

Copy link
Member

status-im-auto commented Dec 3, 2019

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b2922d8 #1 2019-12-03 07:58:23 ~51 sec linux 📦zip
✔️ b2922d8 #1 2019-12-03 08:04:04 ~6 min ios 📦zip
✔️ b2922d8 #1 2019-12-03 08:04:07 ~6 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 010278e #2 2019-12-18 00:05:17 ~58 sec linux 📦zip
✔️ 010278e #2 2019-12-18 00:09:43 ~5 min ios 📦zip
✔️ 010278e #2 2019-12-18 00:13:01 ~8 min android 📦aar
✔️ daf5227 #3 2019-12-18 21:01:45 ~50 sec linux 📦zip
✔️ daf5227 #3 2019-12-18 21:04:25 ~3 min ios 📦zip
✔️ daf5227 #3 2019-12-18 21:08:24 ~7 min android 📦aar
@oskarth

This comment has been minimized.

Copy link
Member

oskarth commented Dec 3, 2019

decide what to do with confirmations as this is not covered in the spec cc @oskarth

Can you elaborate? If you mean the message codes, we first need them documented in some spec (status and waku or just waku) with their format and behavior etc.

@adambabik

This comment has been minimized.

Copy link
Member Author

adambabik commented Dec 5, 2019

@oskarth yeah, my intention was just to let you know. There is an issue for that vacp2p/specs#30 but it's rather a next step. Here is an issue to describe the current flow status-im/specs#70.

adambabik added 3 commits Dec 17, 2019
F
@adambabik adambabik marked this pull request as ready for review Dec 18, 2019
@adambabik adambabik requested review from pedropombeiro and cammellos Dec 18, 2019
@adambabik adambabik merged commit ea0f12b into develop Dec 20, 2019
8 of 9 checks passed
8 of 9 checks passed
codeclimate 113 issues to fix
Details
packages-check-bot No changes to dependencies
Details
GPG All commits have a verified GPG signature
PRChecklist ready for merge
Details
WIP Ready for review
Details
jenkins/prs/android This commit looks good
Details
jenkins/prs/ios This commit looks good
Details
jenkins/prs/linux This commit looks good
Details
jenkins/prs/tests This commit looks good
Details
@adambabik adambabik deleted the waku-service branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.