chore: remove Celer bridge integration #6938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saledjenic
commented
Sep 18, 2025
saledjenic
commented
- Deleted Celer bridge ABI and Go binding files.
- Removed related configurations and feature flags from wallet and protocol settings.
- Cleaned up wallet service code by eliminating references to Celer bridge processing.
- Updated path processor to remove Celer bridge transaction handling.
Jenkins BuildsClick to see older builds (18)
|
alaibe
approved these changes
Sep 18, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6938 +/- ##
===========================================
+ Coverage 58.79% 59.22% +0.42%
===========================================
Files 823 817 -6
Lines 122261 120785 -1476
===========================================
- Hits 71879 71529 -350
+ Misses 42948 41876 -1072
+ Partials 7434 7380 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
force-pushed
the
chore/remove-celer-bridge
branch
from
4de1cfb to
1f2e16f
Compare
dlipicar
reviewed
Sep 18, 2025
| return t.HopTx.Amount.ToInt() | ||
| } else if t.CbridgeTx != nil { | ||
| return t.CbridgeTx.Amount.ToInt() | ||
| } else if t.SwapTx != nil { |
There was a problem hiding this comment.
this looks weird, was Swap missing from this handler?
There was a problem hiding this comment.
Not at all, it should not be here.
There was a problem hiding this comment.
Most likely somehow remainded when I was splitting commits for PR. Will remove those lines, even MultipathProcessorTxArgs is completely removed in the follow-up PR.
dlipicar
approved these changes
Sep 18, 2025
saledjenic
force-pushed
the
chore/remove-celer-bridge
branch
from
1f2e16f to
b992e20
Compare
- Deleted Celer bridge ABI and Go binding files. - Removed related configurations and feature flags from wallet and protocol settings. - Cleaned up wallet service code by eliminating references to Celer bridge processing. - Updated path processor to remove Celer bridge transaction handling.
- Simplified transaction management by removing multi-transaction ID from `SendTransactionWithSignature` and related methods. - Deprecated endpoints removed `WatchTransactionByChainID`, `ProceedWithTransactionsSignatures` and `GetMultiTransactions`. - Updated transaction handling in various services to streamline the process. - Cleaned up related tests to reflect these changes.
- Updated multiple services and tests to eliminate multi-transaction ID from `SendTransactionWithSignature` and related methods. - Adjusted transaction management logic across the code base. - Cleaned up related tests.
- Eliminated multi-transaction ID from various structures and functions across the wallet service. - Updated related queries and database interactions to reflect the removal of multi-transaction handling. - Cleaned up related tests.
- Eliminated `Send` and `BuildTransaction` methods. - Updated related tests to reflect the removal of these methods. - Codebase cleaned up accordingly.
saledjenic
force-pushed
the
chore/remove-celer-bridge
branch
from
8848c01 to
c5ce72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.