Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to sign transaction in DApp if return with back button from Send transaction/'Sign message' screens #4826

Closed
Serhy opened this Issue Jun 19, 2018 · 0 comments

Comments

3 participants
@Serhy
Copy link
Member

Serhy commented Jun 19, 2018

Type: Bug

Summary: Follow up to #4754. Some Dapps has a pop-ups / modal windows prior to requesting a contact to 'Sign message or Sign Transaction as a confirmation of account. We fail to "notify" the modal window about the cancellation of the transaction when pressing Android device 'Back' button so it is not possible to re-Sign once again in Dapp: e.g. CryptoKitties, Airswap affected

Note: it's all fine using X close top-left button from Sign message/ Sign Transaction screens.

Expected behavior
User can proceed to Sign transaction/Sign message screen

Actual behavior
User can't proceed to Sign transaction/Sign message screen.
CryptoKitties persist to display 'Signing In...' button in 'Create account' pop-up.
Airswap persist to display Connect with Status. Sign to confirm your account screen

Reproduction (with Airswap)

  • Open Status and create an account (re-login under Mainnet if you are not on this network)
  • Navigate to Open Dapp -> Airswap -> Open
  • Start trading -> tap any token (e.g. ADT)
  • Tap 'Sign in using Status`
  • Press Android 'Back' button on the Sign transaction screen

Reproduction (with CryptoKitties)

  • Open Status and create an account (re-login under Mainnet if you are not on this network)
  • Navigate to Open Dapp -> CryptoKitties -> Open
  • Start Meow -> Enter valid email value and tap Continue
  • Check all checkmarks to proceed and tap Sign Up
  • Press Android 'Back' button on the Sign message screen

Additional Information

  • Status version: Develop nightly 19th of June (0.9.20 (6074)
  • Operating System: Android

Logs

TF session for Cryptokitties: https://app.testfairy.com/projects/4803622-status/builds/8497869/sessions/4394296271/?accessToken=jTMHF-2yBK1Qg6bq5RevpCRtDTs

@flexsurfer flexsurfer self-assigned this Jun 20, 2018

@flexsurfer flexsurfer added the new DApp label Jun 20, 2018

@goranjovic goranjovic added this to Backlog/Bugs in Wallet Maintenance Jun 25, 2018

@goranjovic goranjovic moved this from Backlog/Bugs to Next in Wallet Maintenance Jul 4, 2018

@goranjovic goranjovic moved this from Next to Beta X in Wallet Maintenance Jul 5, 2018

@flexsurfer flexsurfer removed their assignment Jul 9, 2018

@goranjovic goranjovic moved this from Next to In progress in Wallet Maintenance Jul 18, 2018

@goranjovic goranjovic self-assigned this Jul 18, 2018

@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Jul 20, 2018

goranjovic added a commit that referenced this issue Jul 23, 2018

bug #4826 - fixed the issue when navigating back from sign message wi…
…th android button

Signed-off-by: Goran Jovic <goranjovic@gmail.com>

Wallet Maintenance automation moved this from Review/Testing to Done Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.