New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a transaction from 1-1 chat with wallet set up Home view is opened instead of the 1-1 chat #5975

Open
yevh-berdnyk opened this Issue Sep 24, 2018 · 7 comments

Comments

4 participants
@yevh-berdnyk
Copy link
Contributor

yevh-berdnyk commented Sep 24, 2018

Description

Type: Bug

Summary: User is navigated to Home view instead of 1-1 chat if sending funds from 1-1 chat and performing wallet set up after clicking Send message button

Expected behavior

User is returned back to the 1-1 chat

Actual behavior

User is landed on the Home view

Reproduction

  • Open Status
  • Recover existing account with funds
  • Start new 1-1 chat
  • Click Send command, select an asset, input valid amount and click Send message button
  • Set up your wallet
  • Sign transaction and click Got it! button

Additional Information

  • Status version: 0.9.29 (8943); node 0.15.0
  • Operating System: OnePlus 5, Android 8.1

@goranjovic goranjovic added this to Shortlist in Wallet Maintenance Oct 1, 2018

@goranjovic goranjovic moved this from Shortlist to Next in Wallet Maintenance Oct 3, 2018

@goranjovic goranjovic moved this from Next to In progress in Wallet Maintenance Oct 3, 2018

@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Oct 3, 2018

@goranjovic goranjovic self-assigned this Oct 3, 2018

@goranjovic goranjovic moved this from Review/Testing to In progress in Wallet Maintenance Oct 3, 2018

goranjovic added a commit that referenced this issue Oct 3, 2018

@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Oct 3, 2018

goranjovic added a commit that referenced this issue Oct 4, 2018

bug #5975 - navigating back to chat after chat initiated transaction
Signed-off-by: Goran Jovic <goranjovic@gmail.com>

Wallet Maintenance automation moved this from Review/Testing to Done Oct 4, 2018

@goranjovic goranjovic reopened this Oct 18, 2018

Wallet Maintenance automation moved this from Done to In progress Oct 18, 2018

@goranjovic

This comment has been minimized.

Copy link
Member

goranjovic commented Oct 18, 2018

The previous fix for this caused another bug - #6283 reopened this one

@antdanchenko

This comment has been minimized.

Copy link
Member

antdanchenko commented Nov 23, 2018

@goranjovic please take a look at this issue, this one is the last issue in develop branch which should be fixed in order to get 100% passed tests for any PR

@goranjovic

This comment has been minimized.

Copy link
Member

goranjovic commented Nov 23, 2018

@antdanchenko on it 👍

@goranjovic goranjovic moved this from Shortlist to In progress in Wallet Maintenance Nov 23, 2018

goranjovic added a commit that referenced this issue Nov 26, 2018

@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Nov 26, 2018

@goranjovic goranjovic moved this from Review/Testing to Shortlist in Wallet Maintenance Dec 10, 2018

@oskarth

This comment has been minimized.

Copy link
Member

oskarth commented Dec 18, 2018

@goranjovic What's the latest state of this?

I saw:

#6878 (comment)

but not quite clear what this means or implies.

We want automated tests to block as soon as possible. IMO we have two options to get there:

  1. Fix this now before end of year (issue high prio)
  2. Remove this test from automated test for now (issue not high prio due to redesign, automated tests cutting scope)

@antdanchenko

@antdanchenko

This comment has been minimized.

Copy link
Member

antdanchenko commented Dec 18, 2018

@oskarth, @goranjovic
I am not a big fan of adding workarounds to an automated tests, or disabling tests which fail due to product issues.
Using the approach might lead to the situation when half of the tests are disabled, we always get 100% passed, but half of the functionality is not tested.

However for this specific case I will add workaround, to make wallet setup before sending a transaction.
Also new test will be added for this specific behavior but will get lower priority which means that the test will run only against nightly builds

@oskarth

This comment has been minimized.

Copy link
Member

oskarth commented Dec 19, 2018

Thanks @antdanchenko. I generally agree with you. Going forward, if there's a product issue that breaks tests it isn't going to get merged right?

Regarding the redesign and how that impacts fixing stuff perhaps @goranjovic has more details.

Also cc @mandrigin fyi

@goranjovic

This comment has been minimized.

Copy link
Member

goranjovic commented Dec 19, 2018

redesign will definitely impact the tests in the sense that all tests covering "Send transaction" will need to be updated to account for new/changed screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment