Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status incl Keycard test findings #8253

Open
hesterbruikman opened this issue May 22, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@hesterbruikman
Copy link

commented May 22, 2019

Status build with Keycard enabled: http://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190520-120558-5b5a7a-pr.apk

Compilation of test findings. Individual issues can be created later if needed.

User Story

  • Setup Keycard
  • Pair existing Keycard with a new device

Steps to test from (#8097)

  1. Set up keycard on device A
    
  2. Add existing account to device B
    
  3. Enter pairing code
    
  4. Start importing account
    
  5. Account imported, you should be able to log in to device B
    
  6. You should be also able to log in to device A
    
@hesterbruikman

This comment has been minimized.

Copy link
Author

commented May 22, 2019

  • Have to scroll to button "Begin Setup" on "This card is blank" screen. Unnecessary. Investigate more efficient use of space > This should be resolved in updated designs
  • When Entering and confirming PIN, last bullet doesn't turn blue before going to next screen
  • Codes require use of SF Mono font to distinguish letters and numbers > Should be resolved by updated designs
  • Required to Enter recovery phrase. This doesn't align with Overview of steps on first screen where step 5 says "Backup recovery phrase. > This should be resolved by the designs for Recover Keycard flow
  • Validation on Input field for mnemonic shows "Recovery phrase is invalid" before 12 words have been entered. #8144
  • Error upon completion of Keycard setup and pairing: Error java.lang.IllegalArgumentException: 16 > 0 #8256
  • When pairing the Keycard to a new build, the validation remains 'stuck' after a first wrong entry. Showing "Invalid pairing code" #8147
  • The UI for the recovery phase on the phone doesn't match the UI on paper (columns to rows vs rows to columns) > New designs resolve this, but they haven't been reviewed and are not ready for implementation
  • Last word on "Check your recovery phrase" should have button Continue instead of Next
  • When paired with the device, Keycard opens and logs into the regular Status build instead of Status PR. Not sure if that's supposed to happen
  • Setup screen is shown for a few seconds before Pairing screen is shown. Do we need a background screen for the time it takes to detect Keycard state?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.