Improve content #5346

chadyj · 2018-07-31T14:07:52Z

Summary:

Improves app copy

Review notes (optional):

This PR only changes copy. The new copy can be seen here https://github.com/status-im/status-react/pull/5346/files

To review please check that the copy looks OK on various screen sizes as some copy length was changed and may mess up formatting.

Steps to test:

Open Status
Tap/browse around.
Refer to https://github.com/status-im/status-react/pull/5346/files to see what strings need checking

status: ready

status-comment-bot · 2018-08-01T11:43:52Z

branch PR-5346:
apk uploaded to https://i.diawi.com/YKEQh5
ipa uploaded to https://i.diawi.com/cU5a72

Install - Diawi - Development and In-house Apps Wireless Installation

chadyj · 2018-08-01T11:55:43Z

src/status_im/translations/en.cljs

   :create-account                       "Create account"
   :already-have-account                 "I already have an account"
-   :creating-your-account                "Creating your account on the blockchain. We can't touch it, no one can, except for you!"
-   :password-placeholder                 "Type your password"
+   :creating-your-account                "Creating your account on the blockchain..."


@obi2020 Weren't you going to update the on the blockchain part as per this comment?

#5088 (comment)

So for example, "Generating your account" might be more accurate?

Ah, mistake. "on the blockchain" was meant to be erased too

chadyj · 2018-08-01T11:56:42Z

src/status_im/translations/en.cljs

   :password-placeholder2                "Confirm your password"
   :name-placeholder                     "Display name"
-   :password_error1                      "Password confirmation doesn't match password."
+   :password_error1                      "Password don't match."


This reads a little funny. Since it is referring to two passwords should it be plural?

Typo, thanks

chadyj · 2018-08-01T11:58:06Z

src/status_im/translations/en.cljs

@@ -178,7 +178,7 @@
   :wallet-set-up-signing-phrase         "This is your personal transaction phrase that you’ll use everytime you make a transaction. Make sure to write it down on a piece of paper, store it somewhere, and only confirm transactions when you see these three words."
   :wallet-set-up-confirm-title          "Wrote it down?"
   :wallet-set-up-confirm-description    "You won’t be able to see your 3-word transaction phrase again after this."
-   :wallet-backup-recovery-title         "Backup your Recovery phrase"
+   :wallet-backup-recovery-title         "Backup your recovery phrase"
   :wallet-backup-recovery-description   "This will help you to keep your money safe"


We don't store money. Should we say assets instead?

Yes, good catch!

status-comment-bot · 2018-08-01T13:09:13Z

branch PR-5346:
apk uploaded to https://i.diawi.com/oJbrD4
ipa uploaded to https://i.diawi.com/qP58Ts

Install - Diawi - Development and In-house Apps Wireless Installation

chadyj

Looks good! Ready for testing :)

status-comment-bot · 2018-08-01T14:23:36Z

branch PR-5346:
apk uploaded to https://i.diawi.com/VMqTrS
ipa uploaded to https://i.diawi.com/zVSz2f

Install - Diawi - Development and In-house Apps Wireless Installation

annadanchenko · 2018-08-02T08:39:39Z

@flexsurfer check of "GPG — All commits must have a verified GPG signature" failed. Can you fix it, please?

flexsurfer · 2018-08-02T08:47:53Z

@obi2020 could you please squash commits, thanks

chadyj · 2018-08-02T08:51:46Z

Hey @flexsurfer we have been doing this in GH's UI. Would you mind squashing/signing if you can?

status-comment-bot · 2018-08-02T09:13:17Z

branch PR-5346:
apk uploaded to https://i.diawi.com/FMn4iz
ipa uploaded to https://i.diawi.com/xWMso5

Install - Diawi - Development and In-house Apps Wireless Installation

statustestbot · 2018-08-02T10:00:45Z

75% of end-end tests have passed

Total executed tests: 51
Failed tests: 13
Passed tests: 38

Failed tests (13)

Click to expand

1. test_request_and_receive_tokens_in_1_1_chat
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
2. test_deploy_contract_from_daap
Tap on GotItButton Looking for full text: 'Mining new contract in tx:' `E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[starts-with(@text,'Mining new contract in tx:')]', during '10' seconds` Device sessions: Device 1
3. test_text_message_1_1_chat
Looking for ShareMyContactKeyButton Tap on ShareMyContactKeyButton `E selenium.common.exceptions.TimeoutException: Message: 'PublicKeyText' is not found on screen, using: 'accessibility id:address-text', during '10' seconds` Device sessions: Device 1 Device 2
4. test_home_view
Wait for PlusButton Looking for an element by text: 'There are no recent Chats or DApps here yet. Tap the “Plus” button to see the list of Dapps or discover people to chat with.' `E Failed: 'Here you can chat with people in a secure private chat, browse and interact with DApps. Use the “Plus” icon to explore Status' text is not shown` Device sessions: Device 1
5. test_request_and_receive_eth_in_1_1_chat
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
6. test_send_tokens_in_1_1_chat
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
7. test_network_mismatch_for_send_request_commands
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
8. test_send_eth_in_1_1_chat
Type '0x049191be3d0b0258732a4c3bd66d2e68cf7e536a0a975fd501a3265cba9ff5f7c78f51345417e42f56e16926b685f99448ac05b9608b0d42cf65ee58853f104696' to PublicKeyEditBox Tap 'Confirm' on native keyboard `E selenium.common.exceptions.TimeoutException: Message: 'ChatMessageInput' is not found on screen, using: 'accessibility id:chat-message-input', during '60' seconds` Device sessions: Device 1 Device 2
9. test_login_with_new_account
Tap on SignInButton Wait for HomeButton `E Failed: TestFairy warning is not shown` Device sessions: Device 1
10. test_backup_recovery_phrase
Wait for ShareMyContactKeyButton Looking for BackupRecoveryPhraseButton `E selenium.common.exceptions.NoSuchElementException: Message: 'BackupRecoveryPhraseButton' is not found on screen, using: 'xpath://*[@text="Backup your Recovery phrase"]'` Device sessions: Device 1
11. test_transaction_confirmed_on_sender_side
Looking for a transaction with unique amount 0.08294 in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca Transaction with unique amount 0.08294 is found in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca `E Failed: Transaction with amount 0.08294 was not confirmed, address is 616874dc6cc2810cdc930dea26496fcf217d58ca` Device sessions: Device 1
12. test_transaction_confirmed_on_recipient_side
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
13. test_recover_account
Tap on CrossIcon Looking for BackupRecoveryPhraseButton `E selenium.common.exceptions.NoSuchElementException: Message: 'BackupRecoveryPhraseButton' is not found on screen, using: 'xpath://*[@text="Backup your Recovery phrase"]'` Device sessions: Device 1

Passed tests (38)

Click to expand

1. test_create_account
Device sessions: Device 1
2. test_filters_from_daap
Device sessions: Device 1
3. test_copy_and_paste_messages
Device sessions: Device 1
4. test_send_transaction_from_daap
Device sessions: Device 1
5. test_delete_cut_and_paste_messages
Device sessions: Device 1
6. test_public_chat_messaging
Device sessions: Device 1 Device 2
7. test_back_forward_buttons_browsing_website
Device sessions: Device 1
8. test_set_profile_picture
Device sessions: Device 1
9. test_add_to_contacts
Device sessions: Device 1 Device 2
10. test_send_and_open_links
Device sessions: Device 1 Device 2
11. test_transaction_message_sending_from_wallet
Device sessions: Device 1 Device 2
12. test_copy_contact_code_and_wallet_address
Device sessions: Device 1
13. test_message_marked_as_sent_and_seen_1_1_chat
Device sessions: Device 1 Device 2
14. test_send_token_with_7_decimals
Device sessions: Device 1
15. test_offline_messaging_1_1_chat
Device sessions: Device 1 Device 2
16. test_token_with_more_than_allowed_decimals
Device sessions: Device 1
17. test_send_eth_from_wallet_to_address
Device sessions: Device 1
18. test_send_transaction_details_in_1_1_chat
Device sessions: Device 1
19. test_request_eth_in_status_test_dapp
Device sessions: Device 1
20. test_manage_assets
Device sessions: Device 1
21. test_wallet_set_up
Device sessions: Device 1
22. test_swipe_to_delete_public_chat
Device sessions: Device 1
23. test_send_emoji
Device sessions: Device 1
24. test_add_contact_by_pasting_public_key
Device sessions: Device 1
25. test_messaging_in_different_networks
Device sessions: Device 1 Device 2
26. test_resend_message_offline
Device sessions: Device 1 Device 2
27. test_swipe_to_delete_1_1_chat
Device sessions: Device 1
28. test_send_stt_from_wallet
Device sessions: Device 1
29. test_send_eth_from_wallet_to_contact
Device sessions: Device 1
30. test_add_contact_from_public_chat
Device sessions: Device 1 Device 2
31. test_send_request_not_enabled_tokens
Device sessions: Device 1
32. test_send_message_to_newly_added_contact
Device sessions: Device 1 Device 2
33. test_offline_status
Device sessions: Device 1
34. test_open_google_com_via_open_dapp
Device sessions: Device 1
35. test_sign_message_from_daap
Device sessions: Device 1
36. test_share_contact_code_and_wallet_address
Device sessions: Device 1
37. test_request_eth_in_wallet
Device sessions: Device 1 Device 2
38. test_refresh_button_browsing_app_webview
Device sessions: Device 1

flexsurfer · 2018-08-02T10:57:52Z

@annadanchenko @chadyj done

status-comment-bot · 2018-08-02T11:19:48Z

branch PR-5346:
apk uploaded to https://i.diawi.com/H6QHcN
ipa uploaded to https://i.diawi.com/LXHAFM

Install - Diawi - Development and In-house Apps Wireless Installation

churik · 2018-08-02T12:11:04Z

@obi2020 @chadyj
Everything looks nice on Google Nexus 5, IPhone 7 screens.
For 1440x2560 pixels (Samsung Galaxy s7) - "Tap the plus (+) button to open a DApp or start a secure chat" doesn't have paddings.

Not crucial, but lets decide can we proceed with it or not. WDYT?

Also there are some visual issues on IPhone 5s screen resolution, but is doesn't depend on content (same issues are presented in current nightly), so I'll create separate issue about it.

chadyj · 2018-08-02T12:20:29Z

Nice find. Thanks @churik
We could add a /nto fix it. @obi2020 mind adding it?

churik · 2018-08-02T13:11:21Z

One more comment: because text is too long, values Amount and Total fee overlapped by keyboard on "Transaction Fee".

status-comment-bot · 2018-08-04T00:04:31Z

branch PR-5346:
apk uploaded to https://i.diawi.com/hU6zGx
ipa uploaded to https://i.diawi.com/RM45gH

status-comment-bot · 2018-08-06T00:37:21Z

branch PR-5346:
apk uploaded to https://i.diawi.com/sEA9GV
ipa uploaded to https://i.diawi.com/SZTFH4

Install - Diawi - Development and In-house Apps Wireless Installation

obi2020 · 2018-08-06T13:28:17Z

Because I don't know the limits for the Transaction fee text, I'm not sure of my copy limits. I've tried an edit, if it does work then I'll remove the add'l info for now and engage the design team on some patterns for tooltips / add'l info in the app

status-comment-bot · 2018-08-06T13:58:38Z

branch PR-5346:
apk uploaded to https://i.diawi.com/crTT5q
ipa uploaded to https://i.diawi.com/h71HD5

Install - Diawi - Development and In-house Apps Wireless Installation

chadyj · 2018-08-06T14:01:26Z

@churik Both issues should be addressed. Mind taking another look?

status-comment-bot · 2018-08-06T16:21:15Z

branch PR-5346:
apk uploaded to https://i.diawi.com/sEjSCA
ipa uploaded to https://i.diawi.com/FB1viV

churik · 2018-08-07T13:05:22Z

Known that text is overlapped on small screens (Transaction Fee, Samsung Galaxy s7, 1440x2560 pixels):

Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

status-comment-bot · 2018-08-07T14:09:18Z

branch PR-5346:
apk uploaded to https://i.diawi.com/5XtESS
ipa uploaded to https://i.diawi.com/teRJXh

Install - Diawi - Development and In-house Apps Wireless Installation

status-comment-bot · 2018-08-07T14:10:03Z

branch PR-5346:
apk uploaded to https://i.diawi.com/yps9RY
ipa uploaded to https://i.diawi.com/cYNiqN

Install - Diawi - Development and In-house Apps Wireless Installation

obi2020 approved these changes Jul 31, 2018

View reviewed changes

flexsurfer approved these changes Aug 1, 2018

View reviewed changes

flexsurfer assigned chadyj Aug 1, 2018

chadyj commented Aug 1, 2018

View reviewed changes

chadyj changed the title ~~[WIP] Improve content~~ Improve content Aug 1, 2018

chadyj removed their assignment Aug 1, 2018

chadyj commented Aug 1, 2018

View reviewed changes

flexsurfer assigned obi2020 Aug 2, 2018

churik self-assigned this Aug 2, 2018

flexsurfer force-pushed the feature/improve-copy-5088-2 branch from fbec925 to b9c174d Compare August 2, 2018 10:57

churik added the Tested - Issues label Aug 2, 2018

churik added Tested - OK and removed Tested - Issues labels Aug 7, 2018

yevh-berdnyk force-pushed the feature/improve-copy-5088-2 branch from bc3d14b to cbbe332 Compare August 7, 2018 13:43

mandrigin force-pushed the feature/improve-copy-5088-2 branch from cbbe332 to 996ad65 Compare August 7, 2018 13:44

Content refresh July 2018

1061fc7

Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

mandrigin force-pushed the feature/improve-copy-5088-2 branch from 996ad65 to 1061fc7 Compare August 7, 2018 13:45

mandrigin merged commit 1061fc7 into develop Aug 7, 2018

mandrigin deleted the feature/improve-copy-5088-2 branch August 7, 2018 13:46

Serhy mentioned this pull request Aug 7, 2018

Uses branch version #5414

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve content #5346

Improve content #5346

chadyj commented Jul 31, 2018 •

edited

Loading

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

chadyj Aug 1, 2018

obi2020 Aug 1, 2018

chadyj Aug 1, 2018

obi2020 Aug 1, 2018

chadyj Aug 1, 2018

obi2020 Aug 1, 2018

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

chadyj left a comment

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

annadanchenko commented Aug 2, 2018

flexsurfer commented Aug 2, 2018

chadyj commented Aug 2, 2018

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot

Loading

statustestbot commented Aug 2, 2018

flexsurfer commented Aug 2, 2018

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot

Loading

churik commented Aug 2, 2018

chadyj commented Aug 2, 2018

churik commented Aug 2, 2018 •

edited

Loading

status-comment-bot commented Aug 4, 2018

status-comment-bot commented Aug 6, 2018 •

edited by status-github-bot bot

Loading

obi2020 commented Aug 6, 2018 •

edited

Loading

status-comment-bot commented Aug 6, 2018 •

edited by status-github-bot bot

Loading

chadyj commented Aug 6, 2018

status-comment-bot commented Aug 6, 2018

churik commented Aug 7, 2018

status-comment-bot commented Aug 7, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 7, 2018 •

edited by status-github-bot bot

Loading

Improve content #5346

Improve content #5346

Conversation

chadyj commented Jul 31, 2018 • edited Loading

Summary:

Review notes (optional):

Steps to test:

status-comment-bot commented Aug 1, 2018 • edited by status-github-bot bot Loading

chadyj Aug 1, 2018

Choose a reason for hiding this comment

obi2020 Aug 1, 2018

Choose a reason for hiding this comment

chadyj Aug 1, 2018

Choose a reason for hiding this comment

obi2020 Aug 1, 2018

Choose a reason for hiding this comment

chadyj Aug 1, 2018

Choose a reason for hiding this comment

obi2020 Aug 1, 2018

Choose a reason for hiding this comment

status-comment-bot commented Aug 1, 2018 • edited by status-github-bot bot Loading

chadyj left a comment

Choose a reason for hiding this comment

status-comment-bot commented Aug 1, 2018 • edited by status-github-bot bot Loading

annadanchenko commented Aug 2, 2018

flexsurfer commented Aug 2, 2018

chadyj commented Aug 2, 2018

status-comment-bot commented Aug 2, 2018 • edited by status-github-bot bot Loading

statustestbot commented Aug 2, 2018

75% of end-end tests have passed

Failed tests (13)

Passed tests (38)

flexsurfer commented Aug 2, 2018

status-comment-bot commented Aug 2, 2018 • edited by status-github-bot bot Loading

churik commented Aug 2, 2018

chadyj commented Aug 2, 2018

churik commented Aug 2, 2018 • edited Loading

status-comment-bot commented Aug 4, 2018

status-comment-bot commented Aug 6, 2018 • edited by status-github-bot bot Loading

obi2020 commented Aug 6, 2018 • edited Loading

status-comment-bot commented Aug 6, 2018 • edited by status-github-bot bot Loading

chadyj commented Aug 6, 2018

status-comment-bot commented Aug 6, 2018

churik commented Aug 7, 2018

status-comment-bot commented Aug 7, 2018 • edited by status-github-bot bot Loading

status-comment-bot commented Aug 7, 2018 • edited by status-github-bot bot Loading

chadyj commented Jul 31, 2018 •

edited

Loading

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot

Loading

churik commented Aug 2, 2018 •

edited

Loading

status-comment-bot commented Aug 6, 2018 •

edited by status-github-bot bot

Loading

obi2020 commented Aug 6, 2018 •

edited

Loading

status-comment-bot commented Aug 6, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 7, 2018 •

edited by status-github-bot bot

Loading

status-comment-bot commented Aug 7, 2018 •

edited by status-github-bot bot

Loading