Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose whisper (shh) events #7076 #7284

Merged
merged 1 commit into from Feb 13, 2019
Merged

Conversation

shamardy
Copy link
Contributor

Closes #7076

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jan 16, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jan 16, 2019

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
70663e8 #1 2019-01-16 05:43:39 ~21 sec android-e2e 📄 build log
70663e8 #1 2019-01-16 05:43:40 ~19 sec android 📄 build log
70663e8 #1 2019-01-16 05:43:41 ~19 sec ios-e2e 📄 build log
70663e8 #1 2019-01-16 05:43:41 ~18 sec ios 📄 build log
70663e8 #1 2019-01-16 05:43:45 ~19 sec macos 📄 build log
70663e8 #1 2019-01-16 05:43:47 ~23 sec linux 📄 build log
70663e8 #1 2019-01-16 05:43:50 ~22 sec windows 📄 build log
ccf69fe #2 2019-01-16 05:49:10 ~15 sec android-e2e 📄 build log
ccf69fe #2 2019-01-16 05:49:10 ~14 sec android 📄 build log
ccf69fe #2 2019-01-16 05:49:13 ~13 sec ios 📄 build log
ccf69fe #2 2019-01-16 05:49:16 ~18 sec ios-e2e 📄 build log
ccf69fe #2 2019-01-16 05:49:19 ~17 sec macos 📄 build log
ccf69fe #2 2019-01-16 05:49:23 ~22 sec linux 📄 build log
ccf69fe #2 2019-01-16 05:49:29 ~25 sec windows 📄 build log

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
70663e8 #1 2019-01-16 05:43:39 ~21 sec android-e2e 📄 build log
70663e8 #1 2019-01-16 05:43:40 ~19 sec android 📄 build log

@jeluard
Copy link
Contributor

jeluard commented Jan 21, 2019

@shamardy Great start! Are you planning to implement the others whisper functions?

@shamardy
Copy link
Contributor Author

@jeluard Yes, I plan to implement the other functions. Sorry for the delay.

@status-im-auto
Copy link
Member

status-im-auto commented Jan 24, 2019

Jenkins Builds

Click to see older builds (49)
Commit #️⃣ Finished (UTC) Duration Platform Result
f4c6172 #3 2019-01-24 01:06:25 ~22 sec android-e2e 📄 log
f4c6172 #3 2019-01-24 01:06:25 ~20 sec android 📄 log
f4c6172 #3 2019-01-24 01:06:25 ~17 sec ios-e2e 📄 log
f4c6172 #3 2019-01-24 01:06:28 ~14 sec macos 📄 log
f4c6172 #3 2019-01-24 01:06:28 ~18 sec ios 📄 log
f4c6172 #3 2019-01-24 01:06:38 ~26 sec linux 📄 log
f4c6172 #3 2019-01-24 01:06:38 ~22 sec windows 📄 log
6caa708 #4 2019-01-24 05:52:25 ~16 sec android-e2e 📄 log
6caa708 #4 2019-01-24 05:52:27 ~13 sec ios 📄 log
6caa708 #4 2019-01-24 05:52:28 ~17 sec android 📄 log
6caa708 #4 2019-01-24 05:52:31 ~14 sec macos 📄 log
6caa708 #4 2019-01-24 05:52:31 ~18 sec ios-e2e 📄 log
6caa708 #4 2019-01-24 05:52:39 ~23 sec linux 📄 log
6caa708 #4 2019-01-24 05:53:04 ~46 sec windows 📄 log
f5515cc #5 2019-01-26 03:53:52 ~20 sec android 📄 log
f5515cc #5 2019-01-26 03:53:52 ~22 sec android-e2e 📄 log
f5515cc #5 2019-01-26 03:53:53 ~18 sec ios 📄 log
f5515cc #5 2019-01-26 03:53:53 ~19 sec ios-e2e 📄 log
f5515cc #5 2019-01-26 03:53:57 ~18 sec macos 📄 log
f5515cc #5 2019-01-26 03:54:00 ~20 sec windows 📄 log
f5515cc #5 2019-01-26 03:54:00 ~24 sec linux 📄 log
8f5041b #6 2019-01-26 04:04:00 ~1 min ios 📄 log
8f5041b #6 2019-01-26 04:04:22 ~1 min macos 📄 log
8f5041b #6 2019-01-26 04:05:15 ~2 min ios-e2e 📄 log
8f5041b #6 2019-01-26 04:07:03 ~4 min linux 📄 log
8f5041b #6 2019-01-26 04:07:06 ~4 min windows 📄 log
8f5041b #6 2019-01-26 04:07:42 ~4 min android-e2e 📄 log
8f5041b #6 2019-01-26 04:07:42 ~4 min android 📄 log
fa04607 #8 2019-01-26 04:21:44 ~1 min ios-e2e 📄 log
fa04607 #8 2019-01-26 04:21:45 ~1 min macos 📄 log
fa04607 #8 2019-01-26 04:21:55 ~1 min ios 📄 log
fa04607 #8 2019-01-26 04:23:27 ~3 min linux 📄 log
fa04607 #8 2019-01-26 04:23:27 ~3 min android-e2e 📄 log
fa04607 #8 2019-01-26 04:23:36 ~3 min windows 📄 log
fa04607 #8 2019-01-26 04:23:46 ~3 min android 📄 log
✔️ b75770f #9 2019-01-26 04:39:25 ~14 min ios 📦 ipa
✔️ b75770f #9 2019-01-26 04:39:48 ~15 min ios-e2e 📦 pkg
✔️ b75770f #9 2019-01-26 04:39:58 ~15 min android 📦 apk
✔️ b75770f #9 2019-01-26 04:40:01 ~15 min android-e2e 📦 apk
✔️ b75770f #9 2019-01-26 04:40:51 ~16 min macos 📦 dmg
✔️ b75770f #9 2019-01-26 04:42:26 ~17 min windows 📦 exe
✔️ b75770f #9 2019-01-26 04:45:04 ~20 min linux 📦 App
666bfbe #10 2019-02-05 21:17:06 ~3 min macos 📄 log
666bfbe #10 2019-02-05 21:19:15 ~6 min linux 📄 log
666bfbe #10 2019-02-05 21:19:30 ~6 min windows 📄 log
✔️ 666bfbe #10 2019-02-05 21:28:13 ~15 min ios-e2e 📦 pkg
✔️ 666bfbe #10 2019-02-05 21:29:01 ~15 min ios 📦 ipa
✔️ 666bfbe #10 2019-02-05 21:30:48 ~17 min android-e2e 📦 apk
✔️ 666bfbe #10 2019-02-05 21:32:21 ~19 min android 📦 apk
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7433e80 #11 2019-02-06 12:52:41 ~15 min ios 📦 ipa
✔️ 7433e80 #11 2019-02-06 12:53:20 ~15 min macos 📦 dmg
✔️ 7433e80 #11 2019-02-06 12:53:27 ~16 min android-e2e 📦 apk
✔️ 7433e80 #11 2019-02-06 12:53:42 ~16 min ios-e2e 📦 pkg
✔️ 7433e80 #11 2019-02-06 12:54:39 ~17 min android 📦 apk
✔️ 7433e80 #11 2019-02-06 12:58:09 ~20 min linux 📦 App
✔️ 7433e80 #11 2019-02-06 13:00:53 ~23 min windows 📦 exe
✔️ 7433e80 #12 2019-02-12 14:25:06 ~16 min ios 📦 ipa
✔️ 7433e80 #12 2019-02-12 14:25:21 ~16 min macos 📦 dmg
✔️ 7433e80 #12 2019-02-12 14:25:23 ~16 min ios-e2e 📦 pkg
✔️ 7433e80 #12 2019-02-12 14:26:02 ~18 min android 📦 apk
✔️ 7433e80 #12 2019-02-12 14:26:24 ~18 min android-e2e 📦 apk
✔️ 7433e80 #12 2019-02-12 14:31:18 ~22 min linux 📦 App
✔️ 7433e80 #12 2019-02-12 14:46:13 ~36 min windows 📦 exe
✔️ 41e00ed #13 2019-02-12 23:51:13 ~14 min macos 📦 dmg
✔️ 41e00ed #13 2019-02-12 23:53:59 ~16 min ios 📦 ipa
✔️ 41e00ed #13 2019-02-12 23:54:04 ~17 min ios-e2e 📦 pkg
✔️ 41e00ed #13 2019-02-12 23:57:51 ~20 min linux 📦 App
✔️ 41e00ed #13 2019-02-13 00:00:01 ~23 min android 📦 apk
✔️ 41e00ed #13 2019-02-13 00:00:18 ~23 min android-e2e 📦 apk
✔️ 41e00ed #13 2019-02-13 00:02:06 ~25 min windows 📦 exe

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
f4c6172 #3 2019-01-24 01:06:25 ~22 sec android-e2e 📄 build log
f4c6172 #3 2019-01-24 01:06:25 ~20 sec android 📄 build log

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
f4c6172 #3 2019-01-24 01:06:25 ~22 sec android-e2e 📄 build log
f4c6172 #3 2019-01-24 01:06:25 ~20 sec android 📄 build log
f4c6172 #3 2019-01-24 01:06:25 ~17 sec ios-e2e 📄 build log

@shamardy shamardy changed the title [WIP] Expose whisper (shh) events #7076 Expose whisper (shh) events #7076 Jan 26, 2019
@jeluard
Copy link
Contributor

jeluard commented Jan 28, 2019

@shamardy Let me know when you feel like this PR is ready :)

@shamardy
Copy link
Contributor Author

@jeluard Yes, this is ready for review.

@jeluard jeluard requested review from jeluard, yenda, flexsurfer and goranjovic and removed request for jeluard January 29, 2019 14:53
@jeluard
Copy link
Contributor

jeluard commented Feb 5, 2019

@shamardy Could you squash your commits?

@jeluard
Copy link
Contributor

jeluard commented Feb 6, 2019

@shamardy Actually you will also have to rebase with latest master due to some internal issue. Sorry for the inconvenience.

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 58
Failed tests: 1
Passed tests: 57

Failed tests (1)

Click to expand
1. test_send_transaction_details_in_1_1_chat

Device 1: Looking for an element by text: 'ETHro'
Device 1: Looking for an element by text: '0.021110477'

Recipient address is not shown

Device sessions

Passed tests (57)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_manage_assets
Device sessions

25. test_wallet_set_up
Device sessions

26. test_logcat_send_transaction_in_1_1_chat
Device sessions

27. test_request_and_receive_eth_in_1_1_chat
Device sessions

28. test_swipe_to_delete_public_chat
Device sessions

29. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

30. test_send_emoji
Device sessions

31. test_add_contact_by_pasting_public_key
Device sessions

32. test_logcat_recovering_account
Device sessions

33. test_messaging_in_different_networks
Device sessions

34. test_send_tokens_in_1_1_chat
Device sessions

35. test_network_mismatch_for_send_request_commands
Device sessions

36. test_logcat_sign_message_from_daap
Device sessions

37. test_swipe_to_delete_1_1_chat
Device sessions

38. test_switch_users_and_add_new_account
Device sessions

39. test_send_stt_from_wallet
Device sessions

40. test_send_eth_in_1_1_chat
Device sessions

41. test_login_with_new_account
Device sessions

42. test_send_eth_from_wallet_to_contact
Device sessions

43. test_add_contact_from_public_chat
Device sessions

44. test_send_request_not_enabled_tokens
Device sessions

45. test_send_message_to_newly_added_contact
Device sessions

46. test_password_in_logcat_creating_account
Device sessions

47. test_backup_recovery_phrase
Device sessions

48. test_offline_status
Device sessions

49. test_open_google_com_via_open_dapp
Device sessions

50. test_unread_messages_counter_public_chat
Device sessions

51. test_sign_message_from_daap
Device sessions

52. test_user_can_remove_profile_picture
Device sessions

53. test_share_contact_code_and_wallet_address
Device sessions

54. test_request_eth_in_wallet
Device sessions

55. test_refresh_button_browsing_app_webview
Device sessions

56. test_backup_recovery_phrase_warning_from_wallet
Device sessions

57. test_recover_account
Device sessions

@statustestbot
Copy link

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Passed tests: 0

Failed tests (1)

Click to expand
1. test_send_transaction_details_in_1_1_chat

Device 1: Looking for an element by text: 'ETHro'
Device 1: Looking for an element by text: '0.021111115'

Recipient address is not shown

Device sessions

@antdanchenko
Copy link
Contributor

@shamardy please ignore my deleted comment

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_send_transaction_details_in_1_1_chat
Device sessions

@asemiankevich asemiankevich moved this from TO TEST to IN TESTING in Pipeline for QA Feb 12, 2019
@asemiankevich asemiankevich self-assigned this Feb 12, 2019
@asemiankevich
Copy link
Contributor

@jeluard based on the description Not exactly clear what we want to do here so part of the issue is to come up with a coherent proposal. which testing is expected here?

@jeluard
Copy link
Contributor

jeluard commented Feb 12, 2019

@asemiankevich Just sanity checks. Make sure there is no weird regression? :)

@asemiankevich
Copy link
Contributor

@asemiankevich Just sanity checks. Make sure there is no weird regression? :)

e2e are passed, asking if we need to test more here

@jeluard
Copy link
Contributor

jeluard commented Feb 12, 2019

@asemiankevich no new features

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@asemiankevich asemiankevich moved this from IN TESTING to MERGE in Pipeline for QA Feb 12, 2019
@jeluard
Copy link
Contributor

jeluard commented Feb 12, 2019

@shamardy Could you edit the commit message? It's a bit long :)

Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
@jeluard jeluard merged commit 9198b15 into status-im:develop Feb 13, 2019
Pipeline for QA automation moved this from MERGE to DONE Feb 13, 2019
@shamardy shamardy deleted the Issue#7076 branch February 21, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants