New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose whisper (shh) events #7076 #7284
Conversation
Pull Request Checklist
|
Jenkins Builds
|
Jenkins Builds
|
@shamardy Great start! Are you planning to implement the others whisper functions? |
@jeluard Yes, I plan to implement the other functions. Sorry for the delay. |
Jenkins BuildsClick to see older builds (49)
|
Jenkins Builds
|
Jenkins Builds
|
@shamardy Let me know when you feel like this PR is ready :) |
@jeluard Yes, this is ready for review. |
@shamardy Could you squash your commits? |
@shamardy Actually you will also have to rebase with latest master due to some internal issue. Sorry for the inconvenience. |
98% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (57)Click to expand |
0% of end-end tests have passed
Failed tests (1)Click to expand
|
@shamardy please ignore my deleted comment |
100% of end-end tests have passed
Passed tests (1) |
@jeluard based on the description |
@asemiankevich Just sanity checks. Make sure there is no weird regression? :) |
e2e are passed, asking if we need to test more here |
@asemiankevich no new features |
@shamardy Could you edit the commit message? It's a bit long :) |
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
Closes #7076