Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7455] Added WBTC token #7485

Merged
merged 1 commit into from Feb 20, 2019

Conversation

@trowacat
Copy link
Contributor

commented Feb 13, 2019

fixes #7455

Added icons and listing for WBTC token

@status-github-bot

This comment has been minimized.

Copy link

commented Feb 13, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 13, 2019
@trowacat trowacat force-pushed the trowacat:develop branch 2 times, most recently from 4dda5a9 to bb5ef4d Feb 13, 2019
@status-im-auto

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c014479 #1 2019-02-13 02:15:07 ~14 min macos 📦 dmg
✔️ bb5ef4d #3 2019-02-13 02:27:05 ~14 min android 📦 apk
✔️ bb5ef4d #3 2019-02-13 02:28:09 ~15 min android-e2e 📦 apk
✔️ bb5ef4d #3 2019-02-13 02:30:47 ~18 min macos 📦 dmg
✔️ bb5ef4d #3 2019-02-13 02:31:03 ~18 min ios 📦 ipa
✔️ bb5ef4d #3 2019-02-13 02:31:09 ~18 min ios-e2e 📦 pkg
✔️ bb5ef4d #3 2019-02-13 02:34:33 ~21 min windows 📦 exe
✔️ bb5ef4d #3 2019-02-13 02:36:05 ~23 min linux 📦 App
Commit #️⃣ Finished (UTC) Duration Platform Result
e3af26c #5 2019-02-15 14:26:11 ~1 min ios-e2e 📄 log
e3af26c #5 2019-02-15 14:26:16 ~1 min ios 📄 log
✔️ e3af26c #5 2019-02-15 14:39:23 ~14 min macos 📦 dmg
✔️ e3af26c #5 2019-02-15 14:41:57 ~17 min android 📦 apk
✔️ e3af26c #5 2019-02-15 14:42:12 ~17 min android-e2e 📦 apk
✔️ e3af26c #5 2019-02-15 14:43:33 ~18 min windows 📦 exe
✔️ e3af26c #5 2019-02-15 14:44:31 ~19 min linux 📦 App
✔️ e3af26c #6 2019-02-15 15:07:13 ~15 min ios 📦 ipa
✔️ e3af26c #6 2019-02-15 15:40:23 ~16 min ios-e2e 📦 pkg
✔️ 0fe4ac5 #6 2019-02-20 11:52:57 ~17 min android-e2e 📦 apk
@jeluard jeluard requested review from goranjovic, jeluard and flexsurfer Feb 13, 2019
@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Feb 14, 2019
@statustestbot

This comment has been minimized.

Copy link

commented Feb 14, 2019

2% of end-end tests have passed

Total executed tests: 58
Failed tests: 57
Passed tests: 1

Failed tests (57)

Click to expand
1. test_create_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

2. test_user_can_switch_network

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

3. test_filters_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

4. test_copy_and_paste_messages

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

5. test_send_transaction_from_daap

Device 1: Scrolling down to AdvancedButton
Device 1: Scrolling down to AdvancedButton

'NoneType' object has no attribute 'click'

Device sessions

6. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

7. test_delete_cut_and_paste_messages

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

8. test_deploy_contract_from_daap

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

9. test_offline_login

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

10. test_pass_phrase_validation

Device 1: Tap on ConfirmPhraseButton
Device 1: Wait for ProfileButton

Something went wrong. Probably, could not reach the home screen out.

Device sessions

11. test_public_chat_messaging

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

12. test_password_in_logcat_sign_in

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

13. test_set_profile_picture

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

14. test_text_message_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

15. test_add_to_contacts

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

16. test_unread_messages_counter_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

17. test_logcat_send_transaction_from_daap

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

19. test_logcat_send_transaction_from_wallet

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

20. test_send_token_with_7_decimals

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

21. test_modify_transaction_fee_values

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

22. test_token_with_more_than_allowed_decimals

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

23. test_send_eth_from_wallet_to_address

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

24. test_send_transaction_details_in_1_1_chat

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

25. test_manage_assets

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

26. test_wallet_set_up

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

27. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

28. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

29. test_swipe_to_delete_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access

Device 1: Wait for HomeButton
Device 1: Wait for ProfileButton

Device 1: Something went wrong. Probably, could not reach the home screen out.

Device sessions

31. test_send_emoji

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

32. test_add_contact_by_pasting_public_key

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

33. test_messaging_in_different_networks

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

34. test_send_tokens_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

35. test_network_mismatch_for_send_request_commands

Device 2: Tap on NextButton
Device 2: Looking for an element by text part: 'Display name'

Device 2: 'BaseButton' is not found on the screen

Device sessions

36. test_logcat_sign_message_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

37. test_swipe_to_delete_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

38. test_switch_users_and_add_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

39. test_send_stt_from_wallet

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

40. test_send_eth_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

41. test_login_with_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

42. test_send_eth_from_wallet_to_contact

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

43. test_add_contact_from_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

44. test_send_request_not_enabled_tokens

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

45. test_send_message_to_newly_added_contact

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

46. test_password_in_logcat_creating_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

47. test_backup_recovery_phrase

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

48. test_offline_status

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

49. test_open_google_com_via_open_dapp

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

50. test_unread_messages_counter_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

51. test_sign_message_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

52. test_user_can_remove_profile_picture

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

53. test_share_contact_code_and_wallet_address

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

54. test_request_eth_in_wallet

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

55. test_refresh_button_browsing_app_webview

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

56. test_backup_recovery_phrase_warning_from_wallet

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

57. test_recover_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

Passed tests (1)

Click to expand
1. test_logcat_recovering_account
Device sessions

@Serhy

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

@trowacat could you rebase develop, please?

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@trowacat @jeluard any idea how i can faucet this token ?

@jeluard

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@asemiankevich On mainnet? I don't think you can get that. It's a wrapper for bitcoin

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@asemiankevich On mainnet? I don't think you can get that. It's a wrapper for bitcoin

Ropsten would be fine too.
I want to check sending/receiving this token

@jeluard

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

This token has not been added on ropsten apparently

@guylouis

This comment has been minimized.

Copy link

commented Feb 15, 2019

@asemiankevich if still needed I can get a couple $ of wbtc on mainnet and send them to you for tests. If yes, let me know where to send them.

@trowacat trowacat force-pushed the trowacat:develop branch from 991211e to e3af26c Feb 15, 2019
@trowacat

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@Serhy @jeluard Any reason jenkins build failing after rebase?

@jeluard

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@trowacat It's good now

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

@asemiankevich if still needed I can get a couple $ of wbtc on mainnet and send them to you for tests. If yes, let me know where to send them.

@guylouis 0x58d8c3D70ce4FA4b9fb10a665C8712238746F2ff

@asemiankevich asemiankevich self-assigned this Feb 18, 2019
@asemiankevich asemiankevich moved this from TO TEST to IN TESTING in Pipeline for QA Feb 18, 2019
@statustestbot

This comment has been minimized.

Copy link

commented Feb 18, 2019

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

image

will test sending / receiving tokens once i get them

@asemiankevich asemiankevich moved this from IN TESTING to MERGE in Pipeline for QA Feb 18, 2019
@guylouis

This comment has been minimized.

Copy link

commented Feb 18, 2019

@asemiankevich
Just sent a couple WBTC tokens to the adress you specified

Signed-off-by: yenda <eric@status.im>
@yenda yenda force-pushed the trowacat:develop branch from e3af26c to 0fe4ac5 Feb 20, 2019
@yenda yenda merged commit 0fe4ac5 into status-im:develop Feb 20, 2019
10 checks passed
10 checks passed
GPG All commits have a verified GPG signature
WIP Ready for review
Details
security/snyk - Gemfile.lock (Status-im) No manifest changes detected
security/snyk - android/app/build.gradle (Status-im) No manifest changes detected
security/snyk - android/build.gradle (Status-im) No manifest changes detected
security/snyk - modules/react-native-desktop-linking/package.json (Status-im) No manifest changes detected
security/snyk - modules/react-native-desktop-notification/package.json (Status-im) No manifest changes detected
security/snyk - modules/react-native-status/package.json (Status-im) No manifest changes detected
security/snyk - test/appium/requirements.txt (Status-im) No manifest changes detected
security/snyk - test/desktop_sikuli/requirements.txt (Status-im) No manifest changes detected
Pipeline for QA automation moved this from MERGE to DONE Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
10 participants
You can’t perform that action at this time.