Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Mobile UI for desktop #7551
Mobile UI used for desktop platform
Review notes (optional):
Most issues solved on
Testing notes (optional):
I believe mobile builds should be tested especially careful because problems in desktop can be solved in a separate issues, but we don't want any regressions on mobile.
Areas that maybe impacted (optional)
Steps to test:
Click to see older builds (199)
I agree with what @mandrigin said above. The sooner we can get this into the code base under a flag the better. If adequate testing has been done on this PR I think that's fine.
For dependencies to actually enable it, my understanding is that this mostly about FlatList performance. If there are other issues, can we please capture these in some umbrella issue? Perhaps there is one already?
@vkjr still testing, so far tested on Linux Ubuntu 18.04, Windows 10 Home, Mac OSx:
What I noticed that clicks on user icons in public chats are still not working as expected, so sometimes it does nothing.
Continue with testing on mobile...
67% of end-end tests have passed
Failed tests (1)
Click to expand
Passed tests (2)
Tested on desktop builds: #7551 (comment)
No regression introduced by this PR is found. All failures mentioned in the test suite are failures in nightly as well.