Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile UI for desktop #7551

Merged
merged 1 commit into from May 3, 2019

Conversation

@vkjr
Copy link
Member

commented Feb 22, 2019

fixes #7399

Summary:

Mobile UI used for desktop platform

Review notes (optional):

Most issues solved on react-native-desktop side and with the help of (if desktop?...).
But there is one area that needs special attention during review:
On mobile basic-text-input component saves entered text in re-frame database. Whenever input changes, component recreates. That doesn't cause issues because typing speed on mobile is much slower.
But on desktop typing speed significantly faster and re-rendering causes characters loss. So I had to create component basic-text-input-desktop and save input text inside component state instead of re-frame database. Drawback of that decision - typed text doesn't save when I close chat and reopen it again.
Would appreciate your help in solving this.

Testing notes (optional):

I believe mobile builds should be tested especially careful because problems in desktop can be solved in a separate issues, but we don't want any regressions on mobile.

Platforms (optional)

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted (optional)

Functional

  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes

Non-functional

  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test:

  • Open Status
  • check everything..

status: ready

@vkjr vkjr added the desktop-old label Feb 22, 2019

@vkjr vkjr self-assigned this Feb 22, 2019

@status-github-bot

This comment has been minimized.

Copy link

commented Feb 22, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 22, 2019

@status-im-auto

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Jenkins Builds

Click to see older builds (199)
Commit #️⃣ Finished (UTC) Duration Platform Result
1d855c9 #1 2019-02-22 10:55:22 ~20 sec android-e2e 📄 log
1d855c9 #1 2019-02-22 10:55:22 ~16 sec linux 📄 log
1d855c9 #1 2019-02-22 10:55:23 ~19 sec android 📄 log
1d855c9 #1 2019-02-22 10:55:24 ~16 sec windows 📄 log
1d855c9 #1 2019-02-22 10:55:30 ~26 sec ios-e2e 📄 log
1d855c9 #1 2019-02-22 10:55:30 ~25 sec ios 📄 log
1d855c9 #1 2019-02-22 10:55:32 ~25 sec macos 📄 log
5f83dc6 #2 2019-02-25 15:56:11 ~16 sec linux 📄 log
5f83dc6 #2 2019-02-25 15:56:11 ~14 sec windows 📄 log
5f83dc6 #2 2019-02-25 15:56:13 ~22 sec android 📄 log
5f83dc6 #2 2019-02-25 15:56:13 ~23 sec android-e2e 📄 log
5f83dc6 #2 2019-02-25 15:56:14 ~19 sec macos 📄 log
5f83dc6 #2 2019-02-25 15:56:20 ~28 sec ios-e2e 📄 log
5f83dc6 #2 2019-02-25 15:56:21 ~28 sec ios 📄 log
19bbe35 #3 2019-02-28 12:56:08 ~16 sec android 📄 log
19bbe35 #3 2019-02-28 12:56:08 ~13 sec linux 📄 log
19bbe35 #3 2019-02-28 12:56:10 ~16 sec ios 📄 log
19bbe35 #3 2019-02-28 12:56:10 ~17 sec ios-e2e 📄 log
19bbe35 #3 2019-02-28 12:56:12 ~21 sec android-e2e 📄 log
19bbe35 #3 2019-02-28 12:56:13 ~17 sec windows 📄 log
19bbe35 #3 2019-02-28 12:56:20 ~25 sec macos 📄 log
8f2757c #4 2019-03-01 13:33:11 ~17 sec android 📄 log
8f2757c #4 2019-03-01 13:33:12 ~18 sec android-e2e 📄 log
8f2757c #4 2019-03-01 13:33:12 ~16 sec linux 📄 log
8f2757c #4 2019-03-01 13:33:15 ~19 sec ios 📄 log
8f2757c #4 2019-03-01 13:33:16 ~17 sec windows 📄 log
8f2757c #4 2019-03-01 13:33:18 ~20 sec macos 📄 log
3ace400 #5 2019-03-11 09:16:29 ~19 sec ios 📄 log
3ace400 #5 2019-03-11 09:16:30 ~19 sec macos 📄 log
3ace400 #5 2019-03-11 09:17:32 ~1 min linux 📄 log
3ace400 #5 2019-03-11 09:17:38 ~1 min windows 📄 log
3ace400 #5 2019-03-11 09:18:12 ~2 min android-e2e 📄 log
3ace400 #5 2019-03-11 09:18:13 ~2 min android 📄 log
04c82d3 #6 2019-03-11 10:17:28 ~16 sec android-e2e 📄 log
04c82d3 #6 2019-03-11 10:17:28 ~15 sec android 📄 log
04c82d3 #6 2019-03-11 10:17:31 ~17 sec ios 📄 log
04c82d3 #6 2019-03-11 10:17:32 ~16 sec macos 📄 log
04c82d3 #6 2019-03-11 10:17:49 ~32 sec windows 📄 log
04c82d3 #6 2019-03-11 10:17:51 ~35 sec linux 📄 log
2f51a7c #7 2019-03-11 10:22:48 ~1 min android-e2e 📄 log
2f51a7c #7 2019-03-11 10:22:55 ~1 min android 📄 log
2f51a7c #7 2019-03-11 10:23:18 ~1 min windows 📄 log
2f51a7c #7 2019-03-11 10:23:18 ~1 min linux 📄 log
2f51a7c #7 2019-03-11 10:27:12 ~5 min ios 📄 log
2f51a7c #7 2019-03-11 10:27:18 ~5 min macos 📄 log
9613755 #8 2019-03-11 11:12:49 ~14 sec android-e2e 📄 log
9613755 #8 2019-03-11 11:12:50 ~13 sec android 📄 log
9613755 #8 2019-03-11 11:12:51 ~13 sec linux 📄 log
9613755 #8 2019-03-11 11:12:54 ~15 sec macos 📄 log
9613755 #8 2019-03-11 11:12:54 ~16 sec ios 📄 log
9613755 #8 2019-03-11 11:12:59 ~18 sec windows 📄 log
0b36e96 #9 2019-03-12 10:52:37 ~19 sec android-e2e 📄 log
0b36e96 #9 2019-03-12 10:52:40 ~19 sec ios 📄 log
0b36e96 #9 2019-03-12 10:52:41 ~21 sec android 📄 log
0b36e96 #9 2019-03-12 10:52:54 ~32 sec linux 📄 log
0b36e96 #9 2019-03-12 10:52:57 ~34 sec macos 📄 log
0b36e96 #9 2019-03-12 10:52:58 ~34 sec windows 📄 log
39213aa #10 2019-03-14 08:11:15 ~15 sec linux 📄 log
39213aa #10 2019-03-14 08:11:18 ~21 sec android-e2e 📄 log
39213aa #10 2019-03-14 08:11:18 ~20 sec android 📄 log
39213aa #10 2019-03-14 08:11:19 ~19 sec macos 📄 log
39213aa #10 2019-03-14 08:11:20 ~22 sec ios 📄 log
39213aa #10 2019-03-14 08:11:40 ~39 sec windows 📄 log
dff65b2 #11 2019-03-16 13:08:47 ~26 sec windows 📄 log
dff65b2 #11 2019-03-16 20:08:48 ~24 sec android 📄 log
dff65b2 #11 2019-03-16 22:16:52 ~25 sec android-e2e 📄 log
dff65b2 #11 2019-03-16 23:04:47 ~25 sec linux 📄 log
dff65b2 #11 2019-03-17 00:32:48 ~25 sec ios 📄 log
dff65b2 #11 2019-03-17 10:28:51 ~28 sec macos 📄 log
720fee8 #12 2019-03-18 10:48:57 ~23 sec android-e2e 📄 log
720fee8 #12 2019-03-18 10:48:57 ~22 sec android 📄 log
720fee8 #12 2019-03-18 10:49:01 ~25 sec ios 📄 log
720fee8 #12 2019-03-18 10:49:02 ~24 sec windows 📄 log
720fee8 #12 2019-03-18 10:49:03 ~26 sec linux 📄 log
720fee8 #12 2019-03-18 10:49:05 ~28 sec macos 📄 log
69f4992 #13 2019-03-18 10:53:49 ~21 sec android 📄 log
69f4992 #13 2019-03-18 10:53:49 ~23 sec android-e2e 📄 log
69f4992 #13 2019-03-18 10:53:53 ~24 sec ios 📄 log
69f4992 #13 2019-03-18 10:53:54 ~22 sec windows 📄 log
69f4992 #13 2019-03-18 10:53:55 ~25 sec linux 📄 log
69f4992 #13 2019-03-18 10:53:57 ~26 sec macos 📄 log
✔️ e2600f4 #14 2019-03-18 11:39:55 ~16 min android 📦 apk
✔️ e2600f4 #14 2019-03-18 11:40:42 ~17 min ios 📦 ipa
✔️ e2600f4 #14 2019-03-18 11:42:30 ~19 min macos 📦 dmg
✔️ e2600f4 #14 2019-03-18 11:46:52 ~23 min linux 📦 App
✔️ e2600f4 #14 2019-03-18 11:48:26 ~25 min android-e2e 📦 apk
✔️ e2600f4 #14 2019-03-18 11:52:24 ~29 min windows 📦 exe
077d2c7 #15 2019-04-01 14:08:21 ~36 sec ios 📄 log
077d2c7 #15 2019-04-01 14:08:22 ~35 sec macos 📄 log
077d2c7 #15 2019-04-01 14:09:06 ~1 min windows 📄 log
077d2c7 #16 2019-04-01 14:09:09 ~1 min linux 📄 log
077d2c7 #15 2019-04-01 14:09:41 ~1 min android-e2e 📄 log
077d2c7 #15 2019-04-01 14:09:41 ~1 min android 📄 log
57b27c4 #16 2019-04-08 10:52:02 ~27 sec ios 📄 log
57b27c4 #16 2019-04-08 10:52:03 ~26 sec macos 📄 log
57b27c4 #16 2019-04-08 11:01:15 ~9 min windows 📄 log
57b27c4 #16 2019-04-08 11:02:31 ~10 min android-e2e 📄 log
57b27c4 #17 2019-04-08 11:02:35 ~10 min linux 📄 log
57b27c4 #16 2019-04-08 11:02:35 ~11 min android 📄 log
e115aca #17 2019-04-11 08:25:51 ~22 sec android-e2e 📄 log
e115aca #17 2019-04-11 08:25:51 ~22 sec android 📄 log
e115aca #17 2019-04-11 08:25:55 ~24 sec ios 📄 log
e115aca #17 2019-04-11 08:25:57 ~24 sec windows 📄 log
e115aca #17 2019-04-11 08:26:03 ~30 sec macos 📄 log
e115aca #18 2019-04-11 08:26:18 ~47 sec linux 📄 log
d2577d4 #18 2019-04-11 08:56:18 ~25 sec android-e2e 📄 log
d2577d4 #18 2019-04-11 08:56:18 ~23 sec android 📄 log
d2577d4 #19 2019-04-11 08:56:22 ~25 sec linux 📄 log
d2577d4 #18 2019-04-11 08:56:23 ~26 sec ios 📄 log
d2577d4 #18 2019-04-11 08:56:25 ~26 sec windows 📄 log
d2577d4 #18 2019-04-11 08:56:28 ~30 sec macos 📄 log
6c8892b #19 2019-04-11 09:28:40 ~24 sec android 📄 log
6c8892b #19 2019-04-11 09:28:40 ~26 sec android-e2e 📄 log
6c8892b #19 2019-04-11 09:28:43 ~23 sec windows 📄 log
6c8892b #20 2019-04-11 09:28:43 ~26 sec linux 📄 log
6c8892b #19 2019-04-11 09:28:43 ~27 sec ios 📄 log
6c8892b #19 2019-04-11 09:28:45 ~27 sec macos 📄 log
c2ec427 #20 2019-04-15 13:18:45 ~30 sec android-e2e 📄 log
c2ec427 #20 2019-04-15 13:18:45 ~28 sec android 📄 log
c2ec427 #20 2019-04-15 13:18:47 ~29 sec ios 📄 log
c2ec427 #21 2019-04-15 13:18:48 ~28 sec linux 📄 log
c2ec427 #20 2019-04-15 13:18:51 ~23 sec windows 📄 log
c2ec427 #20 2019-04-15 13:18:53 ~27 sec macos 📄 log
e327ae4 #21 2019-04-18 10:06:17 ~3 min ios 📄 log
e327ae4 #21 2019-04-18 10:06:54 ~4 min macos 📄 log
e327ae4 #21 2019-04-18 10:06:56 ~4 min windows 📄 log
e327ae4 #22 2019-04-18 10:07:50 ~5 min linux 📄 log
e327ae4 #21 2019-04-18 10:13:18 ~10 min android 📄 log
e327ae4 #21 2019-04-18 10:13:31 ~10 min android-e2e 📄 log
✔️ 5290186 #22 2019-04-18 10:47:45 ~17 min windows 📦 exe
5290186 #22 2019-04-18 10:48:01 ~17 min android-e2e 📄 log
✔️ 5290186 #22 2019-04-18 10:48:45 ~18 min macos 📦 dmg
✔️ 5290186 #23 2019-04-18 10:48:56 ~18 min linux 📦 App
5290186 #22 2019-04-18 10:49:03 ~18 min android 📄 log
✔️ 5290186 #22 2019-04-18 10:57:25 ~27 min ios 📦 ipa
6fe9d0c #23 2019-04-18 11:37:27 ~14 min android-e2e 📄 log
✔️ 6fe9d0c #23 2019-04-18 11:39:07 ~16 min android 📦 apk
✔️ 6fe9d0c #23 2019-04-18 11:39:44 ~16 min windows 📦 exe
✔️ 6fe9d0c #23 2019-04-18 11:39:58 ~16 min macos 📦 dmg
✔️ 6fe9d0c #24 2019-04-18 11:41:49 ~18 min linux 📦 App
✔️ 6fe9d0c #23 2019-04-18 11:46:01 ~23 min ios 📦 ipa
e0258ad #24 2019-04-18 12:13:47 ~14 min android-e2e 📄 log
e0258ad #24 2019-04-18 12:13:48 ~14 min android 📄 log
✔️ e0258ad #24 2019-04-18 12:14:43 ~15 min windows 📦 exe
✔️ e0258ad #24 2019-04-18 12:17:28 ~18 min macos 📦 dmg
✔️ e0258ad #25 2019-04-18 12:18:06 ~18 min linux 📦 App
✔️ e0258ad #24 2019-04-18 12:24:00 ~24 min ios 📦 ipa
✔️ e0258ad #25 2019-04-18 12:55:54 ~14 min android-e2e 📦 apk
e0258ad #25 2019-04-18 15:23:26 ~12 min android 📄 log
✔️ 518309b #25 2019-04-19 13:14:49 ~15 min windows 📦 exe
518309b #26 2019-04-19 13:16:05 ~17 min android-e2e 📄 log
518309b #26 2019-04-19 13:16:25 ~17 min android 📄 log
✔️ 518309b #26 2019-04-19 13:17:00 ~17 min linux 📦 App
✔️ 518309b #25 2019-04-19 13:17:59 ~18 min macos 📦 dmg
✔️ 518309b #25 2019-04-19 13:25:17 ~26 min ios 📦 ipa
518309b #27 2019-04-23 08:05:29 ~24 sec android 📄 log
518309b #27 2019-04-23 08:05:29 ~17 sec android-e2e 📄 log
✔️ b611a48 #26 2019-04-23 09:00:40 ~15 min macos 📦 dmg
✔️ b611a48 #28 2019-04-23 09:02:16 ~17 min android 📦 apk
✔️ b611a48 #26 2019-04-23 09:07:18 ~22 min windows 📦 exe
✔️ b611a48 #27 2019-04-23 09:07:57 ~23 min linux 📦 App
✔️ b611a48 #28 2019-04-23 09:08:02 ~23 min android-e2e 📦 apk
✔️ b611a48 #26 2019-04-23 09:09:55 ~25 min ios 📦 ipa
✔️ 6955e60 #30 2019-04-23 10:38:47 ~17 min android-e2e 📦 apk
✔️ 6955e60 #28 2019-04-23 10:39:58 ~19 min macos 📦 dmg
✔️ 6955e60 #28 2019-04-23 10:42:21 ~21 min windows 📦 exe
✔️ 6955e60 #28 2019-04-23 10:44:07 ~23 min ios 📦 ipa
✔️ 6955e60 #29 2019-04-23 10:44:10 ~23 min linux 📦 App
✔️ 6955e60 #31 2019-04-23 12:20:26 ~25 min android 📦 apk
✔️ 3ba2c8b #29 2019-04-24 13:31:59 ~16 min windows 📦 exe
✔️ 3ba2c8b #29 2019-04-24 13:32:27 ~16 min macos 📦 dmg
✔️ 3ba2c8b #30 2019-04-24 13:38:07 ~22 min linux 📦 App
✔️ 3ba2c8b #29 2019-04-24 13:40:19 ~24 min ios 📦 ipa
✔️ 3ba2c8b #31 2019-04-24 13:43:12 ~27 min android-e2e 📦 apk
✔️ 3ba2c8b #33 2019-04-25 08:13:37 ~16 min android 📦 apk
6595680 #31 2019-04-26 12:42:17 ~17 min linux 📄 log
✔️ 6595680 #30 2019-04-26 12:43:30 ~18 min windows 📦 exe
✔️ 6595680 #30 2019-04-26 12:44:29 ~19 min macos 📦 dmg
✔️ 6595680 #30 2019-04-26 12:48:23 ~23 min ios 📦 ipa
✔️ 6595680 #34 2019-04-26 12:55:45 ~30 min android 📦 apk
✔️ 6595680 #32 2019-04-26 13:06:40 ~14 min linux 📦 App
✔️ 6595680 #33 2019-04-26 13:34:40 ~23 min android-e2e 📦 apk
✔️ 41ab966 #33 2019-04-30 09:47:20 ~15 min linux 📦 App
✔️ 41ab966 #31 2019-04-30 09:48:23 ~16 min windows 📦 exe
✔️ 41ab966 #31 2019-04-30 09:49:58 ~18 min macos 📦 dmg
✔️ 41ab966 #31 2019-04-30 09:56:10 ~24 min ios 📦 ipa
✔️ 41ab966 #34 2019-04-30 09:59:41 ~28 min android-e2e 📦 apk
✔️ 41ab966 #36 2019-04-30 10:49:33 ~21 min android 📦 apk
✔️ 9139ba9 #32 2019-05-01 14:20:48 ~16 min macos 📦 dmg
✔️ 9139ba9 #32 2019-05-01 14:21:23 ~17 min windows 📦 exe
✔️ 9139ba9 #34 2019-05-01 14:23:38 ~19 min linux 📦 App
✔️ 9139ba9 #32 2019-05-01 14:27:37 ~23 min ios 📦 ipa
✔️ 9139ba9 #35 2019-05-01 14:29:18 ~25 min android-e2e 📦 apk
✔️ c7ad62e #33 2019-05-02 10:12:34 ~17 min windows 📦 exe
✔️ c7ad62e #33 2019-05-02 10:15:14 ~20 min macos 📦 dmg
✔️ c7ad62e #35 2019-05-02 10:16:10 ~21 min linux 📦 App
✔️ c7ad62e #33 2019-05-02 10:18:52 ~23 min ios 📦 ipa
✔️ c7ad62e #36 2019-05-02 10:19:20 ~24 min android-e2e 📦 apk
✔️ c7ad62e #39 2019-05-02 11:05:54 ~17 min android 📦 apk
Commit #️⃣ Finished (UTC) Duration Platform Result
cfb9427 #34 2019-05-02 17:59:11 ~4 min ios 📄 log
✔️ cfb9427 #36 2019-05-02 18:11:04 ~16 min linux 📦 App
✔️ cfb9427 #34 2019-05-02 18:11:35 ~17 min macos 📦 dmg
✔️ cfb9427 #34 2019-05-02 18:11:42 ~17 min windows 📦 exe
✔️ cfb9427 #40 2019-05-02 18:19:04 ~24 min android 📦 apk
✔️ cfb9427 #38 2019-05-02 19:01:49 ~20 min android-e2e 📦 apk
✔️ cfb9427 #35 2019-05-02 19:03:43 ~22 min ios 📦 ipa
✔️ 4905ed3 #37 2019-05-03 13:14:01 ~21 min linux 📦 App
✔️ 4905ed3 #35 2019-05-03 13:17:02 ~24 min macos 📦 dmg
✔️ 4905ed3 #36 2019-05-03 13:17:05 ~24 min ios 📦 ipa
✔️ 4905ed3 #35 2019-05-03 13:20:49 ~27 min windows 📦 exe
✔️ 4905ed3 #41 2019-05-03 13:22:01 ~29 min android 📦 apk
✔️ 4905ed3 #39 2019-05-03 13:22:09 ~29 min android-e2e 📦 apk

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Feb 22, 2019

This was referenced Mar 12, 2019
@oskarth

This comment has been minimized.

Copy link
Member

commented May 1, 2019

I agree with what @mandrigin said above. The sooner we can get this into the code base under a flag the better. If adequate testing has been done on this PR I think that's fine.

For dependencies to actually enable it, my understanding is that this mostly about FlatList performance. If there are other issues, can we please capture these in some umbrella issue? Perhaps there is one already?

@annadanchenko

This comment has been minimized.

Copy link
Member

commented May 1, 2019

adequate testing for this PR needs regression testing for mobile app (at least executing Critical/High test cases) that @churik will do today

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

@oskarth, I considered #7399 as an "umbrella issue". Currently FlatList is an only dependency from what I see. It is listed in section "related issues".

@statustestbot

This comment has been minimized.

Copy link

commented May 1, 2019

100% of end-end tests have passed

Total executed tests: 2
Failed tests: 0
Passed tests: 2

Passed tests (2)

Click to expand
1. test_offline_login (TestRail link is not found)
Device sessions

2. test_offline_status
Device sessions

@churik

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@vkjr please, rebase to current develop and resolve conflicts one more time.
Thanks!

@statustestbot

This comment has been minimized.

Copy link

commented May 1, 2019

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_privacy_policy_is_accessible (TestRail link is not found)
Device sessions

@vkjr vkjr force-pushed the feature/mobile_ui_on_desktop branch from 41ab966 to 9139ba9 May 1, 2019

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Please, do not test latest commit with rebase. I found typing issue in old desktop UI, fixing it now.

@vkjr vkjr force-pushed the feature/mobile_ui_on_desktop branch from 9139ba9 to c7ad62e May 2, 2019

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@churik, I fixed the issue, can be tested now

@churik

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@vkjr still testing, so far tested on Linux Ubuntu 18.04, Windows 10 Home, Mac OSx:

  • fresh install, account creating
  • upgrade from current nightly
  • compatibility with 0.12.0
  • exploratory testing in chats, PNs and Profile

What I noticed that clicks on user icons in public chats are still not working as expected, so sometimes it does nothing.
See video: https://take.ms/zS2su
Click on user icon works for me in ~20% cases.
Log: Status_click.log

Continue with testing on mobile...

@vkjr vkjr force-pushed the feature/mobile_ui_on_desktop branch from c7ad62e to cfb9427 May 2, 2019

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@churik, my bad, used incorrect react-native-desktop version. Fixed.

@statustestbot

This comment has been minimized.

Copy link

commented May 3, 2019

67% of end-end tests have passed

Total executed tests: 3
Failed tests: 1
Passed tests: 2

Failed tests (1)

Click to expand
1. test_contact_profile_send_transaction (TestRail link is not found)

Device 1: Tap on HomeButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (2)

Click to expand
1. test_offline_login (TestRail link is not found)
Device sessions

2. test_offline_status
Device sessions

@churik

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@vkjr test-list for mobile: https://ethstatus.testrail.net/index.php?/runs/view/3246&group_by=cases:section_id&group_order=asc

Still testing.
With last commit issues from #7551 (comment) are again reproducible (checked on IOS)
Please take a look.

@vkjr vkjr force-pushed the feature/mobile_ui_on_desktop branch from cfb9427 to 4905ed3 May 3, 2019

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

@churik, should be fine now

@churik

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@vkjr what regression can cause last commit?
Asking because I've already tested most of the TC.
And as you squashed commits, I can identify what exactly changes are done since #7551 (comment)

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

@churik, last commit shouldn't cause any. It appeared that by one of the latest commit I overwrote the one with ios\android fixes. So in a last one only those fixes were returned back.

@vkjr

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

As for squishing commits - won't do like this anymore, my hopes for quick merge were too optimistic :)

@churik

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Tested on desktop builds: #7551 (comment)
Rechecked issue from #7551 (comment) on Mac OSx.
Test list for mobile is here
(most of test-cases are checked on build with this commit: cfb9427)
Primary device: IOS 11.4.1 (IPhone 7), secondary device: Android 8 (LG V20)

No regression introduced by this PR is found. All failures mentioned in the test suite are failures in nightly as well.

@churik churik added the Tested - OK label May 3, 2019

@churik churik moved this from IN TESTING to MERGE in Pipeline for QA May 3, 2019

Mobile UI on desktop can be enabled in .env file
Signed-off-by: Volodymyr Kozieiev <vkjr.sp@gmail.com>

@vkjr vkjr force-pushed the feature/mobile_ui_on_desktop branch from 4905ed3 to 32f7f91 May 3, 2019

@vkjr vkjr merged commit 32f7f91 into develop May 3, 2019

5 of 9 checks passed

security/snyk - android/build.gradle (Status-im) Test in progress
security/snyk - modules/react-native-desktop-linking/package.json (Status-im) Test in progress
security/snyk - modules/react-native-status/package.json (Status-im) Test in progress
security/snyk - test/appium/requirements.txt (Status-im) Test in progress
GPG All commits have a verified GPG signature
WIP Ready for review
Details
security/snyk - Gemfile.lock (Status-im) No manifest changes detected
security/snyk - android/app/build.gradle (Status-im) No manifest changes detected
security/snyk - modules/react-native-desktop-notification/package.json (Status-im) No manifest changes detected

Pipeline for QA automation moved this from MERGE to DONE May 3, 2019

@delete-merged-branch delete-merged-branch bot deleted the feature/mobile_ui_on_desktop branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.