Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always checkout to status-react folder #8357

Closed
wants to merge 1 commit into from

Conversation

@jakubgs
Copy link
Member

commented Jun 4, 2019

This is a possible solution for Pedros issues with changing checkout folder for status-react.

It's really ugly, but I can't use customWorkspace because the context doesn't have access to EXECUTOR_NUMBER variable(JENKINS-50907). Because of that we can only set a static path, and that would cause clashes when more than 1 job of the same type is running on the same host.

Context: https://discourse.nixos.org/t/path-for-src-in-derivation-file-is-created-with-captured-directory-name-as-suffix/3102

always checkout to status-react folder
Signed-off-by: Jakub Sokołowski <jakub@status.im>

@jakubgs jakubgs requested review from PombeirP, mandrigin and vkjr Jun 4, 2019

@jakubgs jakubgs self-assigned this Jun 4, 2019

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 4, 2019

@status-github-bot

This comment has been minimized.

Copy link

commented Jun 4, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
@status-im-auto

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eca63ec #1 2019-06-04 17:02:11 ~13 min ios 📦 ipa
✔️ eca63ec #1 2019-06-04 17:04:15 ~15 min macos 📦 dmg
✔️ eca63ec #1 2019-06-04 17:05:35 ~17 min android 📦 apk
✔️ eca63ec #1 2019-06-04 17:06:00 ~17 min android-e2e 📦 apk
✔️ eca63ec #1 2019-06-04 17:06:00 ~17 min linux 📦 App
✔️ eca63ec #1 2019-06-04 17:07:14 ~18 min windows 📦 exe
@PombeirP
Copy link
Member

left a comment

Thanks @jakub!

@jakubgs

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

Looks like this is not necessary after all thanks to: NixOS/nix#1305
We can use this instead:

src = builtins.path { name = "stack2nix"; path = ./.; };

@jakubgs jakubgs closed this Jun 6, 2019

Pipeline for QA automation moved this from REVIEW to DONE Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.