Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status go/integrate accounts persistence #8725

Merged
merged 5 commits into from Aug 20, 2019

Conversation

@yenda
Copy link
Member

commented Aug 8, 2019

Summary

Currently the regular account creation, login/logout cycle seems to work. Ongoing testing and small fixes on 12/08/19

TODOS

  • can't logout after saved password
  • empty chat screen after login with saved password (and maybe other conditions)
  • check if all settings are migrated
  • custom bootnodes
  • stickers (using settings, to be improved afterward)
  • save and use whisper and wallet accounts
  • write js externs for new native bindings and remove old ones
  • recovery flow (waiting for recovery flow v1)
  • fix recovery flow stucked on loading screen after password input
  • fix adding account in wallet
  • fix pending message status (needs rebase of status-go branch)
  • desktop native bindings kudos @siphiuel
  • iOS native bindings kudos @siphiuel
  • fix tests

Testing

This PR basically affects the entire app, however I think there is no point digging too hard during testing considering that:

  • a followup PR will remove realm which will smooth up the login flow
  • keycard flow will be fixed in a followup PR

Knowns bugs that will be fixed in future PR

  • keycard flow (worked on by @dmitryn )
  • there might be a realm error when starting up, it can be ignored as next PR will remove realm anyway

Tested by dev:

Android real devices are hanging, looking into it (tested One Plus 5T)
iOS is fine (tested iPhone 6 Plus)

I tested the following actions on Android emulator:

  • creating and recovering multiaccount
  • logout and login
  • join public and 1-1 chat
  • send public and 1-1 message
  • create new wallet account
  • logout and login

status: ready

@yenda yenda requested review from dmitryn and flexsurfer Aug 8, 2019

@yenda yenda requested review from antdanchenko, churik, vkjr and status-im/status-core as code owners Aug 8, 2019

@auto-assign auto-assign bot removed the request for review from status-im/status-core Aug 8, 2019

@status-github-bot

This comment has been minimized.

Copy link

commented Aug 8, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 8, 2019

@yenda yenda self-assigned this Aug 8, 2019

@status-im-auto

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Jenkins Builds

Click to see older builds (93)
Commit #️⃣ Finished (UTC) Duration Platform Result
0d5d38f #1 2019-08-08 15:48:12 ~6 min ios 📄 log
0d5d38f #1 2019-08-08 15:59:03 ~16 min android-e2e 📄 log
0d5d38f #1 2019-08-08 15:59:03 ~16 min android 📄 log
26386c5 #2 2019-08-09 18:19:40 ~3 min ios 📄 log
26386c5 #2 2019-08-09 18:24:43 ~8 min android-e2e 📄 log
26386c5 #2 2019-08-09 18:27:04 ~11 min android 📄 log
ee8a04e #3 2019-08-14 11:10:07 ~29 sec android 📄 log
ee8a04e #3 2019-08-14 11:10:08 ~28 sec ios 📄 log
ee8a04e #3 2019-08-14 11:23:12 ~13 min android-e2e 📄 log
3bdd76c #4 2019-08-14 16:00:49 ~21 sec android 📄 log
3bdd76c #4 2019-08-14 16:00:51 ~21 sec ios 📄 log
3bdd76c #4 2019-08-14 16:03:40 ~3 min android-e2e 📄 log
a07cede #5 2019-08-14 20:44:27 ~24 sec android 📄 log
a07cede #5 2019-08-14 20:44:27 ~22 sec ios 📄 log
a07cede #5 2019-08-14 20:47:11 ~3 min android-e2e 📄 log
b4ab159 #6 2019-08-15 07:40:53 ~22 sec android 📄 log
b4ab159 #6 2019-08-15 07:40:55 ~23 sec ios 📄 log
b4ab159 #6 2019-08-15 07:43:32 ~3 min android-e2e 📄 log
5dbc5cb #7 2019-08-15 12:57:52 ~6 min ios 📄 log
5dbc5cb #7 2019-08-15 13:10:01 ~18 min android 📄 log
5dbc5cb #7 2019-08-15 13:10:03 ~18 min android-e2e 📄 log
87a963f #8 2019-08-15 13:48:44 ~3 min android 📄 log
87a963f #8 2019-08-15 13:49:03 ~3 min ios 📄 log
86ffbbd #9 2019-08-15 13:59:26 ~2 min ios 📄 log
86ffbbd #9 2019-08-15 13:59:28 ~2 min android 📄 log
d372009 #10 2019-08-15 14:18:26 ~2 min ios 📄 log
d372009 #10 2019-08-15 14:18:35 ~3 min android-e2e 📄 log
d372009 #10 2019-08-15 14:18:35 ~3 min android 📄 log
6e1b731 #11 2019-08-15 15:43:54 ~5 min ios 📄 log
8cdbd0e #12 2019-08-15 15:57:04 ~2 min ios 📄 log
8cdbd0e #12 2019-08-15 16:06:52 ~12 min android-e2e 📄 log
8cdbd0e #12 2019-08-15 16:13:55 ~19 min android 📄 log
48d7f9d #14 2019-08-16 10:12:22 ~5 min android 📄 log
48d7f9d #14 2019-08-16 10:13:05 ~6 min ios 📄 log
fd33ba8 #15 2019-08-16 10:17:18 ~3 min android-e2e 📄 log
✔️ fd33ba8 #15 2019-08-16 10:24:27 ~10 min ios 📦 ipa
✔️ fd33ba8 #15 2019-08-16 10:25:22 ~11 min android 📦 apk
✔️ fd33ba8 #16 2019-08-16 10:52:28 ~10 min android-e2e 📦 apk
9b2e64c #17 2019-08-16 12:36:26 ~3 min android-e2e 📄 log
✔️ 9b2e64c #16 2019-08-16 12:44:12 ~11 min ios 📦 ipa
✔️ 9b2e64c #16 2019-08-16 12:44:20 ~11 min android 📦 apk
✔️ 9b2e64c #18 2019-08-16 12:56:47 ~10 min android-e2e 📦 apk
cfb5fc1 #19 2019-08-16 13:38:14 ~3 min android-e2e 📄 log
✔️ cfb5fc1 #17 2019-08-16 13:45:54 ~11 min ios 📦 ipa
✔️ cfb5fc1 #17 2019-08-16 13:45:59 ~11 min android 📦 apk
9f8e92a #18 2019-08-16 14:05:55 ~3 min android 📄 log
✔️ 9f8e92a #18 2019-08-16 14:13:25 ~11 min ios 📦 ipa
✔️ 9f8e92a #20 2019-08-16 14:14:05 ~12 min android-e2e 📦 apk
✔️ 9f8e92a #19 2019-08-16 14:31:17 ~11 min android 📦 apk
7fdf815 #20 2019-08-16 15:07:54 ~3 min android 📄 log
✔️ 7fdf815 #19 2019-08-16 15:15:32 ~11 min ios 📦 ipa
✔️ 7fdf815 #21 2019-08-16 15:15:56 ~11 min android-e2e 📦 apk
✔️ 7fdf815 #21 2019-08-16 15:24:56 ~10 min android 📦 apk
4bf830d #22 2019-08-16 16:11:28 ~3 min android-e2e 📄 log
4bf830d #23 2019-08-16 16:16:22 ~3 min android-e2e 📄 log
✔️ 4bf830d #22 2019-08-16 16:19:14 ~11 min android 📦 apk
4bf830d #24 2019-08-16 16:19:43 ~3 min android-e2e 📄 log
✔️ 4bf830d #20 2019-08-16 16:19:56 ~11 min ios 📦 ipa
✔️ 4bf830d #25 2019-08-16 16:32:52 ~8 min android-e2e 📦 apk
9e0ed6e #23 2019-08-19 12:02:51 ~27 sec android 📄 log
9e0ed6e #21 2019-08-19 12:02:51 ~26 sec ios 📄 log
b26694b #22 2019-08-19 12:13:34 ~4 min ios 📄 log
18240f8 #28 2019-08-19 12:22:55 ~7 min android-e2e 📄 log
✔️ 18240f8 #23 2019-08-19 12:26:54 ~11 min ios 📦 ipa
18240f8 #29 2019-08-19 12:27:45 ~3 min android-e2e 📄 log
✔️ 18240f8 #25 2019-08-19 12:30:42 ~15 min android 📦 apk
✔️ 18240f8 #30 2019-08-19 12:41:40 ~9 min android-e2e 📦 apk
caf7f39 #31 2019-08-19 13:21:39 ~3 min android-e2e 📄 log
✔️ 1cb8273 #32 2019-08-19 13:38:05 ~9 min android-e2e 📦 apk
✔️ 1cb8273 #25 2019-08-19 13:39:47 ~11 min ios 📦 ipa
66629d4 #28 2019-08-19 13:50:16 ~3 min android 📄 log
✔️ 2ba5d6b #29 2019-08-19 14:05:22 ~10 min android 📦 apk
✔️ 2ba5d6b #27 2019-08-19 14:05:39 ~11 min ios 📦 ipa
✔️ 2ba5d6b #34 2019-08-19 14:05:45 ~11 min android-e2e 📦 apk
✔️ 70893e5 #31 2019-08-19 14:38:44 ~10 min android 📦 apk
✔️ 70893e5 #29 2019-08-19 14:38:51 ~10 min ios 📦 ipa
✔️ 70893e5 #36 2019-08-19 14:47:21 ~19 min android-e2e 📦 apk
✔️ 7618023 #30 2019-08-20 10:59:50 ~11 min ios 📦 ipa
7618023 #32 2019-08-20 11:02:06 ~13 min android 📄 log
7618023 #33 2019-08-20 11:08:13 ~3 min android 📄 log
✔️ 7618023 #37 2019-08-20 11:10:06 ~21 min android-e2e 📦 apk
✔️ 7618023 #34 2019-08-20 11:19:34 ~8 min android 📦 apk
1da2e26 #38 2019-08-20 13:05:07 ~13 min android-e2e 📄 log
1da2e26 #31 2019-08-20 13:05:50 ~13 min ios 📄 log
976c750 #32 2019-08-20 13:12:57 ~3 min ios 📄 log
✔️ 976c750 #36 2019-08-20 13:20:43 ~11 min android 📦 apk
✔️ 976c750 #33 2019-08-20 13:26:34 ~10 min ios 📦 ipa
✔️ 976c750 #39 2019-08-20 13:30:52 ~21 min android-e2e 📦 apk
dd09852 #37 2019-08-20 14:37:15 ~3 min android 📄 log
✔️ dd09852 #40 2019-08-20 14:42:49 ~9 min android-e2e 📦 apk
✔️ dd09852 #34 2019-08-20 14:47:12 ~13 min ios 📦 ipa
dd09852 #38 2019-08-20 14:50:25 ~3 min android 📄 log
dd09852 #39 2019-08-20 14:54:17 ~3 min android 📄 log
Commit #️⃣ Finished (UTC) Duration Platform Result
733118d #41 2019-08-20 15:01:42 ~3 min android-e2e 📄 log
✔️ 733118d #40 2019-08-20 15:08:48 ~10 min android 📦 apk
✔️ 733118d #35 2019-08-20 15:09:00 ~11 min ios 📦 ipa
✔️ 733118d #42 2019-08-20 15:13:25 ~9 min android-e2e 📦 apk
✔️ d07cc19 #36 2019-08-20 15:55:58 ~13 min ios 📦 ipa
d07cc19 #41 2019-08-20 15:56:10 ~13 min android 📄 log
✔️ d07cc19 #43 2019-08-20 16:01:40 ~19 min android-e2e 📦 apk

@yenda yenda requested review from jakubgs and PombeirP as code owners Aug 9, 2019

@yenda yenda changed the title Status go/integrate accounts persistence [WIP] Status go/integrate accounts persistence Aug 12, 2019

@yenda yenda added the v1 audit label Aug 12, 2019

@yenda yenda requested a review from siphiuel Aug 12, 2019

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Aug 12, 2019

externs.js Outdated
@@ -563,5 +567,6 @@ var TopLevel = {
"createAppContainer" : function () {},
"useScreens" : function () {},
"multiAccountGenerateAndDeriveAddresses" : function () {},
"multiAccountStireAccount" : function () {},

This comment has been minimized.

Copy link
@flexsurfer

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from b4ab159 to 5dbc5cb Aug 15, 2019

;;transfer-by-id (get-in db [:wallet :transaction id]) ;; TODO didn't found any usage of this
(when-let [unique-id (when (not= transfer transfer-by-hash) ;(or transfer-by-id)
(let [transfer-by-hash (get-in db [:wallet :accounts address :transactions hash])
transfer-by-id (get-in db [:wallet :transaction id])]

This comment has been minimized.

Copy link
@flexsurfer

flexsurfer Aug 15, 2019

Member

@siphiuel @yenda could you please point where we set this? i couldn't find

This comment has been minimized.

Copy link
@yenda

yenda Aug 16, 2019

Author Member

it's status-go side

This comment has been minimized.

Copy link
@flexsurfer

flexsurfer Aug 16, 2019

Member

wut? i mean where in status react we assoc value to :wallet :transaction id ?

This comment has been minimized.

Copy link
@yenda

yenda Aug 16, 2019

Author Member

it's right here. the transfer has a hash and id when it arrives from status-go, and in this function we check if there is already a transfer in the map that has this hash or id as key, if the hash is already there we use the id, if the id is already there we already have the transfer in the map

This comment has been minimized.

Copy link
@flexsurfer

flexsurfer Aug 16, 2019

Member

still there should be a place where we put :transaction i can't find it, to get (get-in db [:wallet :transaction id]) we need to put it there first

This comment has been minimized.

Copy link
@yenda

yenda Aug 16, 2019

Author Member

that is suppose to be the list of transactions

@flexsurfer
Copy link
Member

left a comment

this is just incredible work! HUGE KUDOS!

};
@Override
public void run() {
String result =Statusgo.openAccounts(rootDir);

This comment has been minimized.

Copy link
@flexsurfer

This comment has been minimized.

Copy link
@yenda

yenda Aug 16, 2019

Author Member

what?

This comment has been minimized.

Copy link
@flexsurfer
@@ -99,7 +99,7 @@
(defn chain-keyword
[db]
(let [network-id (get-in db [:multiaccount :network])
network (get-in db [:multiaccount :networks network-id])]
network (get-in db [:multiaccount :networks/networks network-id])]

This comment has been minimized.

Copy link
@flexsurfer

flexsurfer Aug 16, 2019

Member

how did it work before?

This comment has been minimized.

Copy link
@yenda

yenda Aug 16, 2019

Author Member

by renaming the key somewhere else

@yenda yenda changed the title [WIP] Status go/integrate accounts persistence Status go/integrate accounts persistence Aug 16, 2019

@yenda yenda moved this from CONTRIBUTOR to REVIEW in Pipeline for QA Aug 16, 2019

@yenda yenda moved this from REVIEW to TO TEST in Pipeline for QA Aug 16, 2019

@jakubgs
Copy link
Member

left a comment

Approving only the Nix changes.

−5832 lines

1454209640257

@asemiankevich asemiankevich moved this from TO TEST to IN TESTING in Pipeline for QA Aug 16, 2019

@asemiankevich asemiankevich self-assigned this Aug 16, 2019

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

@yenda one more issue: when sending tokens to address from wallet -> invalid recipient shown and network fee is 0

Steps:

  1. open status and faucet some funds + tokens in simpledapp
  2. add one more account in your wallet
  3. send some tokens from Status account to new account in wallet

Pay attention : recipient is New Contract, Network fee is empty

image

@statustestbot

This comment has been minimized.

Copy link

commented Aug 19, 2019

86% of end-end tests have passed

Total executed tests: 44
Failed tests: 6
Passed tests: 38

Failed tests (6)

Click to expand
1. test_block_user_from_public_chat

Device 2: Wait for OkButton
Device 2: Wait for ContinueButton

Device 1: 'GetStartedButton' is not found on the screen

Device sessions

2. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

3. test_long_press_to_delete_public_chat

Device 1: Looking for a message by text: 'test message'
Device 1: Wait for ChatElementByText

Chat history is shown

Device sessions

4. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen

Device sessions

5. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

6. test_user_can_remove_profile_picture

Device 1: Tap on AllowButton
Device 1: Looking for an element by text: 'sauce_logo.png'

Device 1: Profile picture was not updated

Device sessions

Passed tests (38)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_deploy_contract_from_daap
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_sign_typed_message
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_logcat_send_transaction_from_wallet
Device sessions

15. test_send_token_with_7_decimals
Device sessions

16. test_offline_messaging_1_1_chat
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_send_emoji
Device sessions

21. test_search_chat_on_home
Device sessions

22. test_logcat_recovering_account
Device sessions

23. test_messaging_in_different_networks
Device sessions

24. test_logcat_sign_message_from_daap
Device sessions

25. test_send_stt_from_wallet
Device sessions

26. test_login_with_new_account
Device sessions

27. test_start_chat_with_ens
Device sessions

28. test_add_contact_from_public_chat
Device sessions

29. test_send_two_transactions_one_after_another_in_dapp
Device sessions

30. test_password_in_logcat_creating_account
Device sessions

31. test_backup_recovery_phrase
Device sessions

32. test_offline_status
Device sessions

33. test_open_google_com_via_open_dapp
Device sessions

34. test_unread_messages_counter_public_chat
Device sessions

35. test_sign_message_from_daap
Device sessions

36. test_share_contact_code_and_wallet_address
Device sessions

37. test_refresh_button_browsing_app_webview
Device sessions

38. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot

This comment has been minimized.

Copy link

commented Aug 19, 2019

75% of end-end tests have passed

Total executed tests: 44
Failed tests: 11
Passed tests: 33

Failed tests (11)

Click to expand
1. test_send_transaction_from_daap

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Balance is not changed during 360 seconds, funds were not received!

Device sessions

2. test_deploy_contract_from_daap

Device 1: Tap on OkButton
Device 1: Looking for an element by text: 'Contract deployed at: '

Contract was not created

Device sessions

3. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

4. test_send_token_with_7_decimals

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.0595011 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

5. test_send_eth_from_wallet_to_address

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.0019145719 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913

Device sessions

6. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen

Device sessions

7. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

8. test_send_stt_from_wallet

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.0019145757 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

9. test_login_with_new_account

Device 1: Wait for ContinueButton
Device 1: Looking for an element by text: 'Kindhearted Sienna Turkey'

Device 1: Username is not shown while login

Device sessions

10. test_offline_status

Device 1: Tap on PlusButton
Device 1: Wait for StartNewChatButton

Device 1: 'StartNewChatButton' is not found on the screen

Device sessions

11. test_user_can_remove_profile_picture

Device 1: Tap on AllowButton
Device 1: Looking for an element by text: 'sauce_logo.png'

Device 1: Profile picture was not updated

Device sessions

Passed tests (33)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_open_transaction_on_etherscan
Device sessions

5. test_public_chat_messaging
Device sessions

6. test_long_press_to_delete_1_1_chat
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_sign_typed_message
Device sessions

10. test_unread_messages_counter_1_1_chat
Device sessions

11. test_logcat_send_transaction_from_daap
Device sessions

12. test_send_message_in_group_chat
Device sessions

13. test_logcat_send_transaction_from_wallet
Device sessions

14. test_offline_messaging_1_1_chat
Device sessions

15. test_modify_transaction_fee_values
Device sessions

16. test_manage_assets
Device sessions

17. test_long_press_to_delete_public_chat
Device sessions

18. test_send_emoji
Device sessions

19. test_search_chat_on_home
Device sessions

20. test_logcat_recovering_account
Device sessions

21. test_messaging_in_different_networks
Device sessions

22. test_logcat_sign_message_from_daap
Device sessions

23. test_start_chat_with_ens
Device sessions

24. test_add_contact_from_public_chat
Device sessions

25. test_send_two_transactions_one_after_another_in_dapp
Device sessions

26. test_password_in_logcat_creating_account
Device sessions

27. test_backup_recovery_phrase
Device sessions

28. test_open_google_com_via_open_dapp
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_sign_message_from_daap
Device sessions

31. test_share_contact_code_and_wallet_address
Device sessions

32. test_refresh_button_browsing_app_webview
Device sessions

33. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot

This comment has been minimized.

Copy link

commented Aug 20, 2019

89% of end-end tests have passed

Total executed tests: 44
Failed tests: 5
Passed tests: 39

Failed tests (5)

Click to expand
1. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

2. test_long_press_to_delete_public_chat

Device 1: Looking for a message by text: 'test message'
Device 1: Wait for ChatElementByText

Chat history is shown

Device sessions

3. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen

Device sessions

4. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

5. test_user_can_remove_profile_picture

Device 1: Looking for an element by text: 'Images'
Device 1: Looking for an element by text: 'DCIM'

Device 1: Profile picture was not updated

Device sessions

Passed tests (39)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_offline_messaging_1_1_chat
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_send_emoji
Device sessions

22. test_search_chat_on_home
Device sessions

23. test_logcat_recovering_account
Device sessions

24. test_messaging_in_different_networks
Device sessions

25. test_logcat_sign_message_from_daap
Device sessions

26. test_send_stt_from_wallet
Device sessions

27. test_login_with_new_account
Device sessions

28. test_start_chat_with_ens
Device sessions

29. test_add_contact_from_public_chat
Device sessions

30. test_send_two_transactions_one_after_another_in_dapp
Device sessions

31. test_password_in_logcat_creating_account
Device sessions

32. test_backup_recovery_phrase
Device sessions

33. test_offline_status
Device sessions

34. test_open_google_com_via_open_dapp
Device sessions

35. test_unread_messages_counter_public_chat
Device sessions

36. test_sign_message_from_daap
Device sessions

37. test_share_contact_code_and_wallet_address
Device sessions

38. test_refresh_button_browsing_app_webview
Device sessions

39. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from 70893e5 to 7618023 Aug 20, 2019

@statustestbot

This comment has been minimized.

Copy link

commented Aug 20, 2019

89% of end-end tests have passed

Total executed tests: 45
Failed tests: 5
Passed tests: 40

Failed tests (5)

Click to expand
1. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

2. test_long_press_to_delete_public_chat

Device 1: Looking for a message by text: 'test message'
Device 1: Wait for ChatElementByText

Chat history is shown

Device sessions

3. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen; also Unexpected Alert is shown: 'Cannot write BigNumber'

Device sessions

4. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

5. test_user_can_remove_profile_picture

Device 1: Looking for an element by text: 'Images'
Device 1: Looking for an element by text: 'DCIM'

Device 1: Profile picture was not updated

Device sessions

Passed tests (40)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_offline_messaging_1_1_chat
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_add_account_to_multiaccount_instance
Device sessions

21. test_manage_assets
Device sessions

22. test_send_emoji
Device sessions

23. test_search_chat_on_home
Device sessions

24. test_logcat_recovering_account
Device sessions

25. test_messaging_in_different_networks
Device sessions

26. test_logcat_sign_message_from_daap
Device sessions

27. test_send_stt_from_wallet
Device sessions

28. test_login_with_new_account
Device sessions

29. test_start_chat_with_ens
Device sessions

30. test_add_contact_from_public_chat
Device sessions

31. test_send_two_transactions_one_after_another_in_dapp
Device sessions

32. test_password_in_logcat_creating_account
Device sessions

33. test_backup_recovery_phrase
Device sessions

34. test_offline_status
Device sessions

35. test_open_google_com_via_open_dapp
Device sessions

36. test_unread_messages_counter_public_chat
Device sessions

37. test_sign_message_from_daap
Device sessions

38. test_share_contact_code_and_wallet_address
Device sessions

39. test_refresh_button_browsing_app_webview
Device sessions

40. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from 7618023 to 1da2e26 Aug 20, 2019

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@yenda Eric sorry for delay, would you mind to look into this? Can't sign message to cryptokitties

image

cant add ethereum address in wallet
image

cant sent stt
image

@churik

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

at attempt to sell some SNT on AirSwap:
the same error as for 3 from #8725 (comment) - cannot locate account for address

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from 1da2e26 to 976c750 Aug 20, 2019

@statustestbot

This comment has been minimized.

Copy link

commented Aug 20, 2019

89% of end-end tests have passed

Total executed tests: 45
Failed tests: 5
Passed tests: 40

Failed tests (5)

Click to expand
1. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

2. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen; also Unexpected Alert is shown: 'Cannot write BigNumber'

Device sessions

3. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

4. test_offline_status

Device 1: Tap on PlusButton
Device 1: Wait for StartNewChatButton

Device 1: 'StartNewChatButton' is not found on the screen

Device sessions

5. test_user_can_remove_profile_picture

Device 1: Looking for an element by text: 'Images'
Device 1: Looking for an element by text: 'DCIM'

Device 1: Profile picture was not updated

Device sessions

Passed tests (40)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_offline_messaging_1_1_chat
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_add_account_to_multiaccount_instance
Device sessions

21. test_manage_assets
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_logcat_sign_message_from_daap
Device sessions

28. test_send_stt_from_wallet
Device sessions

29. test_login_with_new_account
Device sessions

30. test_start_chat_with_ens
Device sessions

31. test_add_contact_from_public_chat
Device sessions

32. test_send_two_transactions_one_after_another_in_dapp
Device sessions

33. test_password_in_logcat_creating_account
Device sessions

34. test_backup_recovery_phrase
Device sessions

35. test_open_google_com_via_open_dapp
Device sessions

36. test_unread_messages_counter_public_chat
Device sessions

37. test_sign_message_from_daap
Device sessions

38. test_share_contact_code_and_wallet_address
Device sessions

39. test_refresh_button_browsing_app_webview
Device sessions

40. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from dd09852 to 733118d Aug 20, 2019

@asemiankevich

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

iOS issues are fixed.
issue for adding account for multiaccount when using recovered account will be logged separately

@statustestbot

This comment has been minimized.

Copy link

commented Aug 20, 2019

89% of end-end tests have passed

Total executed tests: 45
Failed tests: 5
Passed tests: 40

Failed tests (5)

Click to expand
1. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

Updated profile picture is not shown in one-to-one chat

Device sessions

2. test_can_add_existing_ens

Device 1: Looking for an element by text part: 'Username added'
Device 1: Looking for an element by text: 'Ok, got it'

Device 1: 'BaseButton' is not found on the screen; also Unexpected Alert is shown: 'Cannot write BigNumber'

Device sessions

3. test_switch_users_and_add_new_account

Device 1: Wait for DefaultUserNameText
Device 1: Tap on ShareMyProfileButton

Device 1: 'PublicKeyText' is not found on the screen

Device sessions

4. test_offline_status

Device 1: Tap on PlusButton
Device 1: Wait for StartNewChatButton

Device 1: 'StartNewChatButton' is not found on the screen

Device sessions

5. test_user_can_remove_profile_picture

Device 1: Looking for an element by text: 'Images'
Device 1: Looking for an element by text: 'DCIM'

Device 1: Profile picture was not updated

Device sessions

Passed tests (40)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_offline_messaging_1_1_chat
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_add_account_to_multiaccount_instance
Device sessions

21. test_manage_assets
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_logcat_sign_message_from_daap
Device sessions

28. test_send_stt_from_wallet
Device sessions

29. test_login_with_new_account
Device sessions

30. test_start_chat_with_ens
Device sessions

31. test_add_contact_from_public_chat
Device sessions

32. test_send_two_transactions_one_after_another_in_dapp
Device sessions

33. test_password_in_logcat_creating_account
Device sessions

34. test_backup_recovery_phrase
Device sessions

35. test_open_google_com_via_open_dapp
Device sessions

36. test_unread_messages_counter_public_chat
Device sessions

37. test_sign_message_from_daap
Device sessions

38. test_share_contact_code_and_wallet_address
Device sessions

39. test_refresh_button_browsing_app_webview
Device sessions

40. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@asemiankevich asemiankevich moved this from IN TESTING to MERGE in Pipeline for QA Aug 20, 2019

@yenda yenda referenced this pull request Aug 20, 2019
yenda added 4 commits Jul 31, 2019
integrate status-go initKeystore native call
- avoids having to start a node before login

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from 733118d to d07cc19 Aug 20, 2019

@yenda yenda force-pushed the status-go/integrate-accounts-persistence branch from d07cc19 to f2cf427 Aug 20, 2019

@yenda yenda merged commit f2cf427 into develop Aug 20, 2019

9 of 10 checks passed

packages-check-bot No changes to dependencies
Details
GPG All commits have a verified GPG signature
WIP Ready for review
Details
security/snyk - android/app/build.gradle (Status-im) No manifest changes detected
security/snyk - android/build.gradle (Status-im) No manifest changes detected
security/snyk - fastlane/Gemfile.lock (Status-im) No manifest changes detected
security/snyk - modules/react-native-desktop-linking/package.json (Status-im) No manifest changes detected
security/snyk - modules/react-native-desktop-notification/package.json (Status-im) No manifest changes detected
security/snyk - modules/react-native-status/package.json (Status-im) No manifest changes detected
security/snyk - test/appium/requirements.txt (Status-im) No manifest changes detected

Pipeline for QA automation moved this from MERGE to DONE Aug 20, 2019

@delete-merged-branch delete-merged-branch bot deleted the status-go/integrate-accounts-persistence branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.