Repository navigation
Add simple predicate functions - #84
Closed
mabdullahsari wants to merge 2 commits into
Closed
mabdullahsari wants to merge 2 commits into
mabdullahsari wants to merge 2 commits into
Conversation
added 2 commits
February 12, 2022 19:31
Owner
|
Thanks, I'll take a look. |
Author
Seems like some tests are failing, and rightfully so. I'm not really sure if this fixable as it will probably require a new major release in this case. 😕 |
Author
|
I think the only possible "fix" in this case is moving the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed predicate functions in this PR already exist as query scopes within
HasRecursiveRelationshipScopes. However, it would be nice to also have them as instance methods on the models itself. I haven't gone overboard and re-implemented every single one as predicates, but these simple ones are IMHO the most useful ones.Assume the following scenario:
pagemodel, which represents a dynamic page on a website, is always loaded regardless of its relationship status.