New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox not showing / function doesn't exist #247

Closed
Bobz-zg opened this Issue Aug 25, 2016 · 12 comments

Comments

Projects
None yet
2 participants
@Bobz-zg

Bobz-zg commented Aug 25, 2016

Hi,

I have an issue with the plugin, at first I thought it was caching problem but turns out not after all.
Plugin is active and I set in Options not to show form, then I manually add it to my comments template:

<?php if (function_exists('subscribe_reloaded_show')) :
        echo 'exists';
        subscribe_reloaded_show();
else :
        echo 'doesnt exist';
endif; ?>

Sadly this shows that function doesn't exits at all.

If I remove the function from template, and then try to activate the plugin trough options then I can see only part saying: 'You can manage the subscriptions of this post.' but not the checkbox.

screen shot 2016-08-25 at 20 10 05
screen shot 2016-08-25 at 20 10 46

Versions:

  • WP 4.6
  • PHP 7
  • Plugin Version 160115
@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Aug 25, 2016

Hello @Bobz-zg ,

Yes there is a bug with that version that I already fixed. This weekend I will be releasing the new update, but it will be helpful if you could test it before.

You can download it from here:

https://github.com/stcr/subscribe-to-comments-reloaded/archive/development.zip

@Bobz-zg

This comment has been minimized.

Bobz-zg commented Aug 25, 2016

Hy @Reedyseth
Thanks for quick reply, I will give it a test and let you know how it went.

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Aug 25, 2016

Thanks for quick reply, I will give it a test and let you know how it went.

Thank you. I will appreciate it !

@Reedyseth Reedyseth self-assigned this Aug 25, 2016

@Bobz-zg

This comment has been minimized.

Bobz-zg commented Aug 26, 2016

Hi @Reedyseth

I have checked and now it's working for me.
Have found one problem, when I want to get to subscription page manager_link shortcode is not parsed, not sure is it me or not. I do get it in email but it's not shown on page after form submit

screen shot 2016-08-26 at 09 44 34

Second thing is a request if possible, and that's to update markup on management page so I can style them to my need, right now it's difficult to style it and it looks bad for me:

screen-shot-2016-08-26-at-09 53 21

  1. Remove nbsp
  2. Proposed markup:
<p class="stcr-p stcr-email">
    <span class="title">Email<span> <span class="email">me@gmail.com</span>
</p>


<div class="stcr-legend">
    <p class="stcr-p stcr-title">Title</p>

    <dl>
        <dt>Y<dt>
        <dd>all comments</dd>
        <dt>R</dt>
        <dd>replies only</dd>
        <dt>C<dt>
        <dd>inactive</dd>
    <dl>
</div>

<div class="stcr-actions">
    <p class="stcr-p stcr-title">Title</p>

    <p class="stcr-p stcr-action-name">
        <label for="action-name">
            <span class="title">title</span>
            <input type="radio" name="action-name" />
        </label>
    </p>
</div>
@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Aug 26, 2016

@Bobz-zg Thank you for the suggestion on the markup. Yes that view needs a lot of UI improvement, as well as responsive support.

Have found one problem, when I want to get to subscription page manager_link shortcode is not parsed, not sure is it me or not. I do get it in email but it's not shown on page after form submit

Yes that part is buggy because it used to display the manager link, but you could hack this very easy by entering any user email and get the manager link, this is why I removed the functionality for That Tag.

The solution is to add two sections, 1 for the frontend message and another one for the email notification. I might delay the release of the update a few days to get this kind of bugs fixed.

Thank you for your suggestions.

@Reedyseth Reedyseth added this to the Next Release milestone Aug 26, 2016

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Aug 26, 2016

@Bobz-zg

I have added the solution as I mentioned, please give another try to the development code by downloading again the files.

https://github.com/stcr/subscribe-to-comments-reloaded/archive/development.zip

@Bobz-zg

This comment has been minimized.

Bobz-zg commented Aug 27, 2016

@Reedyseth

Have tested and still have the same issue with manage_link shortcode not parsing.
Looks like you need to: <?php echo do_shortcode($content); ?>

Also, another issue is now present, I got empty email that should send me link to manage my comments

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Aug 27, 2016

Did you noticed that now there is an extra field on the notification options?

One Field is to display the notification request to a user and it only parse the [blog_name] tag.

image

The other field is use for the email notification, in that field you can use the [blog_name] and [manager_link]

image

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Sep 3, 2016

@Bobz-zg A new version is out so please update and check it out !

@Bobz-zg

This comment has been minimized.

Bobz-zg commented Sep 4, 2016

@Reedyseth I will give it a spin. Thanks.

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Sep 5, 2016

@Bobz-zg Do you have all up a running without issues ?

@Reedyseth

This comment has been minimized.

Member

Reedyseth commented Sep 7, 2016

Second thing is a request if possible, and that's to update markup on management page so I can style them to my need, right now it's difficult to style it and it looks bad for me:

This commit closes this request: 2c5585d

@Reedyseth Reedyseth closed this Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment