Auto-generated commit

Author: stdlib-bot

.editorconfig

@@ -45,6 +45,10 @@ indent_style = tab
 indent_style = space
 indent_size = 2
 
+# Set properties for `cli_opts.json` files:
+[cli_opts.json]
+indent_style = tab
+
 # Set properties for TypeScript files:
 [*.ts]
 indent_style = tab

.github/workflows/publish.yml

@@ -38,7 +38,7 @@ jobs:
         timeout-minutes: 5
       - name: Replace all GitHub links to individual packages with npm links
         run: |
-          find . -type f -name '*.md' -print0 | xargs -0 sed -Ei 's/@stdlib\/([^:]*)\]: https:\/\/github.com\/stdlib-js/@stdlib\/\1\]: https:\/\/www.npmjs.com\/package\/@stdlib/g'
+          find . -type f -name '*.md' -print0 | xargs -0 sed -Ei '/tree\/main/b; s/@stdlib\/([^:]*)\]: https:\/\/github.com\/stdlib-js/@stdlib\/\1\]: https:\/\/www.npmjs.com\/package\/@stdlib/g'
       - name: Replace all stdlib GitHub dependencies with the respective npm packages
         run: |
           find package.json -type f -print0 | xargs -0 sed -Ei 's/"github:stdlib-js[^"]*"/"^0.0.x"/g'

.github/workflows/test.yml

@@ -44,11 +44,17 @@ jobs:
         run: |
           npm install || npm install || npm install
         timeout-minutes: 15
+      - name: Build native add-on (if present)
+        run: |
+          if [ -f "binding.gyp" ]; then
+            npm install node-gyp --no-save && ./node_modules/.bin/node-gyp rebuild
+          fi
       - name: Run tests
         id: tests
         run: |
           npm test || npm test || npm test
-      - uses: act10ns/slack@v1
+      - name: Send status to Slack channel in case of failure
+        uses: act10ns/slack@v1
         with:
           status: ${{ job.status }}
           steps: ${{ toJson(steps) }}

.github/workflows/test_coverage.yml

@@ -40,20 +40,37 @@ jobs:
         run: |
           npm install || npm install || npm install
         timeout-minutes: 15
+      - name: Build native add-on (if present)
+        run: |
+          if [ -f "binding.gyp" ]; then
+            npm install node-gyp --no-save && ./node_modules/.bin/node-gyp rebuild
+          fi
       - name: Calculate test coverage
         run: |
           npm run test-cov || npm run test-cov || npm run test-cov
         timeout-minutes: 15
       - name: Upload coverage to Codecov
         id: upload
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v2
         with:
           directory: reports/coverage
           flags: unittests
           fail_ci_if_error: true
+      - name: Extract coverage value and assign to output
+        id: extract-coverage
+        run: |
+          coverage=`cat reports/coverage/lcov-report/index.html | grep "fraction" | grep -oP '\d+/\d+' | printf %s "$(cat)" | jq -R -s -c 'split("\n")'`
+          echo "::set-output name=coverage::$coverage"
       - uses: act10ns/slack@v1
         with:
           status: ${{ job.status }}
           steps: ${{ toJson(steps) }}
           channel: '#npm-ci'
         if: failure()
+      - name: Send Webhook with status to stdlib backend
+        uses: distributhor/workflow-webhook@v2
+        env:
+          webhook_url: ${{ secrets.STDLIB_COVERAGE_URL }}
+          webhook_secret: ${{ secrets.STDLIB_WEBHOOK_SECRET }}
+          data: '${{ steps.extract-coverage.outputs.coverage }}'
+        if: ${{ false }}

.github/workflows/test_install.yml

@@ -27,14 +27,15 @@ on:
   workflow_run:
     workflows: ["Publish Package"]
     types: [completed]
+  workflow_dispatch:
 
 # Workflow jobs:
 jobs:
   on-success:
     runs-on: ubuntu-latest
     env:
       SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }}
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
@@ -45,7 +46,8 @@ jobs:
         run: |
           npm install --only=prod || npm install --only=prod || npm install --only=prod
         timeout-minutes: 15
-      - uses: act10ns/slack@v1
+      - name: Send notification to Slack in case of failure
+        uses: act10ns/slack@v1
         with:
           status: ${{ job.status }}
           steps: ${{ toJson(steps) }}

CONTRIBUTORS

@@ -16,6 +16,7 @@ Justin Dennison <justin1dennison@gmail.com>
 Marcus <mfantham@users.noreply.github.com>
 Matt Cochrane <matthew.cochrane.eng@gmail.com>
 Milan Raj <rajsite@users.noreply.github.com>
+Momtchil Momtchev <momtchil@momtchev.com>
 Ognjen Jevremović <ognjenjevremovic@users.noreply.github.com>
 Philipp Burckhardt <pburckhardt@outlook.com>
 Ricky Reusser <rsreusser@gmail.com>

README.md

@@ -20,7 +20,7 @@ limitations under the License.
 
 # Max View Buffer Index
 
-[![NPM version][npm-image]][npm-url] [![Build Status][test-image]][test-url] [![Coverage Status][coverage-image]][coverage-url] [![dependencies][dependencies-image]][dependencies-url]
+[![NPM version][npm-image]][npm-url] [![Build Status][test-image]][test-url] [![Coverage Status][coverage-image]][coverage-url] <!-- [![dependencies][dependencies-image]][dependencies-url] -->
 
 > Compute the maximum linear index in an underlying data buffer accessible to an array view.
 
@@ -142,6 +142,14 @@ for ( i = 0; i < 100; i++ ) {
 
 <!-- /.references -->
 
+<!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. -->
+
+<section class="related">
+
+</section>
+
+<!-- /.related -->
+
 <!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. -->
 
 
@@ -187,9 +195,13 @@ Copyright &copy; 2016-2021. The Stdlib [Authors][stdlib-authors].
 [coverage-image]: https://img.shields.io/codecov/c/github/stdlib-js/ndarray-base-max-view-buffer-index/main.svg
 [coverage-url]: https://codecov.io/github/stdlib-js/ndarray-base-max-view-buffer-index?branch=main
 
+<!--
+
 [dependencies-image]: https://img.shields.io/david/stdlib-js/ndarray-base-max-view-buffer-index.svg
 [dependencies-url]: https://david-dm.org/stdlib-js/ndarray-base-max-view-buffer-index/main
 
+-->
+
 [chat-image]: https://img.shields.io/gitter/room/stdlib-js/stdlib.svg
 [chat-url]: https://gitter.im/stdlib-js/stdlib/
 

lib/main.js

@@ -68,8 +68,11 @@ function maxViewBufferIndex( shape, strides, offset ) {
 	ndims = shape.length;
 	idx = offset;
 	for ( i = 0; i < ndims; i++ ) {
+		if ( shape[ i ] === 0 ) {
+			return offset;
+		}
 		if ( strides[ i ] > 0 ) {
-			idx += strides[ i ] * (shape[ i ] - 1);
+			idx += strides[ i ] * ( shape[ i ] - 1 );
 		}
 	}
 	return idx;

src/main.c

@@ -46,8 +46,11 @@ int64_t stdlib_ndarray_max_view_buffer_index( int64_t ndims, int64_t *shape, int
 
 	idx = offset;
 	for ( i = 0; i < ndims; i++ ) {
+		if ( shape[ i ] == 0 ) {
+			return offset;
+		}
 		if ( strides[ i ] > 0 ) {
-			idx += strides[ i ] * (shape[ i ] - 1);
+			idx += strides[ i ] * ( shape[ i ] - 1 );
 		}
 	}
 	return idx;

test/test.js

@@ -126,3 +126,30 @@ tape( 'the function computes the maximum linear index in an underlying array buf
 
 	t.end();
 });
+
+tape( 'the function returns the provided offset when one or more dimensions is zero', function test( t ) {
+	var strides;
+	var offset;
+	var shape;
+	var idx;
+
+	shape = [ 3, 0 ];
+	strides = [ 2, 1 ];
+	offset = 10;
+	idx = maxViewBufferIndex( shape, strides, offset );
+	t.strictEqual( idx, 10, 'returns expected value' );
+
+	shape = [ 0, 2 ];
+	strides = [ -2, 1 ];
+	offset = 14;
+	idx = maxViewBufferIndex( shape, strides, offset );
+	t.strictEqual( idx, 14, 'returns expected value' );
+
+	shape = [ 0, 0 ];
+	strides = [ 2, -1 ];
+	offset = 11;
+	idx = maxViewBufferIndex( shape, strides, offset );
+	t.strictEqual( idx, 11, 'returns expected value' );
+
+	t.end();
+});