From 304952c62edadfdadf7beea13397de75af556cf5 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 8 May 2026 12:34:08 +0000 Subject: [PATCH 1/3] style: align `RangeError` message and `@throws` text with sibling packages in `blas/ext/base/slast-index-of-row` https://claude.ai/code/session_011khUcNFhVFVmsnp7Tcp1vR --- .../ext/base/slast-index-of-row/lib/slast_index_of_row.js | 4 ++-- .../base/slast-index-of-row/lib/slast_index_of_row.native.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js index c431e193883f..fb6afa9883e4 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js +++ b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js @@ -49,7 +49,7 @@ var ndarray = require( './ndarray.js' ); * @param {Uint8Array} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be a valid stride +* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) * @returns {integer} row index * * @example @@ -76,7 +76,7 @@ function slastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW ) s = M; } if ( LDA < max( 1, s ) ) { - throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) ); + throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) ); } if ( isColumnMajor( order ) ) { sa1 = 1; diff --git a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js index dbea8d3b4abf..36d2f1f408ef 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js @@ -43,7 +43,7 @@ var addon = require( './../src/addon.node' ); * @param {Uint8Array} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be a valid stride +* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) * @returns {integer} row index * * @example @@ -68,7 +68,7 @@ function slastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW ) s = M; } if ( LDA < max( 1, s ) ) { - throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) ); + throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) ); } return addon( resolveOrder( order ), M, N, A, LDA, x, strideX, workspace, strideW ); // eslint-disable-line max-len } From 4cfe7c0531efa81e671e795998cba16b5cf5e598 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 8 May 2026 12:34:12 +0000 Subject: [PATCH 2/3] style: align `RangeError` message and `@throws` text with sibling packages in `blas/ext/base/glast-index-of-row` https://claude.ai/code/session_011khUcNFhVFVmsnp7Tcp1vR --- .../@stdlib/blas/ext/base/glast-index-of-row/lib/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js b/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js index c01570bba41a..4281afb8499e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js @@ -49,7 +49,7 @@ var ndarray = require( './ndarray.js' ); * @param {Collection} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be a valid stride +* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) * @returns {integer} row index * * @example @@ -73,7 +73,7 @@ function glastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW ) s = M; } if ( LDA < max( 1, s ) ) { - throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) ); + throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) ); } if ( isColumnMajor( order ) ) { sa1 = 1; From 43f03c8fa8010a1701ebe9e08652c19c1affa603 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 10 May 2026 14:35:28 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/blas/ext/base/glast-index-of-row/lib/main.js | 2 +- .../blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js | 2 +- .../base/slast-index-of-row/lib/slast_index_of_row.native.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js b/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js index 4281afb8499e..f4b256723b84 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js @@ -49,7 +49,7 @@ var ndarray = require( './ndarray.js' ); * @param {Collection} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) +* @throws {RangeError} fifth argument must be a valid stride * @returns {integer} row index * * @example diff --git a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js index fb6afa9883e4..9dd36f8c4d37 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js +++ b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js @@ -49,7 +49,7 @@ var ndarray = require( './ndarray.js' ); * @param {Uint8Array} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) +* @throws {RangeError} fifth argument must be a valid stride * @returns {integer} row index * * @example diff --git a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js index 36d2f1f408ef..d86e13939442 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js @@ -43,7 +43,7 @@ var addon = require( './../src/addon.node' ); * @param {Uint8Array} workspace - workspace array for tracking row match candidates * @param {integer} strideW - stride length for `workspace` * @throws {TypeError} first argument must be a valid order -* @throws {RangeError} fifth argument must be greater than or equal to max(1,N) +* @throws {RangeError} fifth argument must be a valid stride * @returns {integer} row index * * @example