From ac2c6873acc070c7337acda179c2a3400c7e427a Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 5 Aug 2026 01:01:58 +0000 Subject: [PATCH] test: migrate `math/base/special/hypot` to ULP-based assertions Resolves a part of #11352. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/math/base/special/hypot/test/test.js | 13 ++----------- .../math/base/special/hypot/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/hypot/test/test.js b/lib/node_modules/@stdlib/math/base/special/hypot/test/test.js index 333a95638dce..30bd4c9f4834 100644 --- a/lib/node_modules/@stdlib/math/base/special/hypot/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/hypot/test/test.js @@ -23,12 +23,11 @@ var tape = require( 'tape' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var sqrt = require( '@stdlib/math/base/special/sqrt' ); var pow = require( '@stdlib/math/base/special/pow' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var hypot = require( './../lib' ); @@ -122,8 +121,6 @@ tape( 'the function returns `+0` if both arguments are `+-0`', function test( t tape( 'the function computes the hypotenuse', function test( t ) { var expected; - var delta; - var tol; var h; var x; var y; @@ -135,13 +132,7 @@ tape( 'the function computes the hypotenuse', function test( t ) { for ( i = 0; i < x.length; i++ ) { h = hypot( x[ i ], y[ i ] ); - if ( h === expected[ i ] ) { - t.ok( true, 'x: '+x[i]+'. y: '+y[i]+'. h: '+h+'. Expected: '+expected[i]+'.' ); - } else { - delta = abs( h - expected[ i ] ); - tol = 1.4 * EPS * abs( expected[ i ] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y[i]+'. h: '+h+'. Expected: '+expected[i]+'. Delta: '+delta+'. Tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( h, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/hypot/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/hypot/test/test.native.js index 1df944589124..7cddd0ad85f5 100644 --- a/lib/node_modules/@stdlib/math/base/special/hypot/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/hypot/test/test.native.js @@ -24,12 +24,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var sqrt = require( '@stdlib/math/base/special/sqrt' ); var pow = require( '@stdlib/math/base/special/pow' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -131,8 +130,6 @@ tape( 'the function returns `+0` if both arguments are `+-0`', opts, function te tape( 'the function computes the hypotenuse', opts, function test( t ) { var expected; - var delta; - var tol; var h; var x; var y; @@ -144,13 +141,7 @@ tape( 'the function computes the hypotenuse', opts, function test( t ) { for ( i = 0; i < x.length; i++ ) { h = hypot( x[ i ], y[ i ] ); - if ( h === expected[ i ] ) { - t.ok( true, 'x: '+x[i]+'. y: '+y[i]+'. h: '+h+'. Expected: '+expected[i]+'.' ); - } else { - delta = abs( h - expected[ i ] ); - tol = 1.4 * EPS * abs( expected[ i ] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y[i]+'. h: '+h+'. Expected: '+expected[i]+'. Delta: '+delta+'. Tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( h, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });