feat: add utils/any-in-by
#1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Feb 28, 2024
Contributor
stdlib-bot
left a comment
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
3 tasks
Planeshifter
requested changes
Mar 2, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for this PR! Left some comments that will need to be addressed before this can be merged.
Planeshifter
added
the
Needs Changes
Planeshifter
changed the title
utils/any-in-by
Contributor
Author
|
@Planeshifter I have resolved all the problems. |
Planeshifter
reviewed
Mar 3, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
It's coming along well, but I noticed we are still missing some tests. Would you be able to please add these?
Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com>
Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com>
Contributor
Author
|
@Planeshifter I have fixed the typo and I have added 3 tests where:
|
Planeshifter
approved these changes
Mar 5, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this contribution!
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1411 Closes: stdlib-js#823 --------- Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #823
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers