Skip to content

Conversation

@bad-in-coding
Copy link
Contributor

Resolves #1323 .

Description

What is the purpose of this pull request?

This pull request adds the package @stdlib/array/base/mskreject-map.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add @stdlib/array/base/mskreject-map feat: add array/base/mskreject-map Mar 3, 2024
@Planeshifter Planeshifter self-requested a review March 3, 2024 13:46
@Planeshifter
Copy link
Member

@Ut-the-pro Would you mind looking into and fixing the lint failures first, please? (see failing CI checks)
Thanks!

@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Mar 3, 2024
@bad-in-coding
Copy link
Contributor Author

bad-in-coding commented Mar 4, 2024

@Planeshifter I am unable to figure out why it is showing lint error (in CI checks) for Unexpected 'this' in test.assign.js. Can you please suggest the change. Thanks.

@Planeshifter
Copy link
Member

@Ut-the-pro If this is needed for the tests, you can disable the lint rule via either // eslint-disable-line no-invalid-this at the end of the offending line or // eslint-disable-next-line no-invalid-this.

@bad-in-coding
Copy link
Contributor Author

@Planeshifter Can you please review it :)

@bad-in-coding
Copy link
Contributor Author

@Planeshifter I got a mail with some suggested changes in README but I don't see it here. Should I apply those changes???

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in; thank you @Ut-the-pro!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 26, 2024
@Planeshifter Planeshifter merged commit 8b7f927 into stdlib-js:develop Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/mskreject-map

2 participants