refactor: update blas/ext/base/ssumkbn2 to follow current project conventions
#1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Hello @Planeshifter and @kgryte, I'd appreciate your review of my pull request (#1749) whenever you have a moment. Thank you! |
Planeshifter
added
Needs Review
Planeshifter
changed the title
blas/ext/base/ssumkbn2 to follow current project conventions
Contributor
Author
|
Hi @Planeshifter @Pranavchiku and @kgryte, just checking in on my pull request (#1749). Would you mind reviewing it when you get a chance? |
Contributor
Author
|
@Planeshifter any updates of reviews? |
Pranavchiku
reviewed
Mar 12, 2024
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumkbn2/examples/index.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumkbn2/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
suggested changes
Mar 12, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Missing changes in docs/types, requested few changes.
Pranavchiku
added
Needs Changes
Contributor
Author
|
@kgryte @Planeshifter @Pranavchiku Could u review it for any other issues or changes? |
kgryte
reviewed
Mar 13, 2024
Contributor
Author
|
@kgryte I am closing this pr as there is an issue in my forked repository and will make a new pr soon. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ventions
Resolves # .
Description
This pull request refactors the
@stdlib/blas/ext/ssumkbn2to follow current project conventionsRelated Issues
This pull request:
blas/ext/base/ssumkbn2to follow current project conventions #1542Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers