Skip to content

feat: add C implementation for math/base/special/xlogy #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Planeshifter merged 7 commits into from
Mar 12, 2024
Merged

feat: add C implementation for math/base/special/xlogy #1827

Planeshifter merged 7 commits into from
Mar 12, 2024

Conversation

@performant23
Copy link
Contributor

@performant23 performant23 commented Mar 11, 2024

This commit if applied adds the C implementation to @stdlib/math/base/special/xlogy package

Description

What is the purpose of this pull request?
Add C implementation to to @stdlib/math/base/special/xlogy package

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

performant23 and others added 3 commits March 11, 2024 18:17
@performant23
feat: add C implementation for @stdlib/math/base/special/xlogy
2a49798 
This commit if applied adds the C implementation to @stdlib/math/base/special/xlogy package
@performant23
Update main.c - 'stdlib_base_isnan' -> 'stdlib_base_is_nan'
263cb6f 
Signed-off-by: Rutam <138517416+performant23@users.noreply.github.com>
@performant23
feat: change file configuration for the header file
c9a64c0
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/xlogy feat: add C implementation for math/base/special/xlogy Mar 11, 2024
performant23 and others added 2 commits March 11, 2024 18:37
@performant23
Merge branch 'feature/add-C-implementation-for-math/base/special/xlog…
68ff6da 
…y' of https://github.com/performant23/stdlib into feature/add-C-implementation-for-math/base/special/xlogy
@performant23
Update benchmark.c - variable usage revision
6bf6229 
Signed-off-by: Rutam <138517416+performant23@users.noreply.github.com>
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
@Pranavchiku
chore: apply suggestions from code review
20aaa17 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
e4cc1e4 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me. Thanks @performant23 !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 12, 2024
@Planeshifter Planeshifter merged commit 665c735 into stdlib-js:develop Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

+1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for math/base/special/xlogy

3 participants

@performant23 @Planeshifter @Pranavchiku