Skip to content

feat: add C implementation for math/base/special/fast/atanh #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Planeshifter merged 10 commits into from
Mar 17, 2024
Merged

feat: add C implementation for math/base/special/fast/atanh #1909

Planeshifter merged 10 commits into from
Mar 17, 2024

Conversation

@kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 16, 2024 •
edited
Loading

Resolves a part of #1917 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/fast/atanh

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 16, 2024
Pranavchiku
Pranavchiku reviewed Mar 16, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 16, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 16, 2024
View reviewed changes
Pranavchiku
Pranavchiku suggested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 16, 2024
@Pranavchiku
Copy link
Member

Pranavchiku commented Mar 16, 2024 •
edited
Loading

Please make PR title as "feat: add C implementation for math/base/special/fast/atanh"

@kawaho2 kawaho2 changed the title feat: add C implementation for math/base/special/fast/atanh feat: feat: add C implementation for math/base/special/fast/atanh Mar 16, 2024
kawaho2 added 8 commits March 16, 2024 19:10
@kawaho2
Update README.md
d725edc 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update example.c
9ff0412 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update README.md
01767a7 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update atanh.h
d70b1da 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update main.c
84543b3 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update manifest.json
6e67005 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update README.md
bdfbeed 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update README.md
4d3bd37 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2 kawaho2 requested a review from Pranavchiku March 16, 2024 14:15
@kawaho2
Copy link
Contributor Author

kawaho2 commented Mar 16, 2024

@Pranavchiku I have addressed all the issues

@kawaho2 kawaho2 changed the title feat: feat: add C implementation for math/base/special/fast/atanh feat: feat: add C implementation for math/base/special/fast/atanh Mar 16, 2024
@gunjjoshi gunjjoshi mentioned this pull request Mar 16, 2024
Closed
14 tasks
Pranavchiku
Pranavchiku reviewed Mar 17, 2024
View reviewed changes
@Pranavchiku
chore: apply suggestions from code review
b007689 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku changed the title feat: feat: add C implementation for math/base/special/fast/atanh feat: add C implementation for math/base/special/fast/atanh Mar 17, 2024
@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 17, 2024
@kawaho2 kawaho2 mentioned this pull request Mar 17, 2024
Closed
1 task
@Planeshifter Planeshifter merged commit 7556fd8 into stdlib-js:develop Mar 17, 2024
@kawaho2 kawaho2 deleted the atanh2 branch March 17, 2024 20:05
@kawaho2 kawaho2 mentioned this pull request Mar 18, 2024
Closed
5 tasks
@kawaho2 kawaho2 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

+1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kawaho2 @Pranavchiku @Planeshifter @stdlib-bot