-
-
Notifications
You must be signed in to change notification settings - Fork 995
refactor blas/ext/base/dcusumkbn to follow current project conventions
#2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor blas/ext/base/dcusumkbn to follow current project conventions
#2036
Conversation
… project conventions
…project conventions
…gypi & examples now uses current project conventions
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes required, once addressed this will be good to merge.
|
@Pranavchiku I've applied the suggested changes. And all the checks are now passing. |
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current addon.c implementation is incorrect.
Signed-off-by: Athan <kgryte@gmail.com>
|
No. You should not revert it. You did not update the |
Ok. Now it's clear to me. |
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you!
Resolves #1472 .
Description
This pull request:
blas/ext/base/dcusumkbnto follow the current project convention.Related Issues
This pull request:
blas/ext/base/dcusumkbnto follow current project conventions #1472Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers