From 849d02a4657080c30afb894b4635aa59028e3eae Mon Sep 17 00:00:00 2001 From: Yaswanth Kosuru Date: Tue, 3 Sep 2024 09:55:31 +0000 Subject: [PATCH 1/3] refactor: blas/ext/base/sapxsumors --- .../blas/ext/base/sapxsumors/README.md | 33 ++--- .../base/sapxsumors/benchmark/benchmark.js | 17 ++- .../sapxsumors/benchmark/benchmark.native.js | 13 +- .../sapxsumors/benchmark/benchmark.ndarray.js | 17 ++- .../benchmark/benchmark.ndarray.native.js | 13 +- .../blas/ext/base/sapxsumors/docs/repl.txt | 5 +- .../ext/base/sapxsumors/examples/index.js | 13 +- .../blas/ext/base/sapxsumors/include.gypi | 2 +- .../blas/ext/base/sapxsumors/lib/index.js | 6 +- .../blas/ext/base/sapxsumors/lib/ndarray.js | 3 +- .../ext/base/sapxsumors/lib/ndarray.native.js | 9 +- .../ext/base/sapxsumors/lib/sapxsumors.js | 3 +- .../base/sapxsumors/lib/sapxsumors.native.js | 3 +- .../blas/ext/base/sapxsumors/manifest.json | 95 +++++++++---- .../blas/ext/base/sapxsumors/src/addon.c | 49 +++++++ .../blas/ext/base/sapxsumors/src/addon.cpp | 130 ------------------ .../ext/base/sapxsumors/test/test.ndarray.js | 13 +- .../sapxsumors/test/test.ndarray.native.js | 13 +- .../base/sapxsumors/test/test.sapxsumors.js | 13 +- .../sapxsumors/test/test.sapxsumors.native.js | 13 +- 20 files changed, 182 insertions(+), 281 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c delete mode 100644 lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.cpp diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/README.md index 53d348dcac55..e32f41cfc8d0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/README.md @@ -44,9 +44,8 @@ Adds a constant to each single-precision floating-point strided array element an var Float32Array = require( '@stdlib/array/float32' ); var x = new Float32Array( [ 1.0, -2.0, 2.0 ] ); -var N = x.length; -var v = sapxsumors( N, 5.0, x, 1 ); +var v = sapxsumors( x.length, 5.0, x, 1 ); // returns 16.0 ``` @@ -56,16 +55,14 @@ The function has the following parameters: - **x**: input [`Float32Array`][@stdlib/array/float32]. - **stride**: index increment for `x`. -The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to access every other element in `x`, +The `N` and `stride` parameters determine which elements in the strided array are accessed at runtime. For example, to access every other element in `x`, ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float32Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); -var N = floor( x.length / 2 ); -var v = sapxsumors( N, 5.0, x, 2 ); +var v = sapxsumors( 4, 5.0, x, 2 ); // returns 25.0 ``` @@ -75,14 +72,11 @@ Note that indexing is relative to the first index. To introduce an offset, use [ ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x0 = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var N = floor( x0.length / 2 ); - -var v = sapxsumors( N, 5.0, x1, 2 ); +var v = sapxsumors( 4, 5.0, x1, 2 ); // returns 25.0 ``` @@ -94,9 +88,8 @@ Adds a constant to each single-precision floating-point strided array element an var Float32Array = require( '@stdlib/array/float32' ); var x = new Float32Array( [ 1.0, -2.0, 2.0 ] ); -var N = x.length; -var v = sapxsumors.ndarray( N, 5.0, x, 1, 0 ); +var v = sapxsumors.ndarray( x.length, 5.0, x, 1, 0 ); // returns 16.0 ``` @@ -108,12 +101,10 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -var N = floor( x.length / 2 ); -var v = sapxsumors.ndarray( N, 5.0, x, 2, 1 ); +var v = sapxsumors.ndarray( 4, 5.0, x, 2, 1 ); // returns 25.0 ``` @@ -139,18 +130,12 @@ var v = sapxsumors.ndarray( N, 5.0, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var Float32Array = require( '@stdlib/array/float32' ); var sapxsumors = require( '@stdlib/blas/ext/base/sapxsumors' ); -var x; -var i; - -x = new Float32Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( randu()*100.0 ); -} +var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 )); console.log( x ); var v = sapxsumors( x.length, 5.0, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.js index ddaf65c56983..e2e536267536 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var pkg = require( './../package.json' ).name; var sapxsumors = require( './../lib/sapxsumors.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,13 +44,7 @@ var sapxsumors = require( './../lib/sapxsumors.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.native.js index b101e4960c80..b234d22157b4 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var sapxsumors = tryRequire( resolve( __dirname, './../lib/sapxsumors.native.js' var opts = { 'skip': ( sapxsumors instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.js index e43327c820f7..ded8d1ca0f61 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var pkg = require( './../package.json' ).name; var sapxsumors = require( './../lib/ndarray.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,13 +44,7 @@ var sapxsumors = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.native.js index 792f4549b43a..6a005e1a62cd 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/benchmark/benchmark.ndarray.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var sapxsumors = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) var opts = { 'skip': ( sapxsumors instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/docs/repl.txt index 55fb69ca9791..1936cee0559d 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/docs/repl.txt @@ -3,8 +3,8 @@ Adds a constant to each single-precision floating-point strided array element and computes the sum using ordinary recursive summation. - The `N` and `stride` parameters determine which elements in `x` are accessed - at runtime. + The `N` and `stride` parameters determine which elements in the strided + array are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed array view. @@ -52,6 +52,7 @@ > {{alias}}( N, 5.0, x1, stride ) 14.0 + {{alias}}.ndarray( N, alpha, x, stride, offset ) Adds a constant to each single-precision floating-point strided array element and computes the sum using ordinary recursive summation and diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/examples/index.js index c411056e7b75..d79569cc0357 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/examples/index.js @@ -18,18 +18,11 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float32Array = require( '@stdlib/array/float32' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var sapxsumors = require( './../lib' ); -var x; -var i; - -x = new Float32Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( randu()*100.0 ); -} +var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); console.log( x ); var v = sapxsumors( x.length, 5.0, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/include.gypi b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/include.gypi +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' +#include + +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_DOUBLE( env, alpha, argv, 1) + STDLIB_NAPI_ARGV_INT64( env, stride, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, stride, argv, 2 ); + + napi_value v; + napi_status status = napi_create_double( env, stdlib_strided_sapxsumors( N, alpha, X, stride ), &v ); + assert( status == napi_ok ); + + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.cpp b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.cpp deleted file mode 100644 index 6db26f95885b..000000000000 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.cpp +++ /dev/null @@ -1,130 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/blas/ext/base/sapxsumors.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_blas_ext_base_sapxsumors { - - /** - * Adds a constant to each single-precision floating-point strided array element and computes the sum using ordinary recursive summation. - * - * ## Notes - * - * - When called from JavaScript, the function expects four arguments: - * - * - `N`: number of indexed elements - * - `alpha`: constant - * - `X`: input array - * - `stride`: stride length - */ - napi_value node_sapxsumors( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 4; - napi_value argv[ 4 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 4 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 4 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - napi_valuetype vtype1; - status = napi_typeof( env, argv[ 1 ], &vtype1 ); - assert( status == napi_ok ); - if ( vtype1 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a number." ); - return nullptr; - } - - bool res; - status = napi_is_typedarray( env, argv[ 2 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float32Array." ); - return nullptr; - } - - napi_valuetype vtype3; - status = napi_typeof( env, argv[ 3 ], &vtype3 ); - assert( status == napi_ok ); - if ( vtype3 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Fourth argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - double alpha; - status = napi_get_value_double( env, argv[ 1 ], &alpha ); - assert( status == napi_ok ); - - int64_t stride; - status = napi_get_value_int64( env, argv[ 3 ], &stride ); - assert( status == napi_ok ); - - napi_typedarray_type vtype2; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 2 ], &vtype2, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype2 != napi_float32_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float32Array." ); - return nullptr; - } - if ( (N-1)*llabs(stride) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Third argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_value v; - status = napi_create_double( env, stdlib_strided_sapxsumors( N, (float)alpha, (float *)X, stride ), &v ); - assert( status == napi_ok ); - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_sapxsumors, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_blas_ext_base_sapxsumors diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.js index a04f6310aec3..1c74fa313a42 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sapxsumors = require( './../lib/ndarray.js' ); @@ -95,7 +94,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -110,15 +108,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2, 0 ); + v = sapxsumors( 4, 5.0, x, 2, 0 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -133,8 +129,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, -2, 6 ); + v = sapxsumors( 4, 5.0, x, -2, 6 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -153,7 +148,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', function test( t ) { - var N; var x; var v; @@ -167,9 +161,8 @@ tape( 'the function supports an `offset` parameter', function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2, 1 ); + v = sapxsumors( 4, 5.0, x, 2, 1 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.native.js index 54c4b2fec1bc..0f84db8210cd 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.ndarray.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -104,7 +103,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -119,15 +117,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2, 0 ); + v = sapxsumors( 4, 5.0, x, 2, 0 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -142,8 +138,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, -2, 6 ); + v = sapxsumors( 4, 5.0, x, -2, 6 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -162,7 +157,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', opts, function test( t ) { - var N; var x; var v; @@ -176,9 +170,8 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2, 1 ); + v = sapxsumors( 4, 5.0, x, 2, 1 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.js index f3d3dd3885b9..a86cf7172505 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sapxsumors = require( './../lib/sapxsumors.js' ); @@ -95,7 +94,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -110,15 +108,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2 ); + v = sapxsumors( 4, 5.0, x, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -133,8 +129,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, -2 ); + v = sapxsumors( 4, 5.0, x, -2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -155,7 +150,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', function test( t ) { var x0; var x1; - var N; var v; x0 = new Float32Array([ @@ -171,9 +165,8 @@ tape( 'the function supports view offsets', function test( t ) { ]); x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = sapxsumors( N, 5.0, x1, 2 ); + v = sapxsumors( 4, 5.0, x1, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.native.js index e648072b1079..da0f4b3a91e9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/test/test.sapxsumors.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -213,7 +212,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -228,15 +226,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, 2 ); + v = sapxsumors( 4, 5.0, x, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -251,8 +247,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = sapxsumors( N, 5.0, x, -2 ); + v = sapxsumors( 4, 5.0, x, -2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -273,7 +268,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', opts, function test( t ) { var x0; var x1; - var N; var v; x0 = new Float32Array([ @@ -289,9 +283,8 @@ tape( 'the function supports view offsets', opts, function test( t ) { ]); x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = sapxsumors( N, 5.0, x1, 2 ); + v = sapxsumors( 4, 5.0, x1, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); From 8ec841fd188481c487eb948e3baf6b3b6e6018c8 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 3 Sep 2024 17:41:43 -0400 Subject: [PATCH 2/3] chore: fix indentation in manifest.json Signed-off-by: Philipp Burckhardt --- .../blas/ext/base/sapxsumors/manifest.json | 72 +++++++++---------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/manifest.json index ee1dc00de038..fb4c953488fc 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/manifest.json @@ -24,19 +24,19 @@ "relative": false } ], - "confs": [ - { + "confs": [ + { "task": "build", - "src": [ - "./src/sapxsumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], + "src": [ + "./src/sapxsumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", @@ -44,19 +44,19 @@ "@stdlib/napi/argv-double", "@stdlib/napi/argv-strided-float32array" ] - }, + }, { "task": "benchmark", - "src": [ - "./src/sapxsumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], + "src": [ + "./src/sapxsumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", @@ -64,19 +64,19 @@ "@stdlib/napi/argv-double", "@stdlib/napi/argv-strided-float32array" ] - }, + }, { "task": "examples", - "src": [ - "./src/sapxsumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], + "src": [ + "./src/sapxsumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", @@ -84,6 +84,6 @@ "@stdlib/napi/argv-double", "@stdlib/napi/argv-strided-float32array" ] - } - ] + } + ] } From cc1ad9da7a25e6ff6114c62cdcae577857d63b2e Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 3 Sep 2024 17:43:00 -0400 Subject: [PATCH 3/3] style: fix code style Signed-off-by: Philipp Burckhardt --- lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c index a330aef3a7c6..49b6e557ae01 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/sapxsumors/src/addon.c @@ -35,7 +35,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); - STDLIB_NAPI_ARGV_DOUBLE( env, alpha, argv, 1) + STDLIB_NAPI_ARGV_DOUBLE( env, alpha, argv, 1 ); STDLIB_NAPI_ARGV_INT64( env, stride, argv, 3 ); STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, stride, argv, 2 );