From b20e724bac4d8b469d3987cbf15e9466e573efb0 Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Thu, 9 Jan 2025 23:10:18 +0530 Subject: [PATCH 1/3] feat: add C implementation for triangular logpdf --- .../base/dists/triangular/logpdf/README.md | 103 +++++++++ .../triangular/logpdf/benchmark/benchmark.js | 21 +- .../logpdf/benchmark/benchmark.native.js | 78 +++++++ .../triangular/logpdf/benchmark/c/Makefile | 146 ++++++++++++ .../triangular/logpdf/benchmark/c/benchmark.c | 145 ++++++++++++ .../base/dists/triangular/logpdf/binding.gyp | 170 ++++++++++++++ .../triangular/logpdf/examples/c/Makefile | 146 ++++++++++++ .../triangular/logpdf/examples/c/example.c | 46 ++++ .../base/dists/triangular/logpdf/include.gypi | 53 +++++ .../stats/base/dists/triangular/logpdf.h | 38 +++ .../dists/triangular/logpdf/lib/native.js | 81 +++++++ .../dists/triangular/logpdf/manifest.json | 90 ++++++++ .../base/dists/triangular/logpdf/package.json | 11 +- .../base/dists/triangular/logpdf/src/Makefile | 70 ++++++ .../base/dists/triangular/logpdf/src/addon.c | 23 ++ .../base/dists/triangular/logpdf/src/main.c | 63 +++++ .../triangular/logpdf/test/test.native.js | 216 ++++++++++++++++++ 17 files changed, 1489 insertions(+), 11 deletions(-) create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/benchmark.native.js create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/benchmark.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/binding.gyp create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/examples/c/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/examples/c/example.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include.gypi create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include/stdlib/stats/base/dists/triangular/logpdf.h create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/lib/native.js create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/manifest.json create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/src/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/src/addon.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/src/main.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.native.js diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md index 24706c185e2f..692ac11b824e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md @@ -158,6 +158,109 @@ for ( i = 0; i < 25; i++ ) { + + +
+ + + +* * * + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/stats/base/dists/geometric/logpdf.h" +``` + +#### stdlib_base_dists_geometric_logpdf( x, a, b, c ) + +Evaluates the natural logarithm of the [probability density function][pdf] (PDF) for a [triangular][triangular-distribution] distribution with parameters `a` (lower limit), `b` (upper limit) and `c` (mode). + +```c +double y = stdlib_base_dists_geometric_logpdf( 0.5, -1.0, 1.0, 0.0 ); +// returns ~-0.693 +``` + +The function accepts the following arguments: + +- **x**: `[in] double` input value. +- **a**: `[in] double` lower limit +- **b**: `[in] double` upper limit +- **c**: `[in] double` mode + +```c +double stdlib_base_dists_geometric_logpdf( const double x, const double a, const double b, const double c ); +``` + +
+ + + + + +
+ +
+ + + + + +
+ +### Examples + +```c +#include "stdlib/stats/base/dists/triangular/logpdf.h" +#include "stdlib/constants/float64/eps.h" +#include +#include +#include + +static double random_uniform( const double min, const double max ) { + double v = (double)rand() / ( (double)RAND_MAX + 1.0 ); + return min + ( v*(max-min) ); +} + +int main( void ) { + double a; + double b; + double c; + double x; + double y; + int i; + + for ( i = 0; i < 25; i++ ) { + x = random_uniform( 0.0, 30.0 ); + a = random_uniform( 0.0, 10.0 ); + b = random_uniform( a, 40.0 ) + STDLIB_CONSTANT_FLOAT64_EPS; + c = a + random_uniform( 0.0, b - a ); + y = stdlib_base_dists_triangular_logpdf( x, a, b, c ); + printf( "x: %lf, a: %lf, b: %lf, c: %lf, ln(f(x;a,b,c)): %lf\n", x, a, b, c, y ); + } +} +``` + +
+ + + diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include/stdlib/stats/base/dists/triangular/logpdf.h b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include/stdlib/stats/base/dists/triangular/logpdf.h index 3f4a7ba3e11b..1f03803b9c94 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include/stdlib/stats/base/dists/triangular/logpdf.h +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/include/stdlib/stats/base/dists/triangular/logpdf.h @@ -27,7 +27,7 @@ extern "C" { #endif /** -* Evaluates the natural logarithm of the probability density function (PDF) for the triangular distribution with parameters a, b, and c. +* Evaluates the natural logarithm of the probability density function (PDF) for a triangular distribution with lower limit `a` and upper limit `b` and mode `c` at a value `x`. */ double stdlib_base_dists_triangular_logpdf( const double x, const double a, const double b, const double c ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/package.json b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/package.json index 1c9d32bea456..967b3d6131cb 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/package.json +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/package.json @@ -1,7 +1,7 @@ { - "name": "@stdlib/stats/base/dists/triangular/pdf", + "name": "@stdlib/stats/base/dists/triangular/logpdf", "version": "0.0.0", - "description": "Triangular distribution probability density function (PDF).", + "description": "Triangular distribution logarithm of probability density function (PDF).", "license": "Apache-2.0", "author": { "name": "The Stdlib Authors", @@ -61,6 +61,10 @@ "probability", "pdf", "continuous", + "logarithm", + "log", + "ln", + "natural", "triangular", "univariate" ] From 6e71faab22f303330f83bb6e34188c15dd6eaecc Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 19 Jan 2025 09:49:38 -0500 Subject: [PATCH 3/3] chore: apply suggestions from code review Signed-off-by: Philipp Burckhardt --- .../@stdlib/stats/base/dists/triangular/logpdf/README.md | 8 ++++---- .../base/dists/triangular/logpdf/benchmark/c/benchmark.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md index 73682c35c8a9..a0a91873cce5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md @@ -200,9 +200,9 @@ double y = stdlib_base_dists_triangular_logpdf( 0.5, -1.0, 1.0, 0.0 ); The function accepts the following arguments: - **x**: `[in] double` input value. -- **a**: `[in] double` lower limit -- **b**: `[in] double` upper limit -- **c**: `[in] double` mode +- **a**: `[in] double` lower limit. +- **b**: `[in] double` upper limit. +- **c**: `[in] double` mode. ```c double stdlib_base_dists_triangular_logpdf( const double x, const double a, const double b, const double c ); @@ -249,7 +249,7 @@ int main( void ) { for ( i = 0; i < 25; i++ ) { x = random_uniform( 0.0, 30.0 ); a = random_uniform( 0.0, 10.0 ); - b = random_uniform( a, 40.0 ) + STDLIB_CONSTANT_FLOAT64_EPS; + b = random_uniform( a + STDLIB_CONSTANT_FLOAT64_EPS, 40.0 ); c = a + random_uniform( 0.0, b - a ); y = stdlib_base_dists_triangular_logpdf( x, a, b, c ); printf( "x: %lf, a: %lf, b: %lf, c: %lf, ln(f(x;a,b,c)): %lf\n", x, a, b, c, y ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/benchmark.c index 8e3e0b1089c7..f84f024dbb8c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/c/benchmark.c @@ -105,7 +105,7 @@ static double benchmark( void ) { for ( i = 0; i < 100; i++ ) { x[ i ] = random_uniform( 0.0, 30.0 ); a[ i ] = random_uniform( 0.0, 10.0 ); - b[ i ] = random_uniform( a[ i ], 40.0 ) + STDLIB_CONSTANT_FLOAT64_EPS; + b[ i ] = random_uniform( a[ i ] + STDLIB_CONSTANT_FLOAT64_EPS, 40.0 ); c[ i ] = a[ i ] + random_uniform( 0.0, b[ i ] - a[ i ] ); }