From b21300ab861adbdea7c1efce6fd2c07586ef3eb5 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Thu, 30 Jan 2025 08:06:45 +0000 Subject: [PATCH 01/11] feat: add accessor arrays support --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../@stdlib/blas/ext/base/gcusumkbn/README.md | 3 + .../ext/base/gcusumkbn/docs/types/index.d.ts | 16 +- .../ext/base/gcusumkbn/docs/types/test.ts | 7 +- .../blas/ext/base/gcusumkbn/lib/accessors.js | 107 ++++++++ .../blas/ext/base/gcusumkbn/lib/ndarray.js | 7 + .../blas/ext/base/gcusumkbn/test/test.main.js | 195 ++++++++++++-- .../ext/base/gcusumkbn/test/test.ndarray.js | 237 ++++++++++++++++-- 7 files changed, 531 insertions(+), 41 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/README.md b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/README.md index f7d91d8a1853..9c44df6e96b1 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/README.md @@ -128,6 +128,7 @@ gcusumkbn.ndarray( 4, 0.0, x, 2, 1, y, -1, y.length-1 ); ## Notes - If `N <= 0`, both functions return `y` unchanged. +- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]) - Depending on the environment, the typed versions ([`dcusum`][@stdlib/blas/ext/base/dcusum], [`scusum`][@stdlib/blas/ext/base/scusum], etc.) are likely to be significantly more performant. @@ -198,6 +199,8 @@ console.log( y ); [mdn-typed-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray +[@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor + [@stdlib/blas/ext/base/dcusum]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/base/dcusum [@stdlib/blas/ext/base/scusum]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/base/scusum diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts index 03a5c842cccc..f4cdee13b1b7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts @@ -20,7 +20,17 @@ /// -import { NumericArray } from '@stdlib/types/array'; +import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array'; + +/** +* Input array. +*/ +type InputArray = NumericArray | Collection | AccessorArrayLike; + +/** +* Input array. +*/ +type OutputArray = NumericArray | Collection | AccessorArrayLike; /** * Interface describing `gcusumkbn`. @@ -44,7 +54,7 @@ interface Routine { * gcusumkbn( x.length, 0.0, x, 1, y, 1 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ( N: number, sum: number, x: NumericArray, strideX: number, y: NumericArray, strideY: number ): NumericArray; + ( N: number, sum: number, x: InputArray, strideX: number, y: OutputArray, strideY: number ): OutputArray; /** * Computes the cumulative sum of strided array elements using an improved Kahan–Babuška algorithm and alternative indexing semantics. @@ -66,7 +76,7 @@ interface Routine { * gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ndarray( N: number, sum: number, x: NumericArray, strideX: number, offsetX: number, y: NumericArray, strideY: number, offsetY: number ): NumericArray; + ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: OutputArray, strideY: number, offsetY: number ): OutputArray; } /** diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts index 933e945c3e1b..581798d1e6ca 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts @@ -16,6 +16,7 @@ * limitations under the License. */ +import AccessorArray = require( '@stdlib/array/base/accessor' ); import gcusumkbn = require( './index' ); @@ -26,7 +27,8 @@ import gcusumkbn = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn( x.length, 0.0, x, 1, y, 1 ); // $ExpectType NumericArray + gcusumkbn( x.length, 0.0, x, 1, y, 1 ); // $ExpectType OutputArray + gcusumkbn( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType OutputArray } // The compiler throws an error if the function is provided a first argument which is not a number... @@ -139,7 +141,8 @@ import gcusumkbn = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType NumericArray + gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType OutputArray + gcusumkbn.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType OutputArray } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js new file mode 100644 index 000000000000..2891334e16db --- /dev/null +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js @@ -0,0 +1,107 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var abs = require( '@stdlib/math/base/special/abs' ); + + +// MAIN // + +/** +* Computes the cumulative sum of strided array elements using an improved Kahan–Babuška algorithm. +* +* ## Method +* +* - This implementation uses an "improved Kahan–Babuška algorithm", as described by Neumaier (1974). +* +* ## References +* +* - Neumaier, Arnold. 1974. "Rounding Error Analysis of Some Methods for Summing Finite Sums." _Zeitschrift Für Angewandte Mathematik Und Mechanik_ 54 (1): 39–51. doi:[10.1002/zamm.19740540106](https://doi.org/10.1002/zamm.19740540106). +* +* @private +* @param {PositiveInteger} N - number of indexed elements +* @param {number} sum - initial sum +* @param {Object} x - input array object +* @param {Collection} x.data - input array data +* @param {Array} x.accessors - array element accessors +* @param {integer} strideX - stride length for `x` +* @param {NonNegativeInteger} offsetX - starting index for `x` +* @param {Object} y - output array object +* @param {Collection} y.data - output array data +* @param {Array} y.accessors - array element accessors +* @param {integer} strideY - stride length for `y` +* @param {NonNegativeInteger} offsetY - starting index for `y` +* @returns {Object} output array object +* +* @example +* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); +* var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); +* +* var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); +* var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); +* +* gcusumkbn( 4, 5.0, arraylike2object( x ), 2, 1 ); +*/ +function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { + var xbuf; + var ybuf; + var get; + var set; + var ix; + var iy; + var s; + var v; + var t; + var c; + var i; + + // Cache reference to array data: + xbuf = x.data; + ybuf = y.data; + + // Cache reference to the element accessors: + get = x.accessors[ 0 ]; + set = x.accessors[ 1 ]; + + ix = offsetX; + iy = offsetY; + s = sum; + c = 0.0; + for ( i = 0; i < N; i++ ) { + v = get( xbuf, ix ); + t = s + v; + if ( abs( s ) >= abs( v ) ) { + c += (s-t) + v; + } else { + c += (v-t) + s; + } + s = t; + set( ybuf, iy, s + c ); + ix += strideX; + iy += strideY; + } + return y; +} + + +// EXPORTS // + +module.exports = gcusumkbn; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js index 346e4d33317f..70282f7f06e3 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js @@ -20,7 +20,9 @@ // MODULES // +var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); var abs = require( '@stdlib/math/base/special/abs' ); +var accessors = require( './accessors.js' ); // MAIN // @@ -60,11 +62,16 @@ function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var v; var t; var c; + var o; var i; if ( N <= 0 ) { return y; } + o = arraylike2object( x ); + if ( o.accessorProtocol ) { + return accessors( N, sum, x, strideX, offsetX, y, strideY, offsetY ); + } ix = offsetX; iy = offsetY; s = sum; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.main.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.main.js index 3305aab96ec0..637e53c8e985 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.main.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var Float64Array = require( '@stdlib/array/float64' ); var gcusumkbn = require( './../lib' ); @@ -128,6 +128,94 @@ tape( 'the function computes the cumulative sum', function test( t ) { t.end(); }); +tape( 'the function computes the cumulative sum (accessors)', function test( t ) { + var expected; + var x; + var y; + var i; + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + expected = [ + 1.0, + 3.0, + 6.0, + 10.0, + 15.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn( x.length, 10.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + expected = [ + 11.0, + 13.0, + 16.0, + 20.0, + 25.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ NaN, NaN ]; + y = [ 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + for ( i = 0; i < y.length; i++ ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } + + x = [ 1.0, NaN, 3.0, NaN ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + expected = [ + 1.0, + NaN, + NaN, + NaN + ]; + for ( i = 0; i < y.length; i++ ) { + if ( isnan( expected[ i ] ) ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } else { + t.strictEqual( y[ i ], expected[ i ], true, 'returns expected value. i: ' + i ); + } + } + + x = [ 1.0, 1.0e100, 1.0, -1.0e100 ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + expected = [ + 1.0, + 1.0e100, + 1.0e100, + 2.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = []; + y = []; + expected = []; + for ( i = 0; i < 1e3; i++ ) { + x.push( i+1 ); + y.push( 0.0 ); + if ( i === 0 ) { + expected.push( x[ i ] ); + } else { + expected.push( expected[ i-1 ] + x[ i ] ); + } + } + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + t.deepEqual( y, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function returns a reference to the output array', function test( t ) { var out; var x; @@ -165,7 +253,6 @@ tape( 'the function supports an `x` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -181,9 +268,36 @@ tape( 'the function supports an `x` stride', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, 2, y, 1 ); + gcusumkbn( 3, 0.0, x, 2, y, 1 ); + + expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports an `x` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 2 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, + 0.0 + ]; + + gcusumkbn( 3, 0.0, toAccessorArray( x ), 2, toAccessorArray( y ), 1 ); expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; @@ -195,7 +309,6 @@ tape( 'the function supports a `y` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -211,9 +324,36 @@ tape( 'the function supports a `y` stride', function test( t ) { 0.0, 0.0 // 2 ]; - N = 3; - gcusumkbn( N, 0.0, x, 1, y, 2 ); + gcusumkbn( 3, 0.0, x, 1, y, 2 ); + + expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports a `y` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, // 1 + 3.0, // 2 + 4.0, + 5.0 + ]; + y = [ + 0.0, // 0 + 0.0, + 0.0, // 1 + 0.0, + 0.0 // 2 + ]; + + gcusumkbn( 3, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 2 ); expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; @@ -225,7 +365,6 @@ tape( 'the function supports negative strides', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 2 @@ -241,9 +380,36 @@ tape( 'the function supports negative strides', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, -2, y, -1 ); + gcusumkbn( 3, 0.0, x, -2, y, -1 ); + + expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports negative strides (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 2 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 0 + ]; + y = [ + 0.0, // 2 + 0.0, // 1 + 0.0, // 0 + 0.0, + 0.0 + ]; + + gcusumkbn( 3, 0.0, toAccessorArray( x ), -2, toAccessorArray( y ), -1 ); expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; @@ -255,7 +421,6 @@ tape( 'the function supports complex access patterns', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -273,9 +438,8 @@ tape( 'the function supports complex access patterns', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, 2, y, -1 ); + gcusumkbn( 3, 0.0, x, 2, y, -1 ); expected = [ 9.0, 4.0, 1.0, 0.0, 0.0, 0.0 ]; @@ -289,7 +453,6 @@ tape( 'the function supports view offsets', function test( t ) { var y0; var x1; var y1; - var N; // Initial arrays... x0 = new Float64Array([ @@ -313,9 +476,7 @@ tape( 'the function supports view offsets', function test( t ) { x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // begin at 2nd element y1 = new Float64Array( y0.buffer, y0.BYTES_PER_ELEMENT*3 ); // begin at the 4th element - N = floor( x0.length / 2 ); - - gcusumkbn( N, 0.0, x1, -2, y1, 1 ); + gcusumkbn( 3, 0.0, x1, -2, y1, 1 ); expected = new Float64Array( [ 0.0, 0.0, 0.0, 6.0, 10.0, 12.0 ] ); t.deepEqual( y0, expected, 'deep equal' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.ndarray.js index cdafef11e755..570f5d7961eb 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/test/test.ndarray.js @@ -21,7 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var gcusumkbn = require( './../lib/ndarray.js' ); @@ -126,6 +126,93 @@ tape( 'the function calculates the cumulative sum', function test( t ) { t.end(); }); +tape( 'the function calculates the cumulative sum (accessors)', function test( t ) { + var expected; + var x; + var y; + var i; + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + expected = [ + 1.0, + 3.0, + 6.0, + 10.0, + 15.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn( x.length, 10.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + expected = [ + 11.0, + 13.0, + 16.0, + 20.0, + 25.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ NaN, NaN ]; + y = [ 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + for ( i = 0; i < y.length; i++ ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } + + x = [ 1.0, NaN, 3.0, NaN ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + expected = [ + 1.0, + NaN, + NaN, + NaN + ]; + for ( i = 0; i < y.length; i++ ) { + if ( isnan( expected[ i ] ) ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } else { + t.strictEqual( y[ i ], expected[ i ], true, 'returns expected value. i: ' + i ); + } + } + + x = [ 1.0, 1.0e100, 1.0, -1.0e100 ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + expected = [ + 1.0, + 1.0e100, + 1.0e100, + 2.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = []; + y = []; + expected = []; + for ( i = 0; i < 1e3; i++ ) { + x.push( i+1 ); + if ( i === 0 ) { + expected.push( x[ i ] ); + } else { + expected.push( expected[ i-1 ] + x[ i ] ); + } + } + gcusumkbn( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + t.deepEqual( y, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function returns a reference to the output array', function test( t ) { var out; var x; @@ -163,7 +250,6 @@ tape( 'the function supports an `x` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -179,9 +265,36 @@ tape( 'the function supports an `x` stride', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, 2, 0, y, 1, 0 ); + gcusumkbn( 3, 0.0, x, 2, 0, y, 1, 0 ); + + expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports an `x` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 2 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, + 0.0 + ]; + + gcusumkbn( 3, 0.0, toAccessorArray( x ), 2, 0, toAccessorArray( y ), 1, 0 ); expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; @@ -193,7 +306,6 @@ tape( 'the function supports a `y` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -209,9 +321,8 @@ tape( 'the function supports a `y` stride', function test( t ) { 0.0, 0.0 // 2 ]; - N = 3; - gcusumkbn( N, 0.0, x, 1, 0, y, 2, 0 ); + gcusumkbn( 3, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 2, 0 ); expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; @@ -223,7 +334,6 @@ tape( 'the function supports negative strides', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 2 @@ -239,9 +349,36 @@ tape( 'the function supports negative strides', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, -2, x.length-1, y, -1, 2 ); + gcusumkbn( 3, 0.0, x, -2, x.length-1, y, -1, 2 ); + + expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports negative strides (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 2 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 0 + ]; + y = [ + 0.0, // 2 + 0.0, // 1 + 0.0, // 0 + 0.0, + 0.0 + ]; + + gcusumkbn( 3, 0.0, toAccessorArray( x ), -2, x.length-1, toAccessorArray( y ), -1, 2 ); expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; @@ -251,7 +388,6 @@ tape( 'the function supports negative strides', function test( t ) { tape( 'the function supports an `x` offset', function test( t ) { var expected; - var N; var x; var y; @@ -275,9 +411,42 @@ tape( 'the function supports an `x` offset', function test( t ) { 0.0, 0.0 ]; - N = floor( x.length / 2 ); - gcusumkbn( N, 0.0, x, 2, 1, y, 1, 0 ); + gcusumkbn( 4, 0.0, x, 2, 1, y, 1, 0 ); + + expected = [ 1.0, -1.0, 1.0, 5.0, 0.0, 0.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports an `x` offset (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 2.0, + 1.0, // 0 + 2.0, + -2.0, // 1 + -2.0, + 2.0, // 2 + 3.0, + 4.0 // 3 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, // 3 + 0.0, + 0.0, + 0.0, + 0.0 + ]; + + gcusumkbn( 4, 0.0, toAccessorArray( x ), 2, 1, toAccessorArray( y ), 1, 0 ); expected = [ 1.0, -1.0, 1.0, 5.0, 0.0, 0.0, 0.0, 0.0 ]; @@ -287,7 +456,6 @@ tape( 'the function supports an `x` offset', function test( t ) { tape( 'the function supports a `y` offset', function test( t ) { var expected; - var N; var x; var y; @@ -311,9 +479,42 @@ tape( 'the function supports a `y` offset', function test( t ) { 0.0, 0.0 // 3 ]; - N = floor( x.length / 2 ); - gcusumkbn( N, 0.0, x, 1, 0, y, 2, 1 ); + gcusumkbn( 4, 0.0, x, 1, 0, y, 2, 1 ); + + expected = [ 0.0, 2.0, 0.0, 3.0, 0.0, 5.0, 0.0, 3.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a `y` offset (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 2.0, // 0 + 1.0, // 1 + 2.0, // 2 + -2.0, // 3 + -2.0, + 2.0, + 3.0, + 4.0 + ]; + y = [ + 0.0, + 0.0, // 0 + 0.0, + 0.0, // 1 + 0.0, + 0.0, // 2 + 0.0, + 0.0 // 3 + ]; + + gcusumkbn( 4, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 2, 1 ); expected = [ 0.0, 2.0, 0.0, 3.0, 0.0, 5.0, 0.0, 3.0 ]; @@ -325,7 +526,6 @@ tape( 'the function supports complex access patterns', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -343,9 +543,8 @@ tape( 'the function supports complex access patterns', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn( N, 0.0, x, 2, 0, y, -1, 2 ); + gcusumkbn( 3, 0.0, x, 2, 0, y, -1, 2 ); expected = [ 9.0, 4.0, 1.0, 0.0, 0.0, 0.0 ]; From da3e5622350b342e394ea02b06f14fd03c109a93 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Thu, 30 Jan 2025 08:25:35 +0000 Subject: [PATCH 02/11] fix: bug fix --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js | 12 ++++++------ .../@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js | 10 ++++++---- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js index 2891334e16db..af0a4897f2f5 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js @@ -63,8 +63,8 @@ var abs = require( '@stdlib/math/base/special/abs' ); function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var xbuf; var ybuf; - var get; - var set; + var xget; + var yset; var ix; var iy; var s; @@ -78,15 +78,15 @@ function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { ybuf = y.data; // Cache reference to the element accessors: - get = x.accessors[ 0 ]; - set = x.accessors[ 1 ]; + xget = x.accessors[ 0 ]; + yset = y.accessors[ 1 ]; ix = offsetX; iy = offsetY; s = sum; c = 0.0; for ( i = 0; i < N; i++ ) { - v = get( xbuf, ix ); + v = xget( xbuf, ix ); t = s + v; if ( abs( s ) >= abs( v ) ) { c += (s-t) + v; @@ -94,7 +94,7 @@ function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { c += (v-t) + s; } s = t; - set( ybuf, iy, s + c ); + yset( ybuf, iy, s + c ); ix += strideX; iy += strideY; } diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js index 70282f7f06e3..82494cb14f3a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js @@ -58,19 +58,21 @@ var accessors = require( './accessors.js' ); function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var ix; var iy; + var ox; + var oy; var s; var v; var t; var c; - var o; var i; if ( N <= 0 ) { return y; } - o = arraylike2object( x ); - if ( o.accessorProtocol ) { - return accessors( N, sum, x, strideX, offsetX, y, strideY, offsetY ); + ox = arraylike2object( x ); + oy = arraylike2object( y ); + if ( ox.accessorProtocol && oy.accessorProtocol ) { + return accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); } ix = offsetX; iy = offsetY; From e3f8c43cc6c38ba5abe6cb2c3bf21ffd7d398438 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 13:41:38 +0500 Subject: [PATCH 03/11] refactor: apply review suggestion Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js index 82494cb14f3a..e685435af0ce 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js @@ -71,7 +71,7 @@ function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { } ox = arraylike2object( x ); oy = arraylike2object( y ); - if ( ox.accessorProtocol && oy.accessorProtocol ) { + if ( ox.accessorProtocol || oy.accessorProtocol ) { return accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); } ix = offsetX; From 0d203c5434f6a2419453df869ba2461e2982f49e Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 15:07:19 +0500 Subject: [PATCH 04/11] docs: apply review suggestion Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js index af0a4897f2f5..e5df6589da45 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js @@ -58,7 +58,7 @@ var abs = require( '@stdlib/math/base/special/abs' ); * var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); * var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); * -* gcusumkbn( 4, 5.0, arraylike2object( x ), 2, 1 ); +* gcusumkbn( 4, 0.0, arraylike2object( x ), 2, 1, arraylike2object( y ), 1, 0 ); */ function gcusumkbn( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var xbuf; From ef422da076d5047de00d4bcd5f8011d4d158c764 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 1 Feb 2025 03:55:52 -0800 Subject: [PATCH 05/11] docs: fix description Signed-off-by: Athan --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts index f4cdee13b1b7..80944d8d3e84 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts @@ -28,7 +28,7 @@ import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array type InputArray = NumericArray | Collection | AccessorArrayLike; /** -* Input array. +* Output array. */ type OutputArray = NumericArray | Collection | AccessorArrayLike; From e5da0c5c17ba049065b99c2e92f862ccaf1969b5 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:00:23 +0500 Subject: [PATCH 06/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts index 80944d8d3e84..18b48df3ed27 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts @@ -54,7 +54,7 @@ interface Routine { * gcusumkbn( x.length, 0.0, x, 1, y, 1 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ( N: number, sum: number, x: InputArray, strideX: number, y: OutputArray, strideY: number ): OutputArray; + ( N: number, sum: number, x: InputArray, strideX: number, y: T, strideY: number ): T; /** * Computes the cumulative sum of strided array elements using an improved Kahan–Babuška algorithm and alternative indexing semantics. From 7fd06ef9a6ddec37f32087fdaf2f6623310a9f36 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:00:35 +0500 Subject: [PATCH 07/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts index 18b48df3ed27..7d65a852866e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts @@ -76,7 +76,7 @@ interface Routine { * gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: OutputArray, strideY: number, offsetY: number ): OutputArray; + ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: T, strideY: number, offsetY: number ): T; } /** From 194daaaf9df2b52d37659a46df2745caa79d0e3f Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:00:46 +0500 Subject: [PATCH 08/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts index 581798d1e6ca..8162e6b3ed86 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts @@ -28,7 +28,7 @@ import gcusumkbn = require( './index' ); const y = new Float64Array( 10 ); gcusumkbn( x.length, 0.0, x, 1, y, 1 ); // $ExpectType OutputArray - gcusumkbn( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType OutputArray + gcusumkbn( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType AccessorArray } // The compiler throws an error if the function is provided a first argument which is not a number... From 536c82571209267e9364b12ddb5c7798c0b67083 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:00:56 +0500 Subject: [PATCH 09/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts index 8162e6b3ed86..86ff905f5cd6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts @@ -142,7 +142,7 @@ import gcusumkbn = require( './index' ); const y = new Float64Array( 10 ); gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType OutputArray - gcusumkbn.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType OutputArray + gcusumkbn.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType AccessorArray } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... From 0dbbab6acc1f28db1ec2ad49c1d58b703f80cd05 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:03:27 +0500 Subject: [PATCH 10/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts index 86ff905f5cd6..6d22ada2c17c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts @@ -27,7 +27,7 @@ import gcusumkbn = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn( x.length, 0.0, x, 1, y, 1 ); // $ExpectType OutputArray + gcusumkbn( x.length, 0.0, x, 1, y, 1 ); // $ExpectType Float64Array gcusumkbn( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType AccessorArray } From 959518d32652faaf249f52df15bec1b4a7275cc6 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:03:40 +0500 Subject: [PATCH 11/11] refactor: apply review suggestion Co-authored-by: Athan Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts index 6d22ada2c17c..4fd74484a6b8 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts @@ -141,7 +141,7 @@ import gcusumkbn = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType OutputArray + gcusumkbn.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType Float64Array gcusumkbn.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType AccessorArray }