-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: fix JavaScript lint errors (issue #8140) #8222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
2 similar comments
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this package, this approach is acceptable. Typically, we prefer to avoid making assumptions regarding file path locations, but the changes in this PR for this package are likely safe, and linting should flag if we, e.g., restructure the lib folder for whatever reason. As such, LGTM.
Relates to #8140.
Description
This pull request:
Fixes the ESLint/import-resolver
ENOENTcaused by@exampleblocks referencing non-existent files ('./beep.js','./boop.js') in@stdlib/utils/async/map-values.Updates the
@exampleblocks in:lib/node_modules/@stdlib/utils/async/map-values/lib/index.jslib/node_modules/@stdlib/utils/async/map-values/lib/main.jslib/node_modules/@stdlib/utils/async/map-values/lib/factory.jsReplaces placeholders with real, existing files and adds a cross-platform path join:
No runtime logic, public API, build tooling, or Make/workflow changes. This is an example-only adjustment to prevent the linter/import resolver from attempting to
statmissing paths.Related Issues
This pull request:
Questions
No.
Other
Scope & Intent
@stdlib/utils/async/map-values(the three files listed above).utils/async/*packages.Why this approach (and not tooling changes)
README.md,package.json) to avoid import-resolver file-system lookups failing on non-existent placeholders.Local Verification
Ran locally:
✅ No
ENOENToccurred and no new lint errors/warnings were introduced.Follow-up Plan
utils/async/*modules that still reference non-existent example files. Optionally open a tracking issue to audit and replace placeholder paths across affected packages.Checklist
@stdlib-js/reviewers