Skip to content

Conversation

@opbot-xd
Copy link
Contributor

@opbot-xd opbot-xd commented Dec 3, 2025

Replace tab indentation with 2-space indentation to comply with EditorConfig rules for JSON files.

Ref: https://github.com/stdlib-js/stdlib/actions/runs/19877531485


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_license_headers status: passed

Resolves #8725.

Description

What is the purpose of this pull request?

This pull request:

  • fixes an EditorConfig linting error in lib/node_modules/@stdlib/plot/base/ctor/lib/props/viewer/viewers.json by replacing tab indentation with 2-space indentation to comply with the project's EditorConfig rules for JSON files.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used GitHub Copilot to identify the EditorConfig issue.


@stdlib-js/reviewers

Replace tab indentation with 2-space indentation to comply with
EditorConfig rules for JSON files.

Ref: https://github.com/stdlib-js/stdlib/actions/runs/19877531485

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Dec 3, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 3, 2025
@opbot-xd
Copy link
Contributor Author

opbot-xd commented Dec 3, 2025

The CI test failure is not caused by this PR.

The test coverage workflow is detecting the changed file's directory (lib/node_modules/@stdlib/plot/base/ctor/lib/props/viewer) and attempting to run JavaScript tests on it. However, this is a sub-directory containing only a JSON configuration file and helper scripts—not a testable package.

Verification:

  • make lint-editorconfig-files passes locally
  • The JSON file now uses 2-space indentation as required by .editorconfig
  • The change is purely a whitespace fix (tabs → spaces)

The actual package is @stdlib/plot/base/ctor, and this PR does not modify any JavaScript code or tests.

cc @stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Dec 3, 2025

@opbot-xd Thanks for flagging. Yes, the CI failure is not due to changes in this PR. As such, we can go ahead and merge.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 3, 2025
@kgryte kgryte merged commit 5705eb2 into stdlib-js:develop Dec 3, 2025
66 of 67 checks passed
@kgryte
Copy link
Member

kgryte commented Dec 3, 2025

Thank you for your contribution and congratulations on your first PR!

nakul-krishnakumar pushed a commit to nakul-krishnakumar/stdlib that referenced this pull request Dec 3, 2025
PR-URL: stdlib-js#8731
Closes: stdlib-js#8725
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

3 participants