Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins options. #32

Merged
merged 4 commits into from Nov 26, 2014

Conversation

@m-mujica
Copy link
Contributor

commented Jul 10, 2014

No description provided.

@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2014

These are the same changes as #25, just applied to current master.

@matthewp

This comment has been minimized.

Copy link
Member

commented Aug 20, 2014

Hey @m-mujica can you update this 1 more time and I'll make sure it gets merged in.

@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2014

sorry @matthewp, just saw this, darn email filters. I'll do that and let you know when is ready.

@stevenvachon

This comment has been minimized.

Copy link

commented Sep 5, 2014

Excited for this one.

@m-mujica m-mujica force-pushed the plugins-options branch from 95a807e to 027e2b8 Sep 7, 2014
@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2014

@matthewp done!

@matthewp

This comment has been minimized.

Copy link
Member

commented Sep 7, 2014

@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2014

Sure, just added it.

@matthewp matthewp modified the milestone: 0.5.0 Nov 6, 2014
@m-mujica m-mujica force-pushed the plugins-options branch from f334b51 to 35b2f3e Nov 7, 2014
@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2014

Just added some docs for both cleanCSSOptions and uglifyOptions, but for some reason using @option {Object} or @option {{}} breaks the entire section.

screen shot 2014-11-07 at 13 24 39

If I remove the type definition, it works as expected:
screen shot 2014-11-07 at 13 22 59

cc: @justinbmeyer @matthewp

matthewp added a commit that referenced this pull request Nov 26, 2014
Plugins options.
@matthewp matthewp merged commit b2cec98 into master Nov 26, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@matthewp matthewp deleted the plugins-options branch Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.