Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configless steal multi-main bundle #506

Merged
merged 1 commit into from Aug 1, 2016

Conversation

Projects
None yet
4 participants
@pYr0x
Copy link
Contributor

commented Jul 30, 2016

a multi-main build with steal bundled

  • should not needed to specify a main in script tag
  • should work without config, just paste the script tag like <script src="./dist/bundles/multi-main-bundled/app_a.js"></script>

added steal.main to the add_steal.js

@pYr0x pYr0x changed the title modules with steal bundled should be configless work configless steal multi-main bundle Jul 30, 2016

@pYr0x pYr0x added this to the 1.0.0 milestone Jul 30, 2016

@coveralls

This comment has been minimized.

Copy link

commented Jul 30, 2016

Coverage Status

Coverage remained the same at 91.127% when pulling 9a6d7d0 on configless-multi-main-bundle into 6f44de8 on major.

@matthewp

This comment has been minimized.

Copy link
Member

commented Aug 1, 2016

Nice easy win 👍

@matthewp matthewp merged commit 8c87dd8 into major Aug 1, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.127%
Details

@matthewp matthewp deleted the configless-multi-main-bundle branch Aug 1, 2016

@matthewp matthewp removed the in progress label Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.