Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix so that steal("./resources/underscore.js") and steal("//app/resources #27

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

bman654 commented Jun 20, 2011

I was noticing that I was sometimes getting files stolen more than once. I tracked it down to one location where I had:

steal("//bpa/resources/underscore.js")

and in some other dependency that resides in the "resources" folder:

steal("./underscore.js");

Was due to the absolute path for the second case resolving to

//bpa/resources/./underscore.js
Brandon Wallace Fix so that steal("./resources/underscore.js") and steal("//app/resou…
…rces/underscore.js") do not load the file twice (as //app/./resources/underscore.js and //app/resources/underscore.js)
f4349f0
@ghost

ghost commented Jun 20, 2011

./ isn't supported. Though it might be in the next release.

I have to think about adding a few bytes for something that isn't supported.

@ghost

ghost commented Jun 20, 2011

But thanks for submitting a patch!

bman654 commented Jun 20, 2011

I've been using "./" based upon your steal preview post which suggested that very usage in the new steal() when you need to access a relative path.

@ghost

ghost commented Jun 20, 2011

Ah ... that's not in the current version of steal. And we are only 75% sure it's going to be in the next version.

If we use ./ in the next version, I'll pull this in.

bman654 commented Jun 20, 2011

I was just being proactive in my code since I'm pretty sure I'll switch to the new version when it is ready and wanted to minimize the conversion.

Thanks.

Contributor

moschel commented Jul 18, 2011

The ./ syntax is supported in the new version of steal that is now on master, so this patch is no longer necessary. The test case you provided should be working now. If you still see a problem, please let us know.

@moschel moschel closed this Jul 18, 2011

@moschel moschel added a commit that referenced this pull request Dec 21, 2011

@moschel moschel resolving #27 39b8993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment