Fix problems caused by recent system-npm release #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewp
added a commit
that referenced
this pull request
Nov 18, 2015
Fix problems caused by recent system-npm release
matthewp
added a commit
to donejs/cli
that referenced
this pull request
Nov 18, 2015
stealjs/steal#514 Addressed the issues that caused the roll back to 0.12.4. 0.12.7 now how those fixes and works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to have a couple of commits, the first is a revert to a revert that I did. This brings back the steal-systemjs change.
The next commit will be the new version of system-npm: stealjs/steal-npm#84
It was breaking in Node because of the wildcard paths change. There is a difference in the way the
#character is handled in Node vs the browser and system-npm was accounting for that.