Permalink
Commits on Apr 20, 2012
  1. merged 2.0

    fabpot committed Apr 20, 2012
  2. added a note about removing the default security rules when using SE …

    …as a starting point for your own app (closes #207)
    fabpot committed Apr 20, 2012
  3. merged branch robocoder/patch-1 (PR #312)

    Commits
    -------
    
    4a4e9cb Need to clearstatcache() after removing files/dirs via system().
    eb14691 bin/vendors: detect repo url change
    
    Discussion
    ----------
    
    [2.0] bin/vendors: detect repo url change
    
    For performance, our continuous integration server runs "bin/vendors update" instead of "bin/vendors install". This patch allows the script to detect a repo url change in "deps", e.g., switching from an upstream repo to a fork, or vice-versa.
    
    ---------------------------------------------------------------------------
    
    by robocoder at 2012-04-06T14:37:48Z
    
    I have resubmitted the PR with the correct commit range.
    
    ---------------------------------------------------------------------------
    
    by robocoder at 2012-04-06T15:12:15Z
    
    found a bug; going to investigate
    fabpot committed Apr 20, 2012
  4. merged branch brikou/master_swiftconfig (PR #308)

    Commits
    -------
    
    1d01bf5 added swiftmailer.delivery_address (commented) in config_dev.yml
    
    Discussion
    ----------
    
    added swiftmailer.delivery_address (commented) in config_dev.yml
    fabpot committed Apr 20, 2012
  5. merged branch mmoreramerino/master (PR #320)

    Commits
    -------
    
    3067d41 Fixed gitignore for vendor point. Also ignores vendor when is a file, like a soft link
    
    Discussion
    ----------
    
    Checked .gitignore
    
    vendor/ point in gitignore is only excluding files inside vendor as a folder.
    But, as vendor directory is very heavy, when developer has many repositories maybe want to have only one vendor and in all repositories only a soft link.
    
    So, with this commit, vendor is excluded as everything ( file, folder )
    fabpot committed Apr 20, 2012
  6. merged branch igorw/prevent-proxy-appdev (PR #318)

    Commits
    -------
    
    de70062 Prevent access to app_dev.php through proxy
    
    Discussion
    ----------
    
    [2.0] Prevent access to app_dev.php through proxy
    
    Proxies are sometimes on the same machine as the webserver, so they will gain access to app_dev.php, as they have a localhost IP.
    
    That makes app_dev.php accessible by default in such setups.
    
    This commit disallows access to app_dev.php if proxy headers are present.
    fabpot committed Apr 20, 2012
  7. merged branch jalliot/patch-1 (PR #321)

    Commits
    -------
    
    89574ba Update for latest composer change
    
    Discussion
    ----------
    
    Update for latest composer change
    
    BTW I don't think it's the file's job to download composer installer (it doesn't even check if composer.phar is in the current directory before).
    On my machine for instance, I have a global composer.phar in my PATH...
    Checking for existence of vendors and dying if they don't exist is enough IMHO
    fabpot committed Apr 20, 2012
Commits on Apr 19, 2012
Commits on Apr 18, 2012
  1. Fixed gitignore for vendor point. Also ignores vendor when is a file,…

    … like a soft link
    marc committed Apr 18, 2012
Commits on Apr 12, 2012
  1. Prevent access to app_dev.php through proxy

    Proxies are sometimes on the same machine as the webserver, so they will gain
    access to app_dev.php, as they have a localhost IP.
    
    That makes app_dev.php accessible by default in such setups.
    
    This commit disallows access to app_dev.php if proxy headers are present.
    igorw committed Apr 12, 2012
Commits on Apr 6, 2012
  1. bin/vendors: detect repo url change

    For performance, our continuous integration server runs "bin/vendors update" instead of "bin/vendors install". This patch allows the script to detect a repo url change in "deps", e.g., switching from an upstream repo to a fork, or vice-versa.
    Anthon Pang committed Apr 6, 2012
  2. merged branch meonkeys/2.0 (PR #306)

    Commits
    -------
    
    ed50bb4 bin/vendors: Exiting early? Return nonzero status.
    cb6a2a7 merged branch brikou/2.0 (PR #301)
    0cba534 cosmetic tweaks
    
    Discussion
    ----------
    
    bin/vendors: Exiting early? Return nonzero status.
    
    I currently use bin/vendors in several automated build scripts. This
    makes it easier for calling scripts to reliably recognize when
    bin/vendors exits early.
    
    I know bin/vendors is going away, but until symfony2 2.1 is
    released, I'll probably still be using it.
    
    ---------------------------------------------------------------------------
    
    by brikou at 2012-03-27T20:24:43Z
    
    Exit is ok only with 0 which means "everything is fine" else it means "errors encountered",
     so actual usage is fine... Cheer
    
    ---------------------------------------------------------------------------
    
    by meonkeys at 2012-03-27T20:38:44Z
    
    @brikou what? Are you saying you agree with the patch or disagree?
    
    My justification is that unless `bin/vendors` proceeds to completion successfully, a nonzero exit code should be returned. This is pretty standard POSIX behavior.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-03-27T21:04:11Z
    
    @meonkeys most recent PRs about the vendors script have been rejected by @fabpot because it was only a temporary solution for 2.0.x waiting for composer to be ready. The master branch of the SE repo (which will become the 2.1 release) does not use the script anymore.
    
    ---------------------------------------------------------------------------
    
    by meonkeys at 2012-03-27T21:06:25Z
    
    @stof yep, I totally get that. Like I said, I'll have to live with this script until 2.1 is released, so I thought I'd share my patch upstream.
    
    @fabpot no worries if you want to reject this. I look forward to composer!
    fabpot committed Apr 6, 2012
  3. merged branch brikou/patch-3 (PR #309)

    Commits
    -------
    
    cc69fa9 fixed missing space
    
    Discussion
    ----------
    
    fixed missing space
    fabpot committed Apr 6, 2012
  4. merged branch jstout24/master (PR #310)

    Commits
    -------
    
    d73abb9 added JMSDiExtraBundle to readme
    
    Discussion
    ----------
    
    added JMSDiExtraBundle to readme
    
    This still needs documentation
    
    I see that it's located http://jmsyst.com/bundles/JMSDiExtraBundle and should be ported to Symfony.com's docs.
    fabpot committed Apr 6, 2012
  5. merged branch Tobion/requirements-refactor (PR #258)

    Commits
    -------
    
    4632103 added RequirementCollection
    f7c1316 added specialized PhpIniRequirement class
    cbaf855 added upstream requirements
    0e56f19 replace __DIR__ with dirname(__FILE__) for PHP<5.3
    d4e0efe short ternary operator not available in PHP 5.2 and language adjustments
    aa0da83 reduce help duplication by inferring text from html version
    163aa49 made requirements check compatible with PHP 5.2
    46e8e5a refactor Symfony requirements
    
    Discussion
    ----------
    
    Refactor Symfony requirements
    
    The requirements checks were duplicated for the web-based `web/config.php` and console-based `app/check.php` scripts. So I refactored the symfony requirements to its own class that is easier to modify and reuse. Feel free to make suggestions.
    
    Both scripts behave as before, just some cosmetic changes in the output.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-02-04T20:49:30Z
    
    @fabpot all ready now
    
    ---------------------------------------------------------------------------
    
    by brikou at 2012-03-16T08:10:27Z
    
    this addition would be even greater if a cookbook was written explaining how to extend this requirement check in order to add custom requirements (for example checking that php gd extension is installed for a custom project)
    
    ;)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-03-31T14:36:50Z
    
    @vicb @fabpot ping
    I rebased and added a `RequirementCollection`. That allows a custom project to specify it's own requirements (subclasssing `RequirementCollection`) and then optionally merging the Symfony requirements (`RequirementCollection->addCollection()`).
    Naming is inspired by `RouteCollection`.
    
    ---------------------------------------------------------------------------
    
    by brikou at 2012-03-31T14:58:14Z
    
    @Tobion looks great ;)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-06T01:01:19Z
    
    Can it be merged? I don't want to rebase again. Are there any objections?
    fabpot committed Apr 6, 2012
Commits on Apr 4, 2012
  1. added JMSDiExtraBundle to readme

    j committed Apr 4, 2012
Commits on Apr 2, 2012
  1. fixed missing space

    brikou committed Apr 2, 2012
Commits on Mar 31, 2012
  1. added RequirementCollection

    Tobion committed Mar 31, 2012
Commits on Mar 29, 2012
  1. added upstream requirements

    Tobion committed Mar 29, 2012
  2. refactor Symfony requirements

    Tobion committed Jan 14, 2012
Commits on Mar 28, 2012
Commits on Mar 27, 2012
  1. bin/vendors: Exiting early? Return nonzero status.

    I currently use bin/vendors in several automated build scripts. This
    makes it easier for calling scripts to reliably recognize when
    bin/vendors exits early.
    meonkeys committed Mar 27, 2012
Commits on Mar 23, 2012
  1. merged branch brikou/2.0 (PR #301)

    Commits
    -------
    
    0cba534 cosmetic tweaks
    
    Discussion
    ----------
    
    [bin/vendors] added line feeds between each install/update parts
    fabpot committed Mar 23, 2012
  2. merged branch igorw/parameters-indentation (PR #300)

    Commits
    -------
    
    9c74db8 Change parameters.yml indentation to 4 spaces
    
    Discussion
    ----------
    
    Change parameters.yml indentation to 4 spaces
    
    This is consistent with the other `.yml` files in `app/config`.
    fabpot committed Mar 23, 2012
Commits on Mar 21, 2012
  1. cosmetic tweaks

    brikou committed Mar 21, 2012
Commits on Mar 20, 2012
Commits on Mar 19, 2012
  1. removed obsolete bin directory

    fabpot committed Mar 19, 2012