Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot does not handle receiving an empty CheckRevision seed #10

Closed
Davnit opened this issue Apr 26, 2016 · 3 comments

Comments

@Davnit
Copy link
Collaborator

commented Apr 26, 2016

When using BNLS, the bot will pass the empty string to the BNLS server. Some servers may not handle this either, and cause the bot to get stuck connecting.

When using hashing, a somewhat cryptic message regarding warden is shown, and diagnosing the actual problem can be difficult.

@Davnit Davnit self-assigned this Apr 26, 2016

@Davnit

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2016

Fixed in f9e0953

@Davnit Davnit closed this Apr 26, 2016

@LexManos

This comment has been minimized.

Copy link

commented Apr 26, 2016

When is this even a thing?

@Davnit

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 27, 2016

When you send BNCS a version byte that it doesn't recognize. For example, sending 0x0F for D2DV right now (the current verbyte is 0x0E).

@nmbook nmbook added the bug label Apr 28, 2016

@Davnit Davnit added the BNCS label May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.