Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends packets handling #12

Closed
nmbook opened this issue Apr 26, 2016 · 4 comments

Comments

@nmbook
Copy link
Collaborator

commented Apr 26, 2016

Check whether SID_FRIENDSUPDATE, SID_FRIENDSADD, SID_FRIENDSREMOVE, and SID_FRIENDSPOSITION are correctly updating the friends list.

I have a suspicion only SID_FRIENDSLIST is causing the actual list to update, even though we fully parse the packets and create internal events. And since I decreased the frequency of getting the list with a change to the way the idle timer works, it's more obvious. Perhaps slightly increase the SID_FRIENDSLIST frequency.

@Davnit

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2016

I can confirm that SID_FRIENDSADD and SID_FRIENDSREMOVE do not do anything to the list view. There is code there, but it's commented out.

SID_FRIENDSPOSITION causes the bot to send SID_FRIENDSLIST (requesting the complete listing).

SID_FRIENDSUPDATE appears to at least try to update the list view.

Also most of the packet ID constants in this area are misnamed.

@nmbook

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2016

I think that Stealth researched the friend and clan packets himself, since while they are straightforward, they were probably really new back in 2004 (added for W3) and not really known. But never bothered to complete the handling for the friend internal events, I guess. I don't even know.

@Davnit

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2016

The system is even more broken than originally believed. Neither the internal list (g_Friends) or the UI listview are being updated at all except for on receipt of SID_FRIENDSLIST, which isn't being regularly requested for some reason.

@Davnit Davnit self-assigned this Apr 27, 2016

@Davnit

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2016

Fixed/updated in e74d71f

@Davnit Davnit closed this Apr 27, 2016

@nmbook nmbook added the bug label Apr 28, 2016

@Davnit Davnit added the BNCS label May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.