Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/rem command has confusing behavior #37

Closed
Davnit opened this issue Mar 7, 2017 · 0 comments

Comments

@Davnit
Copy link
Collaborator

commented Mar 7, 2017

[21:43:48.596] <Pyro> .add BoT 60 --type clan
[21:43:49.161] <StealthBot> BoT (clan) has been given rank 60.
[21:44:30.456] <Pyro> .set BoT 60 OS
[21:44:30.945] <StealthBot> BoT has been given rank 60 and flags OS.
[21:44:35.336] <Pyro> .rem BoT
[21:44:35.770] <StealthBot> BoT (clan) has been removed from the database.
[21:44:41.176] <Pyro> .rem BoT
[21:44:41.638] <StealthBot> BoT has been removed from the database.
[21:44:44.783] <Pyro> ???

/rem BoT --type clan, even when there is an entry for "BoT (clan)" returns "user not found"

The /rem command should (IMO) either default to removing the user or prompt for clarification in the case that multiple entries match the input. At the very least it should support the --type modifier that the /add command does.

Davnit added a commit that referenced this issue Mar 14, 2017

Require intent when deleting group through command
If you use the /rem command and the affected entry would be a group, you
now have to explicitly specify the entry type (using --type group). The
user will be prompted if they do not do this.

Perhaps this could be improved to seek out users first before groups but
this will do for now.

Finishes implementing #37
Part of the database overhaul included adding support for the --type
argument to the remove command.

@Davnit Davnit closed this Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.