Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some phraseban-related commands are broken #59

Closed
Davnit opened this issue Dec 12, 2017 · 1 comment

Comments

@Davnit
Copy link
Collaborator

commented Dec 12, 2017

When there are no configured phrase bans, the /phrases command results in:
Error: #5: Invalid procedure call or argument in modCommandCode.ProcessCommand().

Trying to remove a phrase with the /pdel command results in:
Error: #52: Bad file name or number in modCommandCode.ProcessCommand().
Though apparently the phrase is still removed.

 [04:51:16] <Pyro> .phrases
 [04:51:16] Error: #5: Invalid procedure call or argument in modCommandCode.ProcessCommand().
 [04:51:19] <Pyro> .help phrases
 [04:51:19] <StealthBot> [phrases (alias: plist)]: States the currently active phrasebans. [syntax: .phrases [subcommand]*] Requires rank 50 or one of the following flags: O.
 [04:51:24] <Pyro> BUG ALERT
 [04:51:27] <Derek#USEast> :o
 [04:51:39] <StealthBot>  [04:51:16] Error: #5: Invalid procedure call or argument in modCommandCode.ProcessCommand().
 [04:52:14] <Pyro> .padd fuckmonkey
 [04:52:14] <StealthBot> Phraseban "fuckmonkey" added.
 [04:52:18] <Pyro> .phrases
 [04:52:18] <StealthBot> Banned phrases: fuckmonkey
 [04:52:27] <Pyro> .pdel fuckmonkey
 [04:52:27] Error: #52: Bad file name or number in modCommandCode.ProcessCommand().
 [04:52:44] <Pyro> oh well
 [04:52:48] <Pyro> apparently i can't remove that now
 [04:55:09] <Pyro> .phrases
 [04:55:09] Error: #5: Invalid procedure call or argument in modCommandCode.ProcessCommand().
 [04:55:13] <Pyro> oh
 [04:55:18] <Pyro> apparently it "worked"

@Davnit Davnit added the bug label Dec 12, 2017

@Davnit Davnit added this to the 492 milestone Dec 12, 2017

@Davnit

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2018

The phrase ban system in general is broken. Applying on the settings form is clearing the entire phraseban list.

Cross reference with forum thread here: http://www.stealthbot.net/forum/index.php?/topic/7944-phraselist-resets-itself/

@Davnit Davnit self-assigned this May 6, 2018

Davnit added a commit that referenced this issue May 6, 2018

More consistent FreeFile() calls.
It was missing in someplaces. I did a check for 'open x for y as #z'
calls and now it's called before each open, only when a file is actually
going to be opened.

There was also one case in the SSC where static file numbers were used
that now uses FreeFile().

This should fix  some of the problems from issue #59.

@Davnit Davnit closed this in bd75fc1 May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.