New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support atom-ide busy-signal API #63

Merged
merged 5 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@lloiser
Copy link
Collaborator

lloiser commented Dec 29, 2018

see https://github.com/facebookarchive/atom-ide-ui/blob/master/docs/busy-signal.md

Motivation
atom-ide-ui has been archived and sooner or later should be replaced by something else.
This package is already installed by a lot of atom users so it's a perfect fit to add the busy signal API here.

TODO

  • tests
  • support onlyForFile and onDidClick options

The actual implementation happened in the second commit. In the first commit I updated all dependencies, I hope this does not cause any troubles when reviewing it.
I have also skipped the other options from the BusySignalOptions object because IMO they are not worth the hassle (at least for the moment).

@DamnedScholar

This comment has been minimized.

Copy link

DamnedScholar commented Dec 29, 2018

For context and posterity: this PR was spurred by and is relevant to a conversation happening on the Atom Discourse about what parts of the former Facebook project can be rescued and put under community control.

@steelbrain

This comment has been minimized.

Copy link
Owner

steelbrain commented Dec 29, 2018

Hi @lloiser

I've sent a request your way for rights on the repository. I don't think I'll be able to maintain this so feel free to work on this PR and merge this or any other change you find fit, from collaborating with you on other projects, I trust your judgement.

Have fun and thanks for this! 🙇

@lloiser

This comment has been minimized.

Copy link
Collaborator

lloiser commented Jan 1, 2019

A quick search on github revealed that there aren't many packages that use the options that were previously provided by the busy signal of atom-ide-ui.
I tried to implement them but I think they unnecessarily complicate the code. So I have decided to not implement them yet. If people are actually missing these features they can be added later.

@lloiser

This comment has been minimized.

Copy link
Collaborator

lloiser commented Jan 1, 2019

I will merge this and publish a new version tomorrow unless anybody wants to review the code or convince me of implementing these options 😁

@lloiser lloiser merged commit 2d61a67 into steelbrain:master Jan 2, 2019

@lloiser lloiser deleted the lloiser:atom-ide branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment