New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wipe messages for file if it is opened multiple times #1598

Merged
merged 3 commits into from Jan 1, 2019

Conversation

Projects
None yet
2 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Oct 12, 2018

This addresses the issue described in #1510

Preview

This first gif shows the current behaviour, the two JS editors are for the same file. Notice how the linting errors in the bottom now longer show up when focusing the editor at the top.
current behaviour

This second gif shows the new behaviour, the two JS editors are for the same file. Notice how the linting errors in the bottom still show up when focusing the editor at the top.
new bahaviour

Alternative implementations

I'm not sure if the implementation I chose is desired. My reasoning behind it is that the information (thereIsAnotherEditorForTheSameFile) might be useful in other scenarios as well. Alternatively the check for other buffers can be performed in the deleteByBuffer in the MessageRegistry.

Also, let me know if the variable name thereIsAnotherEditorForTheSameFile is too much 馃槢

Limitations 鈿狅笍

This PR does not fix everything noted in or related to #1510. For example, in the second gif you can see that the lint-gutter of the editor at the top stops working when the editor at the bottom is closed.

@steelbrain steelbrain changed the base branch from master to maintenance Jan 1, 2019

@steelbrain

This comment has been minimized.

Copy link
Owner

steelbrain commented Jan 1, 2019

Thank you for working on this!

@steelbrain steelbrain merged commit 28563ef into steelbrain:maintenance Jan 1, 2019

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@steelbrain steelbrain referenced this pull request Jan 2, 2019

Merged

Maintenance #1604

@ericcornelissen ericcornelissen deleted the ericcornelissen:bug-1510 branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment