Skip to content
This repository has been archived by the owner. It is now read-only.

Sitemap generator script #41

merged 8 commits into from Oct 29, 2018


None yet
2 participants
Copy link

commented Oct 27, 2018

Sitemap generator has been added.

NPM's postbuild forces script to generate sitemap.xml in docs/.vuepress/public directory.

Related issue: #29

Copy link

left a comment

Thanks! I'm super excited about this.

Two things:

  • Big (friendly) push back on adding esm to the project. Is it necessary? I'm always open to be convinced.
  • Do you mind adding at least one unit test? I'll take care of setting up the runner, just add a file like sitemap.js to /tests using this form:
var tape = require('tape')

tape('verify a fact', function (assert) {
  var numberOne = 1

  assert.equal(numberOne, 1)
@@ -7,6 +7,7 @@
"scripts": {
"start": "vuepress dev docs",
"build": "vuepress build docs",
"postbuild": "node scripts/sitemap-generator.js",
"test": "npm run build"

This comment has been minimized.

Copy link

kareniel Oct 28, 2018



adasq added some commits Oct 28, 2018


This comment has been minimized.

Copy link
Collaborator Author

commented Oct 28, 2018

Hey @kareniel, Thank you for the in-depth review.

According to the esm. I added it because of the node_modules/@vuepress/core/.temp/internal/siteData.js file is ES module. Nodejs does not support ES imports natively yet. But I think it is no longer a problem, as I changed an approach. I used community plugin to solve the problem (see package.json) so now, those information are being retrieved from plugin context rather than file directly.


This comment has been minimized.

Copy link

commented Oct 29, 2018

Awesome. Thanks a lot!

Merging :)

@kareniel kareniel merged commit a1c2b9d into steemdocs:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@adasq adasq deleted the adasq:sitemap-generator-script branch Oct 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.