New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote count beyond 30 days always shows 0 #188

Closed
aaroncox opened this Issue Aug 26, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@aaroncox
Contributor

aaroncox commented Aug 26, 2016

After a posts 30-day payout, the active_votes array is returned from the API empty. This causes posts past 30 days to lose their vote counts.

The culprit is VotesAndComments.jsx - Line #54.

@jcalfee

This comment has been minimized.

Show comment
Hide comment
@jcalfee

jcalfee Aug 31, 2016

Contributor

When steemit/steem#337 is completely UI updates may be needed.

Contributor

jcalfee commented Aug 31, 2016

When steemit/steem#337 is completely UI updates may be needed.

@roadscape

This comment has been minimized.

Show comment
Hide comment
@roadscape

roadscape Sep 8, 2016

Contributor

There is a build option CLEAR_VOTES that clears votes from consensus that is on by default.

-DCLEAR_VOTES=OFF will keep them around. Not sure if it stores new votes after an archived post though... Will check on that.

Ultimately, this will be moved to a plugin rather than a build option, but it was an easy workaround.

I'll check if we can use this flag on steemit.com nodes

Contributor

roadscape commented Sep 8, 2016

There is a build option CLEAR_VOTES that clears votes from consensus that is on by default.

-DCLEAR_VOTES=OFF will keep them around. Not sure if it stores new votes after an archived post though... Will check on that.

Ultimately, this will be moved to a plugin rather than a build option, but it was an easy workaround.

I'll check if we can use this flag on steemit.com nodes

@Gandalf-the-Grey

This comment has been minimized.

Show comment
Hide comment
@Gandalf-the-Grey

Gandalf-the-Grey Sep 17, 2016

Contributor

Checked, used, fixed.

Contributor

Gandalf-the-Grey commented Sep 17, 2016

Checked, used, fixed.

@roadscape roadscape closed this Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment